CORE-430: retire snapshot-by-reference (#5316)

Author: davidangb

src/libs/ajax/workspaces/Workspaces.ts

@@ -285,28 +285,6 @@ export const Workspaces = (signal?: AbortSignal) => ({
         );
       },
 
-      snapshot: (snapshotId: string) => {
-        const snapshotPath = `${root}/snapshots/v2/${snapshotId}`;
-
-        return {
-          details: async () => {
-            const res = await fetchRawls(snapshotPath, _.merge(authOpts(), { signal }));
-            return res.json();
-          },
-
-          update: (updateInfo) => {
-            return fetchRawls(
-              snapshotPath,
-              _.mergeAll([authOpts(), jsonBody(updateInfo), { signal, method: 'PATCH' }])
-            );
-          },
-
-          delete: (): Promise<Response> => {
-            return fetchRawls(snapshotPath, _.merge(authOpts(), { signal, method: 'DELETE' }));
-          },
-        };
-      },
-
       submission: (submissionId: string) => {
         const submissionPath = `${root}/submissions/${submissionId}`;
 

src/libs/analysis.js

@@ -3,7 +3,6 @@ import { Workspaces } from 'src/libs/ajax/workspaces/Workspaces';
 import * as Utils from 'src/libs/utils';
 
 export const launch = async ({
-  isSnapshot,
   workspace: {
     workspace: { namespace, name, googleProject, bucketName },
     accessLevel,
@@ -48,7 +47,7 @@ export const launch = async ({
     );
   }
   const { entityName, processSet = false } = await Utils.cond(
-    [isSnapshot || selectedEntityType === undefined, () => ({})],
+    [selectedEntityType === undefined, () => ({})],
     [
       `${selectedEntityType}_set` === rootEntityType,
       async () => {

src/pages/workspaces/workspace/workflows/EntitySelectionType.js

@@ -1,4 +1,3 @@
 export const chooseRootType = Symbol('choose-root-type');
 export const chooseBaseType = Symbol('choose-base-type');
 export const chooseSetType = Symbol('choose-set-type');
-export const processSnapshotTable = Symbol('process snapshot table');

src/pages/workspaces/workspace/workflows/LaunchAnalysisModal.js

@@ -17,12 +17,11 @@ import { useCancellation, useOnMount } from 'src/libs/react-utils';
 import { warningBoxStyle } from 'src/libs/style';
 import * as Utils from 'src/libs/utils';
 import { commentValidation } from 'src/pages/workspaces/workspace/submissionHistory/UpdateUserCommentModal';
-import { chooseBaseType, chooseRootType, chooseSetType, processSnapshotTable } from 'src/pages/workspaces/workspace/workflows/EntitySelectionType';
+import { chooseBaseType, chooseRootType, chooseSetType } from 'src/pages/workspaces/workspace/workflows/EntitySelectionType';
 import { isBatchSetting } from 'src/workspaces/SettingsModal/utils';
 
 const LaunchAnalysisModal = ({
   onDismiss,
-  entityMetadata,
   workspace,
   workspace: {
     workspace: { namespace, name: workspaceName, googleProject },
@@ -94,11 +93,9 @@ const LaunchAnalysisModal = ({
                 };
           },
         ],
-        [type === chooseBaseType, () => ({ selectedEntityType: baseEntityType, selectedEntityNames: _.keys(selectedEntities) })],
-        [type === processSnapshotTable, () => ({ selectedEntityType: rootEntityType })]
+        [type === chooseBaseType, () => ({ selectedEntityType: baseEntityType, selectedEntityNames: _.keys(selectedEntities) })]
       );
       const { submissionId } = await launch({
-        isSnapshot: type === processSnapshotTable,
         workspace,
         config,
         selectedEntityType,
@@ -129,7 +126,6 @@ const LaunchAnalysisModal = ({
   const mergeSets = _.flatMap(`attributes.${rootEntityType}s.items`);
   const entityCount = Utils.cond(
     [processSingle, () => 1],
-    [type === processSnapshotTable, () => entityMetadata[rootEntityType].count],
     [type === chooseRootType, () => _.size(selectedEntities)],
     [type === chooseBaseType, () => 1],
     [type === chooseSetType, () => _.flow(mergeSets, _.uniqBy('entityName'))(selectedEntities).length]

src/pages/workspaces/workspace/workflows/LaunchAnalysisModal.test.ts

@@ -47,7 +47,6 @@ describe('Launch Analysis Modal', () => {
     const namespace = 'test-namespace';
     const name = 'test-workspace';
     const googleProject = 'google-project-id';
-    const entityMetadata = {};
     const workspace = { workspace: { namespace, name, googleProject } };
     const config = { rootEntityType: 'sample' };
     const entitySelectionModel = {
@@ -76,7 +75,6 @@ describe('Launch Analysis Modal', () => {
       render(
         h(LaunchAnalysisModal, {
           workspace,
-          entityMetadata,
           config,
           entitySelectionModel,
           perWorkflowCostCap,
@@ -114,7 +112,6 @@ describe('Launch Analysis Modal', () => {
     const namespace = 'test-namespace';
     const name = 'test-workspace';
     const googleProject = 'google-project-id';
-    const entityMetadata = {};
     const workspace = { workspace: { namespace, name, googleProject } };
     const config = { rootEntityType: 'sample' };
     const entitySelectionModel = {
@@ -143,7 +140,6 @@ describe('Launch Analysis Modal', () => {
       render(
         h(LaunchAnalysisModal, {
           workspace,
-          entityMetadata,
           config,
           entitySelectionModel,
           perWorkflowCostCap,