ID-1174 Combine loadTerraUser sam api calls into one

Ghost-in-a-Jar · Ghost-in-a-Jar · commit a96ad942dba6 · 2024-05-17T15:54:21.000-04:00
diff --git a/src/auth/auth.ts b/src/auth/auth.ts
@@ -480,20 +480,10 @@ export const loadTerraUser = async (): Promise<void> => {
   try {
     const signInStatus = 'userLoaded';
     const getProfile = Ajax().User.profile.get();
-    const getAllowances = Ajax().User.getUserAllowances();
-    const getAttributes = Ajax().User.getUserAttributes();
-    const getTermsOfService = Ajax().TermsOfService.getUserTermsOfServiceDetails();
-    const getEnterpriseFeatures = Ajax().User.getEnterpriseFeatures();
-    const getSamUser = Ajax().User.getSamUserResponse();
-    const [profile, terraUserAllowances, terraUserAttributes, termsOfService, enterpriseFeatures, samUser] =
-      await Promise.all([
-        getProfile,
-        getAllowances,
-        getAttributes,
-        getTermsOfService,
-        getEnterpriseFeatures,
-        getSamUser,
-      ]);
+    const getCombinedState = Ajax().User.getSamUserCombinedState();
+    const [profile, terraUserCombinedState] = await Promise.all([getProfile, getCombinedState]);
+    const { terraUserAttributes, enterpriseFeatures, samUser, terraUserAllowances, termsOfService } =
+      terraUserCombinedState;
     clearNotification(sessionTimeoutProps.id);
     userStore.update((state: TerraUserState) => ({
       ...state,
diff --git a/src/auth/login.test.ts b/src/auth/login.test.ts
@@ -5,8 +5,8 @@ import { loadTerraUser } from 'src/auth/auth';
 import { Ajax } from 'src/libs/ajax';
 import { GroupRole } from 'src/libs/ajax/Groups';
 import { SamUserTermsOfServiceDetails } from 'src/libs/ajax/TermsOfService';
-import { SamUserResponse } from 'src/libs/ajax/User';
-import { TerraUserState, userStore } from 'src/libs/state';
+import { SamUserAttributes, SamUserCombinedStateResponse, SamUserResponse } from 'src/libs/ajax/User';
+import { userStore } from 'src/libs/state';
 
 jest.mock('src/libs/ajax');
 
@@ -67,6 +67,14 @@ const testSamUserAllowances = {
   details: testSamUserAllowancesDetails,
 };
 
+const mockSamUserCombinedState: SamUserCombinedStateResponse = {
+  samUser: mockSamUserResponse,
+  terraUserAllowances: testSamUserAllowances,
+  terraUserAttributes: { marketingConsent: false } as SamUserAttributes,
+  termsOfService: mockSamUserTermsOfServiceDetails,
+  enterpriseFeatures: [],
+};
+
 const mockNihDatasetPermission = {
   name: 'testNihDatasetPermissionName',
   authorized: true,
@@ -92,25 +100,17 @@ describe('a request to load a terra user', () => {
   });
   describe('when successful', () => {
     // Arrange (shared between tests for the success case)
-    const getUserAllowancesFunction = jest.fn().mockResolvedValue(testSamUserAllowances);
-    const getUserAttributesFunction = jest.fn().mockResolvedValue({ marketingConsent: false });
-    const getUserTermsOfServiceDetailsFunction = jest.fn().mockResolvedValue(mockSamUserTermsOfServiceDetails);
-    const getEnterpriseFeaturesFunction = jest.fn().mockResolvedValue([]);
-    const getSamUserResponseFunction = jest.fn().mockResolvedValue(mockSamUserResponse);
-    const getNihStatusFunction = jest.fn().mockResolvedValue(mockOrchestrationNihStatusResponse);
-    const getFenceStatusFunction = jest.fn().mockResolvedValue({});
+    const getSamUserCombinedStateMock = jest.fn().mockResolvedValue(mockSamUserCombinedState);
+    const getNihStatusMock = jest.fn().mockResolvedValue(mockOrchestrationNihStatusResponse);
+    const getFenceStatusMock = jest.fn().mockResolvedValue({});
 
     asMockedFn(Ajax).mockImplementation(
       () =>
         ({
           User: {
-            getUserAllowances: getUserAllowancesFunction,
-            getUserAttributes: getUserAttributesFunction,
-            getUserTermsOfServiceDetails: getUserTermsOfServiceDetailsFunction,
-            getEnterpriseFeatures: getEnterpriseFeaturesFunction,
-            getSamUserResponse: getSamUserResponseFunction,
-            getNihStatus: getNihStatusFunction,
-            getFenceStatus: getFenceStatusFunction,
+            getSamUserCombinedState: getSamUserCombinedStateMock,
+            getNihStatus: getNihStatusMock,
+            getFenceStatus: getFenceStatusMock,
             profile: {
               get: jest.fn().mockReturnValue(mockTerraUserProfile),
             },
@@ -128,39 +128,27 @@ describe('a request to load a terra user', () => {
       await act(() => loadTerraUser());
 
       // Assert
-      expect(getSamUserResponseFunction).toHaveBeenCalled();
+      expect(getSamUserCombinedStateMock).toHaveBeenCalled();
     });
     it('should update the samUser in state', async () => {
       // Act
       await act(() => loadTerraUser());
 
-      let samUser;
-      await act(async () => {
-        samUser = await getSamUserResponseFunction.mock.results[0].value;
-      });
-      userStore.update((state: TerraUserState) => ({
-        ...state,
-        samUser,
-      }));
       // Assert
-      expect(getSamUserResponseFunction).toHaveBeenCalled();
+      expect(getSamUserCombinedStateMock).toHaveBeenCalled();
       expect(userStore.get().samUser).toEqual(mockSamUserResponse);
     });
     describe('when not successful', () => {
       it('should fail with an error', async () => {
         // // Arrange
         // mock a failure to get samUserResponse
-        const getSamUserResponseFunction = jest.fn().mockRejectedValue(new Error('unknown'));
+        const getSamUserCombinedStateMockFailure = jest.fn().mockRejectedValue(new Error('unknown'));
 
         asMockedFn(Ajax).mockImplementation(
           () =>
             ({
               User: {
-                getUserAllowances: getUserAllowancesFunction,
-                getUserAttributes: getUserAttributesFunction,
-                getUserTermsOfServiceDetails: getUserTermsOfServiceDetailsFunction,
-                getEnterpriseFeatures: getEnterpriseFeaturesFunction,
-                getSamUserResponse: getSamUserResponseFunction,
+                getSamUserCombinedState: getSamUserCombinedStateMockFailure,
                 profile: {
                   get: jest.fn().mockReturnValue(mockTerraUserProfile),
                 },
diff --git a/src/libs/ajax/User.ts b/src/libs/ajax/User.ts
@@ -1,5 +1,6 @@
 import _ from 'lodash/fp';
 import { authOpts, fetchOrchestration, fetchSam, jsonBody } from 'src/libs/ajax/ajax-common';
+import { SamUserTermsOfServiceDetails } from 'src/libs/ajax/TermsOfService';
 import { TerraUserProfile } from 'src/libs/state';
 
 export interface SamUserRegistrationStatusResponse {
@@ -162,6 +163,14 @@ export type SamUserAttributesRequest = {
   marketingConsent: boolean | undefined;
 };
 
+export type SamUserCombinedStateResponse = {
+  samUser: SamUserResponse;
+  terraUserAllowances: SamUserAllowances;
+  terraUserAttributes: SamUserAttributes;
+  termsOfService: SamUserTermsOfServiceDetails;
+  enterpriseFeatures: string[];
+};
+
 export type OrchestrationUserRegistrationRequest = object;
 
 export const User = (signal?: AbortSignal) => {
@@ -171,11 +180,6 @@ export const User = (signal?: AbortSignal) => {
       return res.json();
     },
 
-    getUserAllowances: async (): Promise<SamUserAllowances> => {
-      const res = await fetchSam('api/users/v2/self/allowed', _.mergeAll([authOpts(), { signal }]));
-      return res.json();
-    },
-
     getUserAttributes: async (): Promise<SamUserAttributes> => {
       const res = await fetchSam('api/users/v2/self/attributes', _.mergeAll([authOpts(), { signal }]));
       return res.json().then((obj) => {
@@ -192,17 +196,9 @@ export const User = (signal?: AbortSignal) => {
       return res.json();
     },
 
-    getEnterpriseFeatures: async (): Promise<string[]> => {
-      try {
-        const res = await fetchSam(
-          '/api/resources/v2?format=flat&resourceTypes=enterprise-feature&roles=user',
-          _.mergeAll([authOpts(), { signal }])
-        );
-        const json = await res.json();
-        return json.resources.map((resource) => resource.resourceId);
-      } catch (error: unknown) {
-        return [];
-      }
+    getSamUserCombinedState: async (): Promise<SamUserCombinedStateResponse> => {
+      const res = await fetchSam('/api/user/v2/self/combinedState', _.mergeAll([authOpts(), { signal }]));
+      return res.json();
     },
 
     registerWithProfile: async (
@@ -267,21 +263,6 @@ export const User = (signal?: AbortSignal) => {
       return res.json();
     },
 
-    getSamUserResponse: async (): Promise<SamUserResponse> => {
-      const res = await fetchSam('api/users/v2/self', _.mergeAll([authOpts(), { method: 'GET' }]));
-      const json = await res.json();
-      return {
-        id: json.id,
-        googleSubjectId: json.googleSubjectId,
-        email: json.email,
-        azureB2CId: json.azureB2CId,
-        allowed: json.allowed,
-        createdAt: json.createdAt ? new Date(json.createdAt) : undefined,
-        registeredAt: json.registeredAt ? new Date(json.registeredAt) : undefined,
-        updatedAt: json.updatedAt ? new Date(json.updatedAt) : undefined,
-      };
-    },
-
     getNihStatus: async (): Promise<OrchestrationNihStatusResponse | undefined> => {
       try {
         const res = await fetchOrchestration('api/nih/status', _.merge(authOpts(), { signal }));
diff --git a/src/registration/terms-of-service/TermsOfServicePage.test.ts b/src/registration/terms-of-service/TermsOfServicePage.test.ts
@@ -3,7 +3,7 @@ import { act, fireEvent, screen } from '@testing-library/react';
 import { h } from 'react-hyperscript-helpers';
 import { Ajax } from 'src/libs/ajax';
 import { SamUserTermsOfServiceDetails } from 'src/libs/ajax/TermsOfService';
-import { SamUserAllowances, SamUserResponse } from 'src/libs/ajax/User';
+import { SamUserAttributes, SamUserCombinedStateResponse } from 'src/libs/ajax/User';
 import { AuthState, authStore } from 'src/libs/state';
 import { TermsOfServicePage } from 'src/registration/terms-of-service/TermsOfServicePage';
 import { asMockedFn, renderWithAppContexts as render } from 'src/testing/test-utils';
@@ -71,6 +71,13 @@ const setupMockAjax = async (
     registeredAt: new Date('1970-01-01'),
     updatedAt: new Date('1970-01-01'),
   };
+  const mockSamUserCombinedState: SamUserCombinedStateResponse = {
+    samUser: mockSamUserResponse,
+    terraUserAllowances,
+    terraUserAttributes: { marketingConsent: false } as SamUserAttributes,
+    termsOfService,
+    enterpriseFeatures: [],
+  };
   const getTermsOfServiceText = jest.fn().mockResolvedValue('some text');
   const getUserTermsOfServiceDetails = jest
     .fn()
@@ -89,10 +96,7 @@ const setupMockAjax = async (
           captureEvent: jest.fn(),
         },
         User: {
-          getUserAttributes: jest.fn().mockResolvedValue({ marketingConsent: true }),
-          getUserAllowances: jest.fn().mockResolvedValue(terraUserAllowances),
-          getEnterpriseFeatures: jest.fn().mockResolvedValue([]),
-          getSamUserResponse: jest.fn().mockResolvedValue(mockSamUserResponse),
+          getSamUserCombinedState: mockSamUserCombinedState,
           profile: {
             get: jest.fn().mockResolvedValue({ keyValuePairs: [] }),
             update: jest.fn().mockResolvedValue({ keyValuePairs: [] }),
