[TSPS-601] Imputation sidebar updates (#5407)

Author: MatthewBemis

src/components/TopBar.test.ts

@@ -48,8 +48,7 @@ describe('TopBar', () => {
     }
   });
 
-  it('renders limited options when compactTopBar brand option is enabled', async () => {
-    // scientificServices is a brand config that has compactTopBar enabled
+  it('renders limited options when scientificServices brand option is enabled', async () => {
     configOverridesStore.set({ brand: 'scientificServices' });
 
     authStore.update((authState) => ({ ...authState, signInStatus: 'uninitialized' as SignInStatus }));
@@ -62,5 +61,22 @@ describe('TopBar', () => {
     expect(screen.queryByText('Sign In')).toBeInTheDocument();
     expect(screen.queryByText('Workspaces')).not.toBeInTheDocument();
     expect(screen.queryByText('Support')).not.toBeInTheDocument();
+    expect(screen.queryByText('Service News')).toBeInTheDocument();
+    expect(screen.queryByText('Documentation')).toBeInTheDocument();
+  });
+
+  it('renders full options when scientificServices brand option is disabled', async () => {
+    configOverridesStore.set({ brand: undefined });
+
+    authStore.update((authState) => ({ ...authState, signInStatus: 'uninitialized' as SignInStatus }));
+
+    // Act
+    render(h(TopBar));
+    fireEvent.click(screen.getByLabelText('Toggle main menu'));
+
+    // Assert
+    expect(screen.queryByText('Sign In')).toBeInTheDocument();
+    expect(screen.queryByText('Workspaces')).toBeInTheDocument();
+    expect(screen.queryByText('Support')).toBeInTheDocument();
   });
 });

src/components/TopBar.tsx

@@ -12,7 +12,6 @@ import { Clickable, Link } from 'src/components/common';
 import { SkipNavLink, SkipNavTarget } from 'src/components/skipNavLink';
 import headerRightHexes from 'src/images/brands/terra/header-right-hexes.svg';
 import {
-  getEnabledBrand,
   isBaseline,
   isBioDataCatalyst,
   isDatastage,
@@ -154,8 +153,6 @@ export const TopBar = (props: TopBarProps): ReactNode => {
   const authState = useStore(authStore);
   const userState = useStore(userStore);
 
-  const compact = getEnabledBrand().compactTopBar;
-
   const showNav = () => {
     setNavShown(true);
     document.body.classList.add('overlayOpen');
@@ -200,7 +197,7 @@ export const TopBar = (props: TopBarProps): ReactNode => {
                 onClick={() => setOpenUserMenu(!openUserMenu)}
                 isOpened={openUserMenu}
               >
-                {!compact && (
+                {!isScientificServices() && (
                   <>
                     <DropDownSubItem href={Nav.getLink('profile')} onClick={hideNav}>
                       Profile
@@ -252,7 +249,28 @@ export const TopBar = (props: TopBarProps): ReactNode => {
                 </Clickable>
               </div>
             )}
-            {!compact && (
+            {isScientificServices() && (
+              <>
+                <NavSection
+                  href='https://broadscientificservices.zendesk.com/hc/en-us/categories/39899029682331'
+                  onClick={hideNav}
+                  {...Utils.newTabLinkProps}
+                >
+                  <Icon icon='newspaper' size={24} style={navIconStyles} />
+                  Service News
+                </NavSection>
+                <NavSection
+                  href='https://broadscientificservices.zendesk.com/hc/en-us'
+                  onClick={hideNav}
+                  {...Utils.newTabLinkProps}
+                >
+                  <Icon icon='help' size={24} style={navIconStyles} />
+                  Documentation
+                </NavSection>
+              </>
+            )}
+
+            {!isScientificServices() && (
               <>
                 <NavSection href={Nav.getLink('workspaces')} onClick={hideNav}>
                   <Icon icon='view-cards' size={24} style={navIconStyles} />

src/libs/brands.tsx

@@ -108,9 +108,6 @@ export interface BrandConfiguration {
     /** Card body */
     body: string;
   };
-
-  /** Optional flag to use the compact TopBar with login/logout only */
-  compactTopBar?: boolean;
 }
 
 export const landingPageCardsDefault = [
@@ -406,7 +403,6 @@ export const brands: Record<string, BrandConfiguration> = {
     welcomeHeader: <ScientificServicesWelcomeHeader />,
     description: <ScientificServicesDescription />,
     hostName: 'services.terra.bio',
-    compactTopBar: true,
     docLinks: [],
     landingPageCards: [],
     logos: {