Merge pull request #14 from DataChefHQ/bugfix/monthly-limit-range-validation

fix: monthly limit range validation

Author: kkiani

src/application-cost-monitoring.ts

@@ -43,6 +43,13 @@ export class ApplicationCostMonitoring extends IBudgetStrategy {
    */
   constructor(stack: Stack, props: IApplicationCostMonitoringProps) {
     super(stack, props);
+
+    if (props.monthlyLimitInDollars < 30) {
+      throw RangeError(
+        "monthlyLimitInDollars must be greater than equal to 30."
+      );
+    }
+
     this.applicationName = props.applicationName;
     this.otherStacks = props.otherStacksIncludedInBudget ?? [];
   }

test/application-cost-monitoring.test.ts

@@ -25,6 +25,20 @@ describe("An ApplicationCostMonitoring", () => {
     subject = Template.fromStack(mockAppFirstStack);
   });
 
+  it("should throw range error if the monthly budget is less than $30", () => {
+    const mockApp = new App();
+    const mockAppFirstStack = new Stack(mockApp, "mocked-first-stack", {});
+
+    expect(() => {
+      new ApplicationCostMonitoring(mockAppFirstStack, {
+        applicationName: "mock-application",
+        monthlyLimitInDollars: 29,
+        defaultTopic: "mocked-topic",
+        subscribers: ["[email protected]"],
+      });
+    }).toThrow(RangeError);
+  });
+
   it("should creates multiple aws budgets", () => {
     subject.resourceCountIs(AWSResourceType.Budget, 6);
   });