🚨 Migrate new spec files from main to Vitest after rebase

Author: mormubis

.gitlab-ci.yml

@@ -282,14 +282,18 @@ unit-bs:
   extends:
     - .base-configuration
     - .bs-allowed-branches
+    - .resource-allocation-4-cpus
   interruptible: true
   resource_group: browserstack
+  timeout: 35 minutes
   artifacts:
+    when: always
     reports:
       junit: test-report/unit-bs/*.xml
   script:
     - yarn
-    - node scripts/test/ci-bs.ts test:unit
+    - yarn playwright install --with-deps
+    - FORCE_COLOR=1 node scripts/test/ci-bs.ts test:unit
   after_script:
     - node ./scripts/test/export-test-result.ts unit-bs
 

developer-extension/package.json

@@ -11,7 +11,8 @@
     "@types/react": "19.2.14",
     "@types/react-dom": "19.2.3",
     "@wxt-dev/module-react": "1.2.2",
-    "typescript": "6.0.2"
+    "typescript": "6.0.2",
+    "vite": "8.0.8"
   },
   "dependencies": {
     "@datadog/browser-core": "workspace:*",

packages/core/src/domain/contexts/tabContext.spec.ts

@@ -1,3 +1,4 @@
+import { describe, it, expect, vi, beforeEach } from 'vitest'
 import type { Hooks } from '../../../test'
 import { createHooks, registerCleanupTask } from '../../../test'
 import { HookNames } from '../../tools/abstractHooks'
@@ -26,9 +27,9 @@ describe('tabContext', () => {
     })
 
     expect(event).toEqual(
-      jasmine.objectContaining({
-        tab: jasmine.objectContaining({
-          id: jasmine.stringMatching(UUID_PATTERN),
+      expect.objectContaining({
+        tab: expect.objectContaining({
+          id: expect.stringMatching(UUID_PATTERN),
         }),
       })
     )
@@ -69,7 +70,9 @@ describe('tabContext', () => {
   })
 
   it('should generate a tab ID when sessionStorage.getItem throws', () => {
-    spyOn(sessionStorage, 'getItem').and.throwError('SecurityError')
+    vi.spyOn(sessionStorage, 'getItem').mockImplementation(() => {
+      throw new Error('SecurityError')
+    })
     startTabContext(hooks)
 
     const event = hooks.triggerHook(HookNames.Assemble, {
@@ -80,8 +83,10 @@ describe('tabContext', () => {
   })
 
   it('should generate a tab ID when sessionStorage.setItem throws', () => {
-    spyOn(sessionStorage, 'getItem').and.returnValue(null)
-    spyOn(sessionStorage, 'setItem').and.throwError('QuotaExceededError')
+    vi.spyOn(sessionStorage, 'getItem').mockReturnValue(null)
+    vi.spyOn(sessionStorage, 'setItem').mockImplementation(() => {
+      throw new Error('QuotaExceededError')
+    })
     startTabContext(hooks)
 
     const event = hooks.triggerHook(HookNames.Assemble, {
@@ -92,7 +97,9 @@ describe('tabContext', () => {
   })
 
   it('should return the same tab ID across multiple startTabContext calls when sessionStorage is unavailable', () => {
-    spyOn(sessionStorage, 'getItem').and.throwError('SecurityError')
+    vi.spyOn(sessionStorage, 'getItem').mockImplementation(() => {
+      throw new Error('SecurityError')
+    })
 
     const hooks1 = createHooks()
     startTabContext(hooks1)

packages/core/src/domain/session/storeStrategies/sessionInCookie.spec.ts

@@ -1,4 +1,4 @@
-import { vi, describe, expect, it } from 'vitest'
+import { vi, beforeEach, describe, expect, it } from 'vitest'
 import { mockClock, getSessionState, registerCleanupTask } from '../../../../test'
 import { setCookie, deleteCookie, getCookie } from '../../../browser/cookie'
 import type { SessionState } from '../sessionState'
@@ -8,6 +8,13 @@ import { SESSION_COOKIE_EXPIRATION_DELAY, SESSION_EXPIRATION_DELAY, SESSION_TIME
 import { buildCookieOptions, selectCookieStrategy, initCookieStrategy } from './sessionInCookie'
 import { SESSION_STORE_KEY } from './sessionStoreStrategy'
 
+// Safari on BrowserStack cannot access cookies because vitest runs tests in an iframe
+// and BrowserStack replaces localhost with bs-local.com, triggering Safari's ITP restrictions.
+// https://www.browserstack.com/support/faq/local-testing/local-exceptions/i-face-issues-while-testing-localhost-urls-or-private-servers-in-safari-on-macos-os-x-and-ios
+beforeEach((ctx) => {
+  ctx.skip(navigator.userAgent.includes('Safari') && !navigator.userAgent.includes('Chrome'), 'Safari on BrowserStack')
+})
+
 const DEFAULT_INIT_CONFIGURATION = { clientToken: 'abc', trackAnonymousUser: true }
 
 function setupCookieStrategy(partialInitConfiguration: Partial<InitConfiguration> = {}) {

packages/core/src/tools/valueHistory.spec.ts

@@ -129,33 +129,33 @@ describe('valueHistory', () => {
           value: 'foo',
           startTime: 0 as RelativeTime,
           endTime: END_OF_TIMES,
-          remove: jasmine.any(Function),
-          close: jasmine.any(Function),
+          remove: expect.any(Function),
+          close: expect.any(Function),
         },
       ])
       expect(valueHistory.getEntries(5 as RelativeTime)).toEqual([
         {
           value: 'qux',
           startTime: 5 as RelativeTime,
           endTime: 15 as RelativeTime,
-          remove: jasmine.any(Function),
-          close: jasmine.any(Function),
+          remove: expect.any(Function),
+          close: expect.any(Function),
         },
         {
           value: 'bar',
           startTime: 5 as RelativeTime,
           endTime: 10 as RelativeTime,
-          remove: jasmine.any(Function),
-          close: jasmine.any(Function),
+          remove: expect.any(Function),
+          close: expect.any(Function),
         },
       ])
       expect(valueHistory.getEntries(10 as RelativeTime)).toEqual([
         {
           value: 'baz',
           startTime: 10 as RelativeTime,
           endTime: END_OF_TIMES,
-          remove: jasmine.any(Function),
-          close: jasmine.any(Function),
+          remove: expect.any(Function),
+          close: expect.any(Function),
         },
       ])
     })

packages/core/src/transport/flushController.spec.ts

@@ -112,7 +112,7 @@ describe('flushController', () => {
 
       pageMayExitObservable.notify({ reason: 'before_unload' })
 
-      expect(flushSpy.calls.first().args[0].reason).toBe('before_unload')
+      expect(flushSpy.mock.calls[0][0].reason).toBe('before_unload')
     })
 
     it('notifies when the bytes limit is reached after adding a message', () => {

packages/core/test/forEach.spec.ts

@@ -1,3 +1,4 @@
+import { beforeEach, afterEach } from 'vitest'
 import { resetManageResourceTimingBufferFull } from '../../rum-core/src/browser/performanceObservable'
 import { resetExperimentalFeatures } from '../src/tools/experimentalFeatures'
 import { resetValueHistoryGlobals } from '../src/tools/valueHistory'

packages/logs/src/boot/startLogs.spec.ts

@@ -48,6 +48,13 @@ declare global {
   }
 }
 
+// Safari on BrowserStack cannot access cookies because vitest runs tests in an iframe
+// and BrowserStack replaces localhost with bs-local.com, triggering Safari's ITP restrictions.
+// https://www.browserstack.com/support/faq/local-testing/local-exceptions/i-face-issues-while-testing-localhost-urls-or-private-servers-in-safari-on-macos-os-x-and-ios
+beforeEach((ctx) => {
+  ctx.skip(navigator.userAgent.includes('Safari') && !navigator.userAgent.includes('Chrome'), 'Safari on BrowserStack')
+})
+
 const DEFAULT_MESSAGE = { status: StatusType.info, message: 'message' }
 const COMMON_CONTEXT = {
   view: { referrer: 'common_referrer', url: 'common_url' },
@@ -130,7 +137,7 @@ describe('logs', () => {
           anonymous_id: expect.any(String),
         },
         tab: {
-          id: jasmine.any(String),
+          id: expect.any(String),
         },
       })
     })

packages/rum-angular/src/domain/angularPlugin.spec.ts

@@ -1,3 +1,4 @@
+import { describe, it, expect, vi, beforeEach } from 'vitest'
 import type { RumInitConfiguration, RumPublicApi } from '@datadog/browser-rum-core'
 import { registerCleanupTask } from '../../../core/test'
 import { angularPlugin, onRumInit, onRumStart, resetAngularPlugin } from './angularPlugin'
@@ -15,16 +16,16 @@ describe('angularPlugin', () => {
   it('returns a plugin object', () => {
     const plugin = angularPlugin()
     expect(plugin).toEqual(
-      jasmine.objectContaining({
+      expect.objectContaining({
         name: 'angular',
-        onInit: jasmine.any(Function),
-        onRumStart: jasmine.any(Function),
+        onInit: expect.any(Function),
+        onRumStart: expect.any(Function),
       })
     )
   })
 
   it('calls callbacks registered with onRumInit during onInit', () => {
-    const callbackSpy = jasmine.createSpy()
+    const callbackSpy = vi.fn()
     const pluginConfiguration = {}
     onRumInit(callbackSpy)
 
@@ -36,12 +37,12 @@ describe('angularPlugin', () => {
     })
 
     expect(callbackSpy).toHaveBeenCalledTimes(1)
-    expect(callbackSpy.calls.mostRecent().args[0]).toBe(pluginConfiguration)
-    expect(callbackSpy.calls.mostRecent().args[1]).toBe(PUBLIC_API)
+    expect(callbackSpy.mock.lastCall![0]).toBe(pluginConfiguration)
+    expect(callbackSpy.mock.lastCall![1]).toBe(PUBLIC_API)
   })
 
   it('calls callbacks immediately if onInit was already invoked', () => {
-    const callbackSpy = jasmine.createSpy()
+    const callbackSpy = vi.fn()
     const pluginConfiguration = {}
     angularPlugin(pluginConfiguration).onInit!({
       publicApi: PUBLIC_API,
@@ -51,8 +52,8 @@ describe('angularPlugin', () => {
     onRumInit(callbackSpy)
 
     expect(callbackSpy).toHaveBeenCalledTimes(1)
-    expect(callbackSpy.calls.mostRecent().args[0]).toBe(pluginConfiguration)
-    expect(callbackSpy.calls.mostRecent().args[1]).toBe(PUBLIC_API)
+    expect(callbackSpy.mock.lastCall![0]).toBe(pluginConfiguration)
+    expect(callbackSpy.mock.lastCall![1]).toBe(PUBLIC_API)
   })
 
   it('enforce manual view tracking when router is enabled', () => {
@@ -77,8 +78,8 @@ describe('angularPlugin', () => {
   })
 
   it('calls onRumStart subscribers during onRumStart', () => {
-    const callbackSpy = jasmine.createSpy()
-    const addErrorSpy = jasmine.createSpy()
+    const callbackSpy = vi.fn()
+    const addErrorSpy = vi.fn()
     onRumStart(callbackSpy)
 
     angularPlugin().onRumStart!({ addError: addErrorSpy })
@@ -87,10 +88,10 @@ describe('angularPlugin', () => {
   })
 
   it('calls onRumStart subscribers immediately if already started', () => {
-    const addErrorSpy = jasmine.createSpy()
+    const addErrorSpy = vi.fn()
     angularPlugin().onRumStart!({ addError: addErrorSpy })
 
-    const callbackSpy = jasmine.createSpy()
+    const callbackSpy = vi.fn()
     onRumStart(callbackSpy)
 
     expect(callbackSpy).toHaveBeenCalledWith(addErrorSpy)

packages/rum-angular/src/domain/angularRouter/startAngularView.spec.ts

@@ -1,3 +1,4 @@
+import { describe, it, expect } from 'vitest'
 import { computeViewName } from './startAngularView'
 import type { RouteSnapshot } from './types'