♻️ move hook and merge utilities from browser-core to @datadog/js-core (#4797)

Author: BenoitZugmeyer

eslint-local-rules/disallowSideEffects.ts

@@ -45,6 +45,7 @@ const pathsWithSideEffect = new Set([
 
 // Those packages are known to have no side effects when evaluated
 const packagesWithoutSideEffect = new Set([
+  '@datadog/js-core/assembly',
   '@datadog/js-core/time',
   '@datadog/js-core/util',
   '@datadog/js-core/monitor',

packages/browser-core/src/domain/context/contextManager.ts

@@ -1,4 +1,4 @@
-import { deepClone } from '../../tools/mergeInto'
+import { deepClone } from '@datadog/js-core/util'
 import { sanitize } from '../../tools/serialisation/sanitize'
 import type { Context } from '../../tools/serialisation/context'
 import { Observable } from '../../tools/observable'

packages/browser-core/src/domain/context/contextUtils.ts

@@ -1,6 +1,6 @@
+import { getType } from '@datadog/js-core/util'
 import type { Context } from '../../tools/serialisation/context'
 import { display } from '../../tools/display'
-import { getType } from '../../tools/utils/typeUtils'
 
 /**
  * Simple check to ensure an object is a valid context

packages/browser-core/src/domain/context/storeContextManager.ts

@@ -1,6 +1,6 @@
+import { combine } from '@datadog/js-core/util'
 import { addEventListener, DOM_EVENT } from '../../browser/addEventListener'
 import type { Context } from '../../tools/serialisation/context'
-import { combine } from '../../tools/mergeInto'
 import { isEmptyObject } from '../../tools/utils/objectUtils'
 import type { ContextManager } from './contextManager'
 import type { CustomerDataType } from './contextConstants'

packages/browser-core/src/domain/contexts/accountContext.spec.ts

@@ -1,11 +1,11 @@
 import type { RelativeTime } from '@datadog/js-core/time'
+import type { Hook } from '@datadog/js-core/assembly'
+import { createHook } from '@datadog/js-core/assembly'
 import { registerCleanupTask } from '../../../test'
 import { mockRumConfiguration } from '../../../../browser-rum-core/test'
 import type { ContextManager } from '../context/contextManager'
 import { display } from '../../tools/display'
 import { removeStorageListeners } from '../context/storeContextManager'
-import type { Hook } from '../../tools/abstractHooks'
-import { createHook } from '../../tools/abstractHooks'
 import { startAccountContext } from './accountContext'
 
 describe('account context', () => {

packages/browser-core/src/domain/contexts/accountContext.ts

@@ -1,8 +1,8 @@
+import type { Hook } from '@datadog/js-core/assembly'
+import { SKIPPED } from '@datadog/js-core/assembly'
 import type { Configuration } from '../configuration'
 import { CustomerDataType } from '../context/contextConstants'
 import { storeContextManager } from '../context/storeContextManager'
-import type { Hook } from '../../tools/abstractHooks'
-import { SKIPPED } from '../../tools/abstractHooks'
 import { isEmptyObject } from '../../tools/utils/objectUtils'
 import { createContextManager } from '../context/contextManager'
 

packages/browser-core/src/domain/contexts/globalContext.spec.ts

@@ -1,11 +1,11 @@
 import type { RelativeTime } from '@datadog/js-core/time'
+import type { Hook } from '@datadog/js-core/assembly'
+import { createHook } from '@datadog/js-core/assembly'
 import { registerCleanupTask } from '../../../test'
 import type { LogsConfiguration } from '../../../../browser-logs/src/domain/configuration'
 import type { ContextManager } from '../context/contextManager'
 import { removeStorageListeners } from '../context/storeContextManager'
 import type { Configuration } from '../configuration'
-import type { Hook } from '../../tools/abstractHooks'
-import { createHook } from '../../tools/abstractHooks'
 import { startGlobalContext } from './globalContext'
 
 describe('logs global context', () => {

packages/browser-core/src/domain/contexts/globalContext.ts

@@ -1,4 +1,4 @@
-import type { Hook } from '../../tools/abstractHooks'
+import type { Hook } from '@datadog/js-core/assembly'
 import { CustomerDataType } from '../context/contextConstants'
 import { storeContextManager } from '../context/storeContextManager'
 import { createContextManager } from '../context/contextManager'

packages/browser-core/src/domain/contexts/tabContext.spec.ts

@@ -1,7 +1,7 @@
 import type { RelativeTime } from '@datadog/js-core/time'
+import type { Hook } from '@datadog/js-core/assembly'
+import { createHook } from '@datadog/js-core/assembly'
 import { registerCleanupTask } from '../../../test'
-import type { Hook } from '../../tools/abstractHooks'
-import { createHook } from '../../tools/abstractHooks'
 import { TAB_ID_STORAGE_KEY, resetCachedTabId, startTabContext } from './tabContext'
 
 const UUID_PATTERN = /^[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12}$/

packages/browser-core/src/domain/contexts/tabContext.ts

@@ -1,4 +1,4 @@
-import type { Hook } from '../../tools/abstractHooks'
+import type { Hook } from '@datadog/js-core/assembly'
 import { generateUUID } from '../../tools/utils/stringUtils'
 
 export const TAB_ID_STORAGE_KEY = '_dd_tab_id'