add tests

Author: thomas-lebeau

packages/rum-core/src/domain/view/viewCollection.spec.ts

@@ -115,6 +115,10 @@ describe('viewCollection', () => {
       _dd: {
         document_version: 3,
         replay_stats: undefined,
+        loading_time: {
+          was_hidden_during_loading: undefined,
+          duration: 20,
+        },
         configuration: {
           start_session_replay_recording_manually: jasmine.any(Boolean),
         },
@@ -201,7 +205,7 @@ describe('viewCollection', () => {
         },
       },
       privacy: { replay_level: 'mask' },
-    })
+    } as unknown as RawRumViewEvent) // TODO fixme after updating rum-event-format
   })
 
   it('should discard negative loading time', () => {

packages/rum-core/src/domain/view/viewMetrics/trackLoadingTime.spec.ts

@@ -22,7 +22,7 @@ describe('trackLoadingTime', () => {
   let clock: Clock
   let domMutationObservable: Observable<void>
   let windowOpenObservable: Observable<void>
-  let loadingTimeCallback: jasmine.Spy<(loadingTime: Duration) => void>
+  let loadingTimeCallback: jasmine.Spy<(loadingTime: Duration | undefined, wasHiddenDuringLoading: boolean) => void>
   let setLoadEvent: (loadEvent: Duration) => void
   let stopLoadingTimeTracking: () => void
 
@@ -44,7 +44,7 @@ describe('trackLoadingTime', () => {
     clock = mockClock()
     domMutationObservable = new Observable()
     windowOpenObservable = new Observable()
-    loadingTimeCallback = jasmine.createSpy<(loadingTime: Duration) => void>()
+    loadingTimeCallback = jasmine.createSpy()
   })
 
   afterEach(() => {
@@ -65,7 +65,7 @@ describe('trackLoadingTime', () => {
     domMutationObservable.notify()
     clock.tick(AFTER_PAGE_ACTIVITY_END_DELAY)
 
-    expect(loadingTimeCallback).toHaveBeenCalledOnceWith(clock.relative(BEFORE_PAGE_ACTIVITY_VALIDATION_DELAY))
+    expect(loadingTimeCallback).toHaveBeenCalledOnceWith(clock.relative(BEFORE_PAGE_ACTIVITY_VALIDATION_DELAY), false)
   })
 
   it('should use loadEventEnd for initial view when having no activity', () => {
@@ -77,7 +77,7 @@ describe('trackLoadingTime', () => {
     setLoadEvent(entry.loadEventEnd)
     clock.tick(PAGE_ACTIVITY_END_DELAY)
 
-    expect(loadingTimeCallback).toHaveBeenCalledOnceWith(entry.loadEventEnd)
+    expect(loadingTimeCallback).toHaveBeenCalledOnceWith(entry.loadEventEnd, false)
   })
 
   it('should use loadEventEnd for initial view when load event is bigger than computed loading time', () => {
@@ -90,7 +90,7 @@ describe('trackLoadingTime', () => {
     domMutationObservable.notify()
     clock.tick(AFTER_PAGE_ACTIVITY_END_DELAY)
 
-    expect(loadingTimeCallback).toHaveBeenCalledOnceWith(clock.relative(LOAD_EVENT_AFTER_ACTIVITY_TIMING))
+    expect(loadingTimeCallback).toHaveBeenCalledOnceWith(clock.relative(LOAD_EVENT_AFTER_ACTIVITY_TIMING), false)
   })
 
   it('should use computed loading time for initial view when load event is smaller than computed loading time', () => {
@@ -104,7 +104,7 @@ describe('trackLoadingTime', () => {
     domMutationObservable.notify()
     clock.tick(AFTER_PAGE_ACTIVITY_END_DELAY)
 
-    expect(loadingTimeCallback).toHaveBeenCalledOnceWith(clock.relative(BEFORE_PAGE_ACTIVITY_VALIDATION_DELAY))
+    expect(loadingTimeCallback).toHaveBeenCalledOnceWith(clock.relative(BEFORE_PAGE_ACTIVITY_VALIDATION_DELAY), false)
   })
 
   it('should use computed loading time from time origin for initial view', () => {
@@ -127,14 +127,19 @@ describe('trackLoadingTime', () => {
     clock.tick(AFTER_PAGE_ACTIVITY_END_DELAY)
 
     expect(loadingTimeCallback).toHaveBeenCalledOnceWith(
-      clock.relative(BEFORE_PAGE_ACTIVITY_VALIDATION_DELAY + CLOCK_GAP)
+      clock.relative(BEFORE_PAGE_ACTIVITY_VALIDATION_DELAY + CLOCK_GAP),
+      false
     )
   })
 
   it('should discard loading time if page is hidden before activity', () => {
     setPageVisibility('hidden')
     startLoadingTimeTracking()
 
-    expect(loadingTimeCallback).not.toHaveBeenCalled()
+    clock.tick(BEFORE_PAGE_ACTIVITY_VALIDATION_DELAY)
+    domMutationObservable.notify()
+    clock.tick(AFTER_PAGE_ACTIVITY_END_DELAY)
+
+    expect(loadingTimeCallback).toHaveBeenCalledOnceWith(undefined, true)
   })
 })

packages/rum-core/src/domain/view/viewMetrics/trackLoadingTime.ts

@@ -13,7 +13,7 @@ export function trackLoadingTime(
   configuration: RumConfiguration,
   loadType: ViewLoadingType,
   viewStart: ClocksState,
-  callback: (loadingTime: Duration, wasHiddenDuringLoading: boolean) => void
+  callback: (loadingTime: Duration | undefined, wasHiddenDuringLoading: boolean) => void
 ) {
   let isWaitingForLoadEvent = loadType === ViewLoadingType.INITIAL_LOAD
   let isWaitingForActivityLoadingTime = true
@@ -23,7 +23,11 @@ export function trackLoadingTime(
   function invokeCallbackIfAllCandidatesAreReceived() {
     if (!isWaitingForActivityLoadingTime && !isWaitingForLoadEvent && loadingTimeCandidates.length > 0) {
       const loadingTime = Math.max(...loadingTimeCandidates)
-      callback(loadingTime as Duration, loadingTime < firstHidden.timeStamp)
+      if (loadingTime < firstHidden.timeStamp) {
+        callback(loadingTime as Duration, false)
+      } else {
+        callback(undefined, true)
+      }
     }
   }