🐛 Fix typecheck errors after rebase onto main

- eventRow.tsx: remove duplicate view_update key in RUM_EVENT_TYPE_COLOR
- trackCommonViewMetrics/trackViews/rumPublicApi: make setLoadingTime return
  {no_view, no_active_view, overwritten} so addTelemetryUsage gets the fields
  now required by the AddViewLoadingTime telemetry schema (landed in main via
  rum-events-format #352)

Author: mormubis

developer-extension/src/panel/components/tabs/eventsTab/eventRow.tsx

@@ -37,7 +37,6 @@ const RUM_EVENT_TYPE_COLOR = {
   telemetry: 'teal',
   vital: 'orange',
   transition: 'green',
-  view_update: 'blue',
 }
 
 const LOG_STATUS_COLOR = {

packages/rum-core/src/boot/rumPublicApi.spec.ts

@@ -24,7 +24,7 @@ const noopStartRum = (): ReturnType<StartRum> => ({
   addError: () => undefined,
   addEvent: () => undefined,
   addTiming: () => undefined,
-  setLoadingTime: () => undefined,
+  setLoadingTime: () => ({ no_view: false, no_active_view: false, overwritten: false }),
   addFeatureFlagEvaluation: () => undefined,
   startView: () => undefined,
   setViewContext: () => undefined,

packages/rum-core/src/boot/rumPublicApi.ts

@@ -787,9 +787,12 @@ export function makeRumPublicApi(
 
     setViewLoadingTime: monitor(() => {
       const callTimestamp = timeStampNow()
-      strategy.setLoadingTime(callTimestamp)
+      const { no_view, no_active_view, overwritten } = strategy.setLoadingTime(callTimestamp)
       addTelemetryUsage({
         feature: 'addViewLoadingTime',
+        no_view,
+        no_active_view,
+        overwritten,
       })
     }),
 

packages/rum-core/src/domain/view/trackViews.ts

@@ -179,7 +179,13 @@ export function trackViews(
     addTiming: (name: string, time: RelativeTime | TimeStamp = timeStampNow()) => {
       currentView.addTiming(name, time)
     },
-    setLoadingTime: (callTimestamp?: TimeStamp) => currentView.setLoadingTime(callTimestamp),
+    setLoadingTime: (callTimestamp?: TimeStamp) => {
+      if (!currentView) {
+        return { no_view: true, no_active_view: false, overwritten: false }
+      }
+      const result = currentView.setLoadingTime(callTimestamp)
+      return { no_view: false, ...result }
+    },
     startView: (options?: ViewOptions, startClocks?: ClocksState) => {
       currentView.end({ endClocks: startClocks })
       currentView = startNewView(ViewLoadingType.ROUTE_CHANGE, startClocks, options)

packages/rum-core/src/domain/view/viewMetrics/trackCommonViewMetrics.ts

@@ -84,15 +84,17 @@ export function trackCommonViewMetrics(
     },
     setLoadingTime: (callTimestamp?: TimeStamp) => {
       if (viewEnded) {
-        return
+        return { no_active_view: true, overwritten: hasManualLoadingTime }
       }
       const loadingTime = elapsed(viewStart.timeStamp, callTimestamp ?? timeStampNow())
       if (!hasManualLoadingTime) {
         stopLoadingTimeTracking()
       }
+      const overwritten = hasManualLoadingTime
       hasManualLoadingTime = true
       commonViewMetrics.loadingTime = loadingTime
       scheduleViewUpdate()
+      return { no_active_view: false, overwritten }
     },
   }
 }