🐛 Fix bs-wrapper masking test failures, skip CookieStore tests

bs-wrapper.ts: ANSI escape codes from FORCE_COLOR broke failure
detection — the regex /\d+ failed \|/ didn't match colored output
like '9 failed\x1b[39m |'. Strip ANSI before matching.

cookieAccess.spec.ts: CookieStore API tests crashed with TypeError
when globalObject.cookieStore was undefined (Jasmine's pending()
inside setup() skipped the enclosing it(), but Vitest doesn't).
Added beforeEach ctx.skip for the CookieStore describe block.

Author: mormubis

packages/browser-core/src/browser/cookieAccess.spec.ts

@@ -1,4 +1,4 @@
-import { vi, describe, expect, it, type Mock } from 'vitest'
+import { vi, beforeEach, describe, expect, it, type Mock } from 'vitest'
 import { ONE_MINUTE, dateNow } from '@datadog/js-core/time'
 import { globalObject } from '@datadog/js-core/util'
 import type { Clock } from '../../test'
@@ -114,6 +114,14 @@ describe('cookieAccess', () => {
 
   for (const { title, setup } of setups) {
     describe(title, () => {
+      beforeEach((ctx) => {
+        // Skip CookieStore API tests when the API is not available
+        // (Jasmine's pending() inside setup() threw and skipped the enclosing it())
+        if (title === 'CookieStore API' && !globalObject.cookieStore) {
+          ctx.skip(true, 'CookieStore API not available')
+        }
+      })
+
       describe('getAllAndSet', () => {
         it('should pass current cookie values to callback', async () => {
           const { createCookieAccess, setCookieWithCleanup } = setup()
@@ -154,8 +162,11 @@ describe('cookieAccess', () => {
 
         it('should pass all cookie values to callback', async (ctx) => {
           const browserVersion = detectVersion()
-          if (!isChromium() || (browserVersion !== undefined && browserVersion < 145)) {
-            ctx.skip(true, 'Only Recent Chromium supports multiple cookies with the same name with different options')
+          if (!isChromium() || browserVersion === undefined || browserVersion < 145) {
+            ctx.skip(true, 'Only recent Chromium (>=145) supports multiple cookies with the same name')
+          }
+          if (location.protocol !== 'https:') {
+            ctx.skip(true, 'Partitioned cookies require a secure (HTTPS) context')
           }
 
           const { createCookieAccess, setCookieWithCleanup } = setup()

scripts/test/bs-wrapper.ts

@@ -113,7 +113,7 @@ function runTests(): Promise<boolean> {
     let output = ''
     let timeoutId: NodeJS.Timeout
     let testsCompleted = false
-    let hasFailures = false
+    let killedByWrapper = false
 
     child.stdout!.pipe(process.stdout)
     child.stdout!.on('data', onOutput)
@@ -122,10 +122,12 @@ function runTests(): Promise<boolean> {
     child.stderr!.on('data', onOutput)
 
     child.on('exit', (code, signal) => {
-      if (testsCompleted && !hasFailures) {
-        // Vitest hung after completion (vitest#10151) — treat as success
-        resolve(true)
+      if (killedByWrapper && testsCompleted) {
+        // Vitest hung during teardown (vitest#10151) and we killed it.
+        // No exit code to trust — check the output for failures.
+        resolve(!hasTestFailures(output))
       } else {
+        // Vitest exited on its own — trust its exit code.
         resolve(!signal && code === 0)
       }
     })
@@ -139,12 +141,6 @@ function runTests(): Promise<boolean> {
         return
       }
 
-      // Match Vitest's failure summary line (e.g. "Test Files  2 failed | 40 passed")
-      // but not test console output like "3 failed retries" or "Session Replay failed to start"
-      if (/\d+ failed \|/.test(chunk)) {
-        hasFailures = true
-      }
-
       clearTimeout(timeoutId)
 
       if (hasUnrecoverableFailure(output)) {
@@ -160,11 +156,20 @@ function runTests(): Promise<boolean> {
 
     function killIt(message: string): void {
       printError(`Killing the browserstack job because of ${message}`)
+      killedByWrapper = true
       child.kill('SIGKILL')
     }
   })
 }
 
+function hasTestFailures(output: string): boolean {
+  // Strip ANSI escape codes — FORCE_COLOR inserts sequences between "failed" and "|"
+  // eslint-disable-next-line no-control-regex
+  const plain = output.replace(/\x1b\[[0-9;]*m/g, '')
+  // Match Vitest's summary line: "Test Files  2 failed | 40 passed (42)"
+  return /\d+ failed \|/.test(plain)
+}
+
 function hasUnrecoverableFailure(stdout: string): boolean {
   return stdout.includes('is set to true but local testing through BrowserStack is not connected.')
 }