🐛 fix BrowserStack failures on Firefox 78 and Android Chrome

- trackRuntimeError.spec: `stop()` resolved to `window.stop()`, which made
  Firefox 78 reload the Vitest test iframe. Unsubscribe from the observable
  instead.
- polyfill AggregateError (Firefox < 79), used by Vitest to report errors
- only serve from bs-local.com on Safari: other browsers need `localhost`
  (a secure context) for `secure` cookies (cookieAccess.spec on Android)

Author: thomas-lebeau

packages/browser-core/src/domain/error/trackRuntimeError.spec.ts

@@ -1,4 +1,5 @@
 import { disableJasmineUncaughtExceptionTracking, wait } from '../../../test'
+import type { Subscription } from '../../tools/observable'
 import type { UnhandledErrorCallback } from './trackRuntimeError'
 import { instrumentOnError, instrumentUnhandledRejection, trackRuntimeError } from './trackRuntimeError'
 import type { RawError } from './error.types'
@@ -10,15 +11,16 @@ describe('trackRuntimeError', () => {
     disableJasmineUncaughtExceptionTracking()
 
     const errorObservable = trackRuntimeError()
+    let subscription: Subscription | undefined
     const errorNotification = new Promise<RawError>((resolve) => {
-      errorObservable.subscribe((e: RawError) => resolve(e))
+      subscription = errorObservable.subscribe((e: RawError) => resolve(e))
     })
 
     try {
       await invokeAndWaitForErrorHandlers(callback)
       return await errorNotification
     } finally {
-      stop()
+      subscription?.unsubscribe()
     }
   }
 

test/unit-vitest/vite.bs.config.ts

@@ -128,8 +128,9 @@ const config = mergeConfig(
       browser: {
         headless: false,
         // BrowserStack rewrites localhost to bs-local.com for Safari: serve from that host directly
-        // (it resolves to 127.0.0.1) so the page is reachable and cookies match the page host.
-        api: { host: 'bs-local.com' },
+        // (it resolves to 127.0.0.1) so the page is reachable and cookies match the page host. Other
+        // browsers keep `localhost`, which is a secure context (needed e.g. for `secure` cookies).
+        api: { host: configurations.some(({ name }) => name === 'Safari') ? 'bs-local.com' : 'localhost' },
         orchestratorScripts: [
           { content: ERROR_REPORTER, type: 'text/javascript' },
           { src: POLYFILLS_PATH, type: 'text/javascript' },

test/unit-vitest/vitestBrowserPolyfills.js

@@ -156,4 +156,17 @@
 
     globalThis.BroadcastChannel = BroadcastChannelPolyfill
   }
+
+  // Firefox < 79. Vitest uses it to report multiple errors.
+  if (typeof AggregateError === 'undefined') {
+    class AggregateErrorPolyfill extends Error {
+      constructor(errors, message) {
+        super(message)
+        this.name = 'AggregateError'
+        this.errors = Array.from(errors)
+      }
+    }
+
+    globalThis.AggregateError = AggregateErrorPolyfill
+  }
 })()