🚨 fix lint errors in PR-title check and shared gitmoji module

- gate the script entry point with NODE_TEST_CONTEXT so the local
  disallow-non-scripts rule recognizes the top-level runMain()
- switch ReadonlyArray<T> to readonly T[] (array-type rule)
- single-quote two non-template strings

Author: thomas-lebeau

scripts/check-pr-title.ts

@@ -10,7 +10,7 @@ export function formatAllowedPrefixes(): string {
   return GITMOJI.map(({ emoji, label }) => `  ${emoji} ${label}`).join('\n')
 }
 
-if (import.meta.main) {
+if (!process.env.NODE_TEST_CONTEXT) {
   runMain(() => {
     const title = process.env.PR_TITLE
     if (title === undefined) {
@@ -23,10 +23,10 @@ if (import.meta.main) {
     }
 
     printError(
-      `PR title must start with one of the allowed gitmoji prefixes.\n\n` +
+      'PR title must start with one of the allowed gitmoji prefixes.\n\n' +
         `Current title: ${title}\n\n` +
         `Allowed prefixes:\n${formatAllowedPrefixes()}\n\n` +
-        `See docs/DEVELOPMENT.md for the full convention.`
+        'See docs/DEVELOPMENT.md for the full convention.'
     )
     process.exit(1)
   })

scripts/lib/gitmoji.ts

@@ -9,7 +9,7 @@ export interface Gitmoji {
   category: GitmojiCategory
 }
 
-export const GITMOJI: ReadonlyArray<Gitmoji> = [
+export const GITMOJI: readonly Gitmoji[] = [
   // User-facing changes
   { emoji: '💥', label: 'Breaking change', category: 'public' },
   { emoji: '✨', label: 'New feature', category: 'public' },
@@ -35,9 +35,9 @@ export const GITMOJI: ReadonlyArray<Gitmoji> = [
 const VARIATION_SELECTOR = /️/g
 export const normalizeGitmoji = (value: string): string => value.replace(VARIATION_SELECTOR, '')
 
-export const PUBLIC_EMOJI_PRIORITY: ReadonlyArray<string> = GITMOJI.filter((g) => g.category === 'public').map(
+export const PUBLIC_EMOJI_PRIORITY: readonly string[] = GITMOJI.filter((g) => g.category === 'public').map(
   (g) => g.emoji
 )
-export const INTERNAL_EMOJI_PRIORITY: ReadonlyArray<string> = GITMOJI.filter((g) => g.category === 'internal').map(
+export const INTERNAL_EMOJI_PRIORITY: readonly string[] = GITMOJI.filter((g) => g.category === 'internal').map(
   (g) => g.emoji
 )

scripts/release/generate-changelog/lib/addNewChangesToChangelog.ts

@@ -98,15 +98,15 @@ function getLastReleaseTagName(): string {
   return match[1]
 }
 
-function sortByEmojiPriority(a: string, b: string, priorityList: ReadonlyArray<string>): number {
+function sortByEmojiPriority(a: string, b: string, priorityList: readonly string[]): number {
   const getFirstRelevantEmojiIndex = (text: string): number => {
     const emoji = findFirstEmoji(text)
     return emoji && priorityList.includes(emoji) ? priorityList.indexOf(emoji) : Number.MAX_VALUE
   }
   return getFirstRelevantEmojiIndex(a) - getFirstRelevantEmojiIndex(b)
 }
 
-function formatChangeList(title: string, changes: string[], priority: ReadonlyArray<string>): string {
+function formatChangeList(title: string, changes: string[], priority: readonly string[]): string {
   if (!changes.length) {
     return ''
   }