Skip to content

Commit abcbafe

Browse files
🧹 Cleanup session manager telemetry (#4434)
1 parent 9374bb6 commit abcbafe

2 files changed

Lines changed: 1 addition & 55 deletions

File tree

‎packages/core/src/domain/session/sessionManager.ts‎

Lines changed: 1 addition & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { Observable } from '../../tools/observable'
22
import type { Context } from '../../tools/serialisation/context'
33
import { createValueHistory } from '../../tools/valueHistory'
44
import type { RelativeTime } from '../../tools/utils/timeUtils'
5-
import { clocksOrigin, dateNow, ONE_MINUTE, relativeNow } from '../../tools/utils/timeUtils'
5+
import { clocksOrigin, ONE_MINUTE, relativeNow } from '../../tools/utils/timeUtils'
66
import { addEventListener, addEventListeners, DOM_EVENT } from '../../browser/addEventListener'
77
import { clearInterval, setInterval } from '../../tools/timer'
88
import type { Configuration } from '../configuration'
@@ -11,13 +11,9 @@ import { addTelemetryDebug } from '../telemetry'
1111
import { isSyntheticsTest } from '../synthetics/syntheticsWorkerValues'
1212
import type { CookieStore } from '../../browser/browser.types'
1313
import { getCurrentSite } from '../../browser/cookie'
14-
import { ExperimentalFeature, isExperimentalFeatureEnabled } from '../../tools/experimentalFeatures'
15-
import { findLast } from '../../tools/utils/polyfills'
16-
import { monitorError } from '../../tools/monitor'
1714
import { SESSION_NOT_TRACKED, SESSION_TIME_OUT_DELAY, SessionPersistence } from './sessionConstants'
1815
import { startSessionStore } from './sessionStore'
1916
import type { SessionState } from './sessionState'
20-
import { toSessionState } from './sessionState'
2117
import { retrieveSessionCookie } from './storeStrategies/sessionInCookie'
2218
import { SESSION_STORE_KEY } from './storeStrategies/sessionStoreStrategy'
2319
import { retrieveSessionFromLocalStorage } from './storeStrategies/sessionInLocalStorage'
@@ -81,12 +77,6 @@ export function startSessionManager<TrackingType extends string>(
8177
// manager is started.
8278
sessionStore.expandOrRenewSession()
8379
sessionContextHistory.add(buildSessionContext(), clocksOrigin().relative)
84-
if (isExperimentalFeatureEnabled(ExperimentalFeature.SHORT_SESSION_INVESTIGATION)) {
85-
const session = sessionStore.getSession()
86-
if (session) {
87-
detectSessionIdChange(configuration, session)
88-
}
89-
}
9080

9181
trackingConsentState.observable.subscribe(() => {
9282
if (trackingConsentState.isGranted()) {
@@ -203,49 +193,6 @@ async function reportUnexpectedSessionState(configuration: Configuration) {
203193
})
204194
}
205195

206-
function detectSessionIdChange(configuration: Configuration, initialSessionState: SessionState) {
207-
if (!window.cookieStore || !initialSessionState.created) {
208-
return
209-
}
210-
211-
const sessionCreatedTime = Number(initialSessionState.created)
212-
const sdkInitTime = dateNow()
213-
214-
const { stop } = addEventListener(configuration, cookieStore as CookieStore, DOM_EVENT.CHANGE, listener)
215-
stopCallbacks.push(stop)
216-
217-
function listener(event: CookieChangeEvent) {
218-
const changed = findLast(event.changed, (change): change is CookieListItem => change.name === SESSION_STORE_KEY)
219-
if (!changed) {
220-
return
221-
}
222-
223-
const sessionAge = dateNow() - sessionCreatedTime
224-
if (sessionAge > 14 * ONE_MINUTE) {
225-
// The session might have expired just because it's too old or lack activity
226-
stop()
227-
} else {
228-
const newSessionState = toSessionState(changed.value)
229-
if (newSessionState.id && newSessionState.id !== initialSessionState.id) {
230-
stop()
231-
const time = dateNow() - sdkInitTime
232-
getSessionCookies()
233-
.then((cookie) => {
234-
// monitor-until: 2026-04-01, after RUM-10845 investigation done
235-
addTelemetryDebug('Session cookie changed', {
236-
time,
237-
session_age: sessionAge,
238-
old: initialSessionState,
239-
new: newSessionState,
240-
cookie,
241-
})
242-
})
243-
.catch(monitorError)
244-
}
245-
}
246-
}
247-
}
248-
249196
async function getSessionCookies(): Promise<{ count: number; domain: string }> {
250197
let sessionCookies: string[] | Awaited<ReturnType<CookieStore['getAll']>>
251198
if ('cookieStore' in window) {

‎packages/core/src/tools/experimentalFeatures.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ export enum ExperimentalFeature {
1717
TRACK_INTAKE_REQUESTS = 'track_intake_requests',
1818
USE_TREE_WALKER_FOR_ACTION_NAME = 'use_tree_walker_for_action_name',
1919
FEATURE_OPERATION_VITAL = 'feature_operation_vital',
20-
SHORT_SESSION_INVESTIGATION = 'short_session_investigation',
2120
START_STOP_ACTION = 'start_stop_action',
2221
START_STOP_RESOURCE = 'start_stop_resource',
2322
USE_CHANGE_RECORDS = 'use_change_records',

0 commit comments

Comments
 (0)