✅ move 'initialViewOptions' to the options object

Author: BenoitZugmeyer

packages/rum-core/src/domain/view/setupViewTest.specHelper.ts

@@ -9,15 +9,13 @@ import { trackViews } from './trackViews'
 
 export type ViewTest = ReturnType<typeof setupViewTest>
 
-interface ViewTrackingContext {
+interface ViewTestOptions {
   initialLocation?: string
   partialConfig?: Partial<RumConfiguration>
+  initialViewOptions?: ViewOptions
 }
 
-export function setupViewTest(
-  { initialLocation, partialConfig }: ViewTrackingContext = {},
-  initialViewOptions?: ViewOptions
-) {
+export function setupViewTest({ initialLocation, partialConfig, initialViewOptions }: ViewTestOptions = {}) {
   const lifeCycle = new LifeCycle()
   const domMutationObservable = new Observable<RumMutationRecord[]>()
   const windowOpenObservable = new Observable<void>()

packages/rum-core/src/domain/view/trackViews.spec.ts

@@ -21,7 +21,7 @@ describe('track views automatically', () => {
   let viewTest: ViewTest
 
   beforeEach(() => {
-    viewTest = setupViewTest({ initialLocation: '/foo' }, { name: 'initial view name' })
+    viewTest = setupViewTest({ initialLocation: '/foo', initialViewOptions: { name: 'initial view name' } })
     changeLocation = viewTest.changeLocation
   })
 
@@ -94,14 +94,14 @@ describe('view lifecycle', () => {
   beforeEach(() => {
     clock = mockClock()
 
-    viewTest = setupViewTest(
-      { initialLocation: '/foo' },
-      {
+    viewTest = setupViewTest({
+      initialLocation: '/foo',
+      initialViewOptions: {
         name: 'initial view name',
         service: 'initial service',
         version: 'initial version',
-      }
-    )
+      },
+    })
     notifySpy = spyOn(viewTest.lifeCycle, 'notify').and.callThrough()
 
     changeLocation = viewTest.changeLocation
@@ -919,13 +919,13 @@ describe('service and version', () => {
   })
 
   it('should come from the view option if defined', () => {
-    const { getViewUpdate } = setupViewTest(
-      { partialConfig: { service: 'service', version: 'version' } },
-      {
+    const { getViewUpdate } = setupViewTest({
+      partialConfig: { service: 'service', version: 'version' },
+      initialViewOptions: {
         service: 'view service',
         version: 'view version',
-      }
-    )
+      },
+    })
 
     expect(getViewUpdate(0).service).toEqual('view service')
     expect(getViewUpdate(0).version).toEqual('view version')