👌 Restore VIEW_UPDATE in RumEventType enum

Author: mormubis

packages/rum-core/src/domain/assembly.spec.ts

@@ -436,27 +436,29 @@ describe('rum assembly', () => {
   describe('service and version', () => {
     const extraConfigurationOptions = { service: 'default-service', version: 'default-version' }
 
-    Object.values(RumEventType).forEach((eventType) => {
-      it(`should be modifiable for ${eventType}`, () => {
-        const { lifeCycle, serverRumEvents } = setupAssemblyTestWithDefaults({
-          partialConfiguration: {
-            ...extraConfigurationOptions,
-            beforeSend: (event) => {
-              event.service = 'bar'
-              event.version = '0.2.0'
+    Object.values(RumEventType)
+      .filter((eventType) => eventType !== RumEventType.VIEW_UPDATE)
+      .forEach((eventType) => {
+        it(`should be modifiable for ${eventType}`, () => {
+          const { lifeCycle, serverRumEvents } = setupAssemblyTestWithDefaults({
+            partialConfiguration: {
+              ...extraConfigurationOptions,
+              beforeSend: (event) => {
+                event.service = 'bar'
+                event.version = '0.2.0'
 
-              return true
+                return true
+              },
             },
-          },
-        })
+          })
 
-        notifyRawRumEvent(lifeCycle, {
-          rawRumEvent: createRawRumEvent(eventType),
+          notifyRawRumEvent(lifeCycle, {
+            rawRumEvent: createRawRumEvent(eventType),
+          })
+          expect((serverRumEvents[0] as RumResourceEvent).service).toBe('bar')
+          expect((serverRumEvents[0] as RumResourceEvent).version).toBe('0.2.0')
         })
-        expect((serverRumEvents[0] as RumResourceEvent).service).toBe('bar')
-        expect((serverRumEvents[0] as RumResourceEvent).version).toBe('0.2.0')
       })
-    })
 
     it('should be added to the event as ddtags', () => {
       const { lifeCycle, serverRumEvents } = setupAssemblyTestWithDefaults({

packages/rum-core/src/domain/assembly.ts

@@ -49,6 +49,10 @@ export function startRumAssembly(
       ...VIEW_MODIFIABLE_FIELD_PATHS,
       ...ROOT_MODIFIABLE_FIELD_PATHS,
     },
+    // view_update events are created post-assembly in startRumBatch.ts and never reach this pipeline.
+    // The full view already went through assembly (as RumEventType.VIEW), so any beforeSend
+    // modifications (e.g. PII scrubbing) are already reflected in the view_update diff.
+    [RumEventType.VIEW_UPDATE]: {},
     [RumEventType.ERROR]: {
       'error.message': 'string',
       'error.stack': 'string',

packages/rum-core/src/rawRumEvent.types.ts

@@ -26,6 +26,7 @@ export const RumEventType = {
   ERROR: 'error',
   LONG_TASK: 'long_task',
   VIEW: 'view',
+  VIEW_UPDATE: 'view_update',
   RESOURCE: 'resource',
   VITAL: 'vital',
 } as const
@@ -180,6 +181,19 @@ export interface RawRumViewEvent {
   }
 }
 
+export interface RawRumViewUpdateEvent {
+  date: TimeStamp
+  type: typeof RumEventType.VIEW_UPDATE
+  view: Partial<RawRumViewEvent['view']>
+  _dd: Partial<RawRumViewEvent['_dd']> & {
+    document_version: number
+  }
+  display?: Partial<ViewDisplay>
+  privacy?: RawRumViewEvent['privacy']
+  device?: RawRumViewEvent['device']
+  feature_flags?: Context
+}
+
 interface ViewDisplay {
   scroll: {
     max_depth?: number
@@ -403,6 +417,7 @@ export type RawRumEvent =
   | RawRumErrorEvent
   | RawRumResourceEvent
   | RawRumViewEvent
+  | RawRumViewUpdateEvent
   | RawRumLongTaskEvent
   | RawRumLongAnimationFrameEvent
   | RawRumActionEvent

packages/rum-core/src/transport/startRumBatch.ts

@@ -46,7 +46,7 @@ export function assembleViewUpdateEvent(
 
   // Restore the ignoreKeys — backend needs them on every event
   return combine(diff, {
-    type: 'view_update' as const,
+    type: RumEventType.VIEW_UPDATE,
     date: current.date,
     application: current.application,
     session: current.session,

packages/rum-core/test/fixtures.ts

@@ -119,6 +119,18 @@ export function createRawRumEvent(type: RumEventType, overrides?: Context): RawR
         },
         overrides
       )
+    case RumEventType.VIEW_UPDATE:
+      return combine(
+        {
+          type,
+          date: 0 as TimeStamp,
+          view: {},
+          _dd: {
+            document_version: 1,
+          },
+        },
+        overrides
+      )
   }
 }