Skip to content

Commit e48694e

Browse files
committed
🚨 Fix review findings: JUnit reporter, remove migration script, playwright --with-deps
1 parent 23d1a16 commit e48694e

4 files changed

Lines changed: 5 additions & 259 deletions

File tree

‎.gitlab-ci.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ unit:
219219
junit: test-report/unit/*.xml
220220
script:
221221
- yarn
222-
- yarn playwright install chromium
222+
- yarn playwright install chromium --with-deps
223223
- yarn test:unit
224224
after_script:
225225
- node ./scripts/test/export-test-result.ts unit

‎scripts/migrate-to-vitest.ts‎

Lines changed: 0 additions & 258 deletions
This file was deleted.

‎vitest.bs.config.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,5 +119,7 @@ export default defineConfig({
119119
sequence: {
120120
shuffle: true,
121121
},
122+
123+
reporters: process.env.CI ? ['default', ['junit', { outputFile: 'test-report/unit-bs/results.xml' }]] : ['default'],
122124
},
123125
})

‎vitest.config.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,5 +74,7 @@ export default defineConfig({
7474

7575
// Note: Karma used stopSpecOnExpectationFailure, but Vitest's bail stops the entire run.
7676
// Use --bail on CLI when needed for fast feedback during development.
77+
78+
reporters: process.env.CI ? ['default', ['junit', { outputFile: 'test-report/unit/results.xml' }]] : ['default'],
7779
},
7880
})

0 commit comments

Comments
 (0)