♻️ merge the Vitest test helpers into the shared ones and drop the aliases

The Karma versions of the test helpers are dead code now: replace them with
their Vitest implementations and remove the aliases redirecting to the
copies in test/unit-vitest.

- registerCleanupTask: runs tasks with `onTestFinished`
- getCurrentJasmineSpec: tracked from forEach.ts (run for every test file)
- disableJasmineUncaughtExceptionTracking: Vitest-compatible listeners
- allJsonSchemas: `import.meta.glob` instead of webpack's `require.context`
  (no more JS + d.ts pair)
- vitest declared as a devDependency of @datadog/browser-core, which now
  imports it in test helpers

Author: thomas-lebeau

packages/browser-core/package.json

@@ -26,7 +26,8 @@
     "@datadog/js-core": "workspace:*"
   },
   "devDependencies": {
-    "pako": "3.0.2"
+    "pako": "3.0.2",
+    "vitest": "4.1.8"
   },
   "volta": {
     "extends": "../../package.json"

packages/browser-core/test/disableJasmineUncaughtExceptionTracking.ts

@@ -2,16 +2,22 @@ import { noop } from '@datadog/js-core/util'
 import { registerCleanupTask } from './registerCleanupTask'
 
 /**
- * Disable Jasmine's uncaught error handling. This is useful for test cases throwing exceptions or
- * unhandled rejections that are expected to be caught somehow, but Jasmine also catch them and
- * fails the test.
- *
- * Replace the handler instead of spying on it, so tests can still spy on `window.onerror`.
+ * Vitest will ignore uncaught errors if we add our own listener, see
+ * https://vitest.dev/guide/features.html#unhandled-errors
  */
 export function disableJasmineUncaughtExceptionTracking() {
-  const originalOnError = window.onerror
-  window.onerror = noop
+  window.addEventListener('error', noop)
+  window.addEventListener('unhandledrejection', noop)
+  const originalConsoleError = console.error
+  console.error = (...args) => {
+    if (new Error().stack!.includes('error-catcher.js')) {
+      return
+    }
+    originalConsoleError(...args)
+  }
   registerCleanupTask(() => {
-    window.onerror = originalOnError
+    console.error = originalConsoleError
+    window.removeEventListener('error', noop)
+    window.removeEventListener('unhandledrejection', noop)
   })
 }

packages/browser-core/test/forEach.ts

@@ -14,8 +14,11 @@ import { resetInteractionCountPolyfill } from '../../browser-rum-core/src/domain
 import { resetTelemetry } from '../src/domain/telemetry'
 import { resetSampleDecisionCache } from '../src/domain/sampler'
 import { startLeakDetection } from './leakDetection'
+import { trackCurrentJasmineSpec } from './getCurrentJasmineSpec'
 ;(window as any).IS_REACT_ACT_ENVIRONMENT = true
 
+trackCurrentJasmineSpec()
+
 beforeEach(() => {
   // prevent 'Some of your tests did a full page reload!' issue
   window.onbeforeunload = () => 'stop'

packages/browser-core/test/getCurrentJasmineSpec.ts

@@ -1,14 +1,30 @@
-let currentSpec: jasmine.SpecResult | null = null
+import { beforeEach, onTestFinished } from 'vitest'
+
+let currentSpec: { fullName: string } | null = null
 
 export function getCurrentJasmineSpec() {
   return currentSpec
 }
 
-jasmine.getEnv().addReporter({
-  specStarted(specResult) {
-    currentSpec = specResult
-  },
-  specDone() {
-    currentSpec = null
-  },
-})
+/**
+ * Called from forEach.ts, a setup file which runs for every test file. Hooks registered when this module is
+ * evaluated would only apply to the first test file when files share the same page (`isolate:
+ * false`).
+ */
+export function trackCurrentJasmineSpec() {
+  beforeEach((context) => {
+    const parts: string[] = []
+    let current: any = context.task
+    while (current) {
+      if (current.name) {
+        parts.unshift(current.name)
+      }
+      current = current.suite
+    }
+    currentSpec = { fullName: parts.join(' ') }
+
+    onTestFinished(() => {
+      currentSpec = null
+    })
+  })
+}

packages/browser-core/test/registerCleanupTask.ts

@@ -1,13 +1,9 @@
-type CleanupTask = () => unknown
+import { onTestFinished } from 'vitest'
 
-const cleanupTasks: CleanupTask[] = []
+type CleanupTask = () => unknown
 
 export function registerCleanupTask(task: CleanupTask) {
-  cleanupTasks.unshift(task)
-}
-
-afterEach(async () => {
-  for (const task of cleanupTasks.splice(0)) {
+  onTestFinished(async () => {
     await task()
-  }
-})
+  })
+}

packages/browser-rum-core/test/allJsonSchemas.d.ts

@@ -0,0 +1,4 @@
+/// <reference types="vite/client" />
+
+const modules = import.meta.glob('../../../node_modules/@datadog/rum-events-format/schemas/**/*.json', { eager: true })
+export const allJsonSchemas = Object.values(modules)