Skip to content

Commit f2724ec

Browse files
committed
♻️ Use useSettings hook in EventsTabSide instead of prop drilling
1 parent 266234a commit f2724ec

3 files changed

Lines changed: 5 additions & 14 deletions

File tree

developer-extension/src/panel/components/panel.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ export function Panel() {
8484
columns={columns}
8585
onColumnsChange={setColumns}
8686
clear={clear}
87-
datadogMode={settings.datadogMode}
8887
/>
8988
</Tabs.Panel>
9089
<Tabs.Panel value={PanelTabs.Infos} className={classes.tab}>

developer-extension/src/panel/components/tabs/eventsTab/eventsTab.tsx

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ interface EventsTabProps {
1616
columns: EventListColumn[]
1717
onColumnsChange: (columns: EventListColumn[]) => void
1818
clear: () => void
19-
datadogMode: boolean
2019
}
2120

2221
export function EventsTab({
@@ -27,19 +26,11 @@ export function EventsTab({
2726
columns,
2827
onColumnsChange,
2928
clear,
30-
datadogMode,
3129
}: EventsTabProps) {
3230
return (
3331
<TabBase
3432
top={<EventsTabTop filters={filters} onFiltersChange={onFiltersChange} clear={clear} />}
35-
leftSide={
36-
<EventsTabSide
37-
filters={filters}
38-
onFiltersChange={onFiltersChange}
39-
facetRegistry={facetRegistry}
40-
datadogMode={datadogMode}
41-
/>
42-
}
33+
leftSide={<EventsTabSide filters={filters} onFiltersChange={onFiltersChange} facetRegistry={facetRegistry} />}
4334
>
4435
{events.length === 0 || !facetRegistry ? (
4536
<Center>

developer-extension/src/panel/components/tabs/eventsTab/eventsTabSide.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,23 @@
11
import { Box, Checkbox } from '@mantine/core'
22
import React from 'react'
33
import type { EventFilters, FacetRegistry } from '../../../hooks/useEvents'
4+
import { useSettings } from '../../../hooks/useSettings'
45
import { FacetList } from './facetList'
56

67
export function EventsTabSide({
78
facetRegistry,
89
filters,
910
onFiltersChange,
10-
datadogMode,
1111
}: {
1212
facetRegistry?: FacetRegistry
1313
filters: EventFilters
1414
onFiltersChange: (filters: EventFilters) => void
15-
datadogMode: boolean
1615
}) {
16+
const [settings] = useSettings()
17+
1718
return (
1819
<Box ml="md">
19-
{datadogMode && (
20+
{settings.datadogMode && (
2021
<Checkbox
2122
label={'Show only the latest View\xa0event'}
2223
checked={!filters.outdatedVersions}

0 commit comments

Comments
 (0)