⚗️ Add canvas change detection for Session Replay - #4949
Draft
BeltranBulbarellaDD wants to merge 5 commits into
Draft
⚗️ Add canvas change detection for Session Replay#4949BeltranBulbarellaDD wants to merge 5 commits into
BeltranBulbarellaDD wants to merge 5 commits into
Conversation
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: ad260aa | Docs | Datadog PR Page | Give us feedback! |
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 685c28e8ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
5 tasks
BeltranBulbarellaDD
force-pushed
the
beltran.bulbarella/canvas_support-2-prefilter
branch
from
August 14, 2026 14:53
434f477 to
ad260aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Canvas image capture can be expensive, so Session Replay should only capture a canvas after its contents have changed. This stacked PR adds the dirty-state pre-filter foundation for canvas recording.
Depends on #4947.
Design references:
Changes
WeakSet-backed canvas manager to track dirty canvases without retaining detached elements.CanvasRenderingContext2Dmethods and canvaswidth/heightchanges.This PR only adds change detection; capturing and marking canvases clean will be connected in a follow-up.
Test instructions
Checklist