Skip to content

Commit 692c458

Browse files
authored
Merge pull request #192 from DataDog/yoann/node-v20
[chore] Upgrade to node 20
2 parents de95af0 + 09e90f3 commit 692c458

16 files changed

Lines changed: 31 additions & 32 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,18 @@ on: pull_request
44

55
jobs:
66
unit-test:
7-
strategy:
8-
fail-fast: false
9-
matrix:
10-
node:
11-
- node-version-file: 'package.json'
12-
- node-version: 20.x
13-
14-
name: Unit tests w/ Node.js ${{matrix.node.node-version || matrix.node.node-version-file}}
7+
name: Unit tests
158
runs-on: ubuntu-latest
169
env:
1710
FORCE_COLOR: true
1811

1912
steps:
2013
- uses: actions/checkout@v4
2114

22-
- name: Install Node ${{matrix.node.node-version || matrix.node.node-version-file}}
15+
- name: Install Node
2316
uses: actions/setup-node@v4
24-
with: ${{matrix.node}}
17+
with:
18+
node-version-file: 'package.json'
2519

2620
- name: Cache build:all
2721
id: cache-build
-379 KB
Binary file not shown.
434 KB
Binary file not shown.
32.6 KB
Binary file not shown.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"packages/published/*"
1414
],
1515
"volta": {
16-
"node": "18.20.5",
16+
"node": "20.19.4",
1717
"yarn": "1.22.19"
1818
},
1919
"scripts": {
@@ -39,7 +39,7 @@
3939
}
4040
},
4141
"devDependencies": {
42-
"@types/node": "^18",
42+
"@types/node": "^20",
4343
"@typescript-eslint/eslint-plugin": "7.5.0",
4444
"@typescript-eslint/parser": "7.5.0",
4545
"eslint": "8.57.0",

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"devDependencies": {
3131
"@types/async-retry": "1.4.8",
3232
"@types/chalk": "2.2.0",
33-
"@types/node": "^18",
33+
"@types/node": "^20",
3434
"esbuild": "0.24.0",
3535
"typescript": "5.4.3",
3636
"unplugin": "1.16.0"

packages/core/src/helpers/fs.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,8 @@ export const existsSync = (filepath: string) => {
8484

8585
// From a path, returns a File to use with native FormData and fetch.
8686
export const getFile = async (filepath: string, options: LocalAppendOptions) => {
87-
// @ts-expect-error openAsBlob is not in the NodeJS types until 19+
8887
if (typeof fs.openAsBlob === 'function') {
8988
// Support NodeJS 19+
90-
// @ts-expect-error openAsBlob is not in the NodeJS types until 19+
9189
const blob = await fs.openAsBlob(filepath, { type: options.contentType });
9290
return new File([blob], options.filename);
9391
} else {

packages/published/esbuild-plugin/rollup.config.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44

55
import { getDefaultBuildConfigs } from '@dd/tools/rollupConfig.mjs';
66

7-
import packageJson from './package.json' assert { type: 'json' };
7+
import packageJson from './package.json' with { type: 'json' };
88

99
export default getDefaultBuildConfigs(packageJson);

packages/published/rollup-plugin/rollup.config.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44

55
import { getDefaultBuildConfigs } from '@dd/tools/rollupConfig.mjs';
66

7-
import packageJson from './package.json' assert { type: 'json' };
7+
import packageJson from './package.json' with { type: 'json' };
88

99
export default getDefaultBuildConfigs(packageJson);

packages/published/rspack-plugin/rollup.config.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44

55
import { getDefaultBuildConfigs } from '@dd/tools/rollupConfig.mjs';
66

7-
import packageJson from './package.json' assert { type: 'json' };
7+
import packageJson from './package.json' with { type: 'json' };
88

99
export default getDefaultBuildConfigs(packageJson);

0 commit comments

Comments
 (0)