refactor(apps): rename apps-import identifiers to reflect apps-backend

DATADOG_APPS_IMPORT and isDatadogAppsInstalled predated the
@datadog/apps-backend runtime split and no longer matched the package
they check for.

Author: Scott-Meyer

packages/plugins/apps/src/backend/shared.ts

@@ -21,7 +21,7 @@ export function isActionCatalogInstalled(fromDir: string): boolean {
 }
 
 /** Check if the @datadog/apps-backend "JS Function with Actions" runtime factory is installed. */
-export function isDatadogAppsInstalled(fromDir: string): boolean {
+export function isDatadogAppsBackendInstalled(fromDir: string): boolean {
     return isPackageExportInstalled('@datadog/apps-backend/runtime/jsFunctionWithActions', fromDir);
 }
 
@@ -30,7 +30,7 @@ export const ACTION_CATALOG_IMPORT =
     "import { setExecuteActionImplementation } from '@datadog/action-catalog/action-execution';";
 
 /** The import line that exposes @datadog/apps-backend backend context initialization. */
-export const DATADOG_APPS_IMPORT = `\
+export const DATADOG_APPS_BACKEND_IMPORT = `\
 import { buildRuntimeFromJsFunctionWithActions } from '@datadog/apps-backend/runtime/jsFunctionWithActions';
 import { setBackend } from '@datadog/apps-backend/runtime';`;
 

packages/plugins/apps/src/backend/virtual-entry.test.ts

@@ -18,7 +18,7 @@ describe('Backend Functions - generateVirtualEntryContent', () => {
     describe('without action-catalog', () => {
         beforeEach(() => {
             jest.spyOn(shared, 'isActionCatalogInstalled').mockReturnValue(false);
-            jest.spyOn(shared, 'isDatadogAppsInstalled').mockReturnValue(false);
+            jest.spyOn(shared, 'isDatadogAppsBackendInstalled').mockReturnValue(false);
         });
 
         test('Should import the function by name from the entry path', () => {
@@ -105,7 +105,7 @@ describe('Backend Functions - generateVirtualEntryContent', () => {
     describe('with action-catalog', () => {
         beforeEach(() => {
             jest.spyOn(shared, 'isActionCatalogInstalled').mockReturnValue(true);
-            jest.spyOn(shared, 'isDatadogAppsInstalled').mockReturnValue(false);
+            jest.spyOn(shared, 'isDatadogAppsBackendInstalled').mockReturnValue(false);
         });
 
         test('Should include action-catalog import', () => {
@@ -132,7 +132,7 @@ describe('Backend Functions - generateVirtualEntryContent', () => {
     describe('with @datadog/apps-backend', () => {
         beforeEach(() => {
             jest.spyOn(shared, 'isActionCatalogInstalled').mockReturnValue(false);
-            jest.spyOn(shared, 'isDatadogAppsInstalled').mockReturnValue(true);
+            jest.spyOn(shared, 'isDatadogAppsBackendInstalled').mockReturnValue(true);
         });
 
         test('Should import and set the backend context before calling the handler', () => {
@@ -157,7 +157,7 @@ describe('Backend Functions - generateVirtualEntryContent', () => {
 
     test('Should escape entry paths with special characters', () => {
         jest.spyOn(shared, 'isActionCatalogInstalled').mockReturnValue(false);
-        jest.spyOn(shared, 'isDatadogAppsInstalled').mockReturnValue(false);
+        jest.spyOn(shared, 'isDatadogAppsBackendInstalled').mockReturnValue(false);
         const result = generateVirtualEntryContent(
             'handler',
             '/path/with "quotes"/handler.ts',
@@ -171,7 +171,7 @@ describe('Backend Functions - generateDevVirtualEntryContent', () => {
     beforeEach(() => {
         jest.restoreAllMocks();
         jest.spyOn(shared, 'isActionCatalogInstalled').mockReturnValue(false);
-        jest.spyOn(shared, 'isDatadogAppsInstalled').mockReturnValue(false);
+        jest.spyOn(shared, 'isDatadogAppsBackendInstalled').mockReturnValue(false);
     });
 
     test('Should produce identical output to generateVirtualEntryContent', () => {
@@ -202,7 +202,7 @@ describe('Backend Functions - args round-trip via $.backendFunctionArgs', () =>
     beforeEach(() => {
         jest.restoreAllMocks();
         jest.spyOn(shared, 'isActionCatalogInstalled').mockReturnValue(false);
-        jest.spyOn(shared, 'isDatadogAppsInstalled').mockReturnValue(false);
+        jest.spyOn(shared, 'isDatadogAppsBackendInstalled').mockReturnValue(false);
     });
 
     // Extract the body of the generated `main($)` function so we can eval it

packages/plugins/apps/src/backend/virtual-entry.ts

@@ -4,11 +4,11 @@
 
 import {
     ACTION_CATALOG_IMPORT,
-    DATADOG_APPS_IMPORT,
+    DATADOG_APPS_BACKEND_IMPORT,
     SET_BACKEND_CONTEXT_SNIPPET,
     SET_EXECUTE_ACTION_SNIPPET,
     isActionCatalogInstalled,
-    isDatadogAppsInstalled,
+    isDatadogAppsBackendInstalled,
 } from './shared';
 
 /**
@@ -21,12 +21,12 @@ export function generateVirtualEntryContent(
     projectRoot: string,
 ): string {
     const lines: string[] = [];
-    const hasDatadogAppsBackendRuntime = isDatadogAppsInstalled(projectRoot);
+    const hasDatadogAppsBackendRuntime = isDatadogAppsBackendInstalled(projectRoot);
 
     lines.push(`import { ${functionName} } from ${JSON.stringify(entryPath)};`);
 
     if (hasDatadogAppsBackendRuntime) {
-        lines.push(DATADOG_APPS_IMPORT);
+        lines.push(DATADOG_APPS_BACKEND_IMPORT);
     }
 
     if (isActionCatalogInstalled(projectRoot)) {