Skip to content

Commit 4127ed6

Browse files
committed
renovate: do not pinDigest for golangci/golangci-lint
The github-actions manager auto-extracts the "version:" input of the golangci/golangci-lint-action step as a github-releases "golangci/golangci-lint" dependency. With "pinDigests: true" Renovate tries to pin it to a commit SHA, but a plain "version: vX.Y.Z" value has nowhere to store a digest, so the update can never be applied. Renovate fails with "Error updating branch: update failure" and, since the dependency is grouped into the all-dependencies branch, every other bump in that branch (e.g. the docker.io/library/ubuntu base image) is dropped as well. The golangci-lint version is already tracked through the "datasource=docker depName=golangci/golangci-lint" comment handled by the custom regex manager, so disable digest pinning for the github-actions occurrence only. Signed-off-by: André Martins <andre@cilium.io>
1 parent 6403216 commit 4127ed6

1 file changed

Lines changed: 17 additions & 0 deletions

File tree

.github/renovate.json5

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,23 @@
140140
],
141141
"pinDigests": false
142142
},
143+
{
144+
// Do not pin digests for the golangci/golangci-lint dependency that the
145+
// github-actions manager auto-extracts from the 'version:' input of the
146+
// golangci/golangci-lint-action step. A plain 'version: vX.Y.Z' value has
147+
// nowhere to store a commit SHA, so Renovate can never apply the digest
148+
// pin and the whole grouped branch fails with "update failure". The
149+
// version itself is still tracked through the
150+
// 'datasource=docker depName=golangci/golangci-lint' comment handled by
151+
// the custom regex manager.
152+
"matchManagers": [
153+
"github-actions"
154+
],
155+
"matchPackageNames": [
156+
"golangci/golangci-lint"
157+
],
158+
"pinDigests": false
159+
},
143160
{
144161
"matchPackageNames": [
145162
"bufbuild/buf", // Protocol buffer toolkit

0 commit comments

Comments
 (0)