bgpv2: Update component tests to work with LB cell

After migration of svc reconciler to svc LB tables,
update component tests infra to contain necessary LB cells,
and update the tests to work properly: provide both v4 and v6
endpointslices when local endpoints are expected, use distinct
ports among services in the service VIP sharing test.

Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>

Author: rastislavs

pkg/bgpv1/test/script_test.go

@@ -30,6 +30,12 @@ import (
 	"github.com/cilium/cilium/pkg/datapath/linux/safenetlink"
 	"github.com/cilium/cilium/pkg/datapath/tables"
 	envoyCfg "github.com/cilium/cilium/pkg/envoy/config"
+	"github.com/cilium/cilium/pkg/kpr"
+	"github.com/cilium/cilium/pkg/loadbalancer"
+	lbcell "github.com/cilium/cilium/pkg/loadbalancer/cell"
+	"github.com/cilium/cilium/pkg/maglev"
+	"github.com/cilium/cilium/pkg/node"
+	"github.com/cilium/cilium/pkg/source"
 
 	ciliumhive "github.com/cilium/cilium/pkg/hive"
 	ipamOption "github.com/cilium/cilium/pkg/ipam/option"
@@ -58,6 +64,8 @@ func TestPrivilegedScript(t *testing.T) {
 	testutils.PrivilegedTest(t)
 	slog.SetLogLoggerLevel(slog.LevelDebug) // used by test GoBGP instances
 
+	types.SetName(testNodeName)
+
 	// setup test link
 	dummy := &netlink.Dummy{
 		LinkAttrs: netlink.LinkAttrs{Name: testLinkName},
@@ -89,35 +97,55 @@ func TestPrivilegedScript(t *testing.T) {
 		}
 
 		h := ciliumhive.New(
-			k8sClient.FakeClientCell(),
-			daemonk8s.ResourcesCell,
-			cell.Config(envoyCfg.SecretSyncConfig{}),
-
 			metrics.Cell,
+
+			// BGP cell
 			bgpv1.Cell,
 
-			// Provide route and device tables
+			// Provide statedb tables
 			cell.Provide(
 				tables.NewRouteTable,
 				tables.NewDeviceTable,
-				statedb.RWTable[*tables.Route].ToTable,  // Table[*Route]
-				statedb.RWTable[*tables.Device].ToTable, // Table[*Device]
+				tables.NewNodeAddressTable,
+				statedb.RWTable[*tables.Route].ToTable,      // Table[*Route]
+				statedb.RWTable[*tables.Device].ToTable,     // Table[*Device]
+				statedb.RWTable[tables.NodeAddress].ToTable, // Table[NodeAddress]
 			),
 
-			cell.Provide(func() *option.DaemonConfig {
-				// BGP Manager uses the global variable option.Config so we need to set it there as well
-				option.Config = &option.DaemonConfig{
-					EnableBGPControlPlane:     true,
-					BGPSecretsNamespace:       testSecretsNamespace,
-					BGPRouterIDAllocationMode: option.BGPRouterIDAllocationModeDefault,
-					IPAM:                      *ipam,
-				}
-				return option.Config
-			}),
+			// Dependencies
+			k8sClient.FakeClientCell(),
+			daemonk8s.ResourcesCell,
+			daemonk8s.TablesCell,
+			node.LocalNodeStoreTestCell,
+			cell.Config(envoyCfg.SecretSyncConfig{}),
 
-			cell.Invoke(func() {
-				types.SetName(testNodeName)
-			}),
+			// LB cell to populate LB tables from k8s services / endpoints
+			lbcell.Cell,
+			maglev.Cell,
+			cell.Provide(source.NewSources),
+			cell.Config(loadbalancer.TestConfig{}),
+			cell.Provide(
+				func(cfg loadbalancer.TestConfig) *loadbalancer.TestConfig { return &cfg }, // newLBMaps expects *TestConfig
+			),
+
+			cell.Provide(
+				func() *option.DaemonConfig {
+					option.Config = &option.DaemonConfig{
+						EnableBGPControlPlane:     true,
+						BGPSecretsNamespace:       testSecretsNamespace,
+						BGPRouterIDAllocationMode: option.BGPRouterIDAllocationModeDefault,
+						IPAM:                      *ipam,
+						EnableIPv4:                true,
+						EnableIPv6:                true,
+					}
+					return option.Config
+				},
+				func() kpr.KPRConfig {
+					return kpr.KPRConfig{
+						KubeProxyReplacement: true,
+					}
+				},
+			),
 			cell.Invoke(func(m agent.BGPRouterManager) {
 				bgpMgr = m
 				m.(*manager.BGPRouterManager).DestroyRouterOnStop(true) // fully destroy GoBGP server on Stop()

pkg/bgpv1/test/testdata/svc-aggregation.txtar

@@ -12,8 +12,8 @@ gobgp/add-server test 65010 10.99.4.211 1790
 # Configure peers on GoBGP
 gobgp/add-peer 10.99.4.212 65001
 
-# Add k8s services
-k8s/add service-1.yaml service-2.yaml service-3.yaml endpoints.yaml
+# Add k8s services and endpoints
+k8s/add service-1.yaml service-2.yaml service-3.yaml endpoints-ipv4.yaml endpoints-ipv6.yaml
 
 # Configure BGP on Cilium
 k8s/add cilium-node.yaml bgp-node-config.yaml bgp-peer-config.yaml bgp-advertisement-1.yaml
@@ -274,13 +274,13 @@ status:
     - ip: 172.16.1.3
     - ip: fd00:cc:dd::3
 
--- endpoints.yaml --
+-- endpoints-ipv4.yaml --
 apiVersion: discovery.k8s.io/v1
 kind: EndpointSlice
 metadata:
   labels:
     kubernetes.io/service-name: svc3
-  name: svc3-eps1
+  name: svc3-eps-ipv4
   uid: d1f517f6-ab88-4c76-9bd0-4906a17cdd75
 addressType: IPv4
 endpoints:
@@ -296,6 +296,28 @@ ports:
   port: 80
   protocol: TCP
 
+-- endpoints-ipv6.yaml --
+apiVersion: discovery.k8s.io/v1
+kind: EndpointSlice
+metadata:
+  labels:
+    kubernetes.io/service-name: svc3
+  name: svc3-eps-ipv6
+  uid: d1f517f6-ab88-4c76-9bd0-4906a17cdd76
+addressType: IPv6
+endpoints:
+- addresses:
+  - 2001::1:20
+  conditions:
+    ready: true
+    serving: true
+    terminating: false
+  nodeName: test-node
+ports:
+- name: http
+  port: 80
+  protocol: TCP
+
 -- gobgp-routes-aggregated-ipv4-1.expected --
 Prefix            NextHop       Attrs
 10.10.10.0/24     10.99.4.212   [{Origin: i} {AsPath: 65001} {Nexthop: 10.99.4.212}]

pkg/bgpv1/test/testdata/svc-sharing.txtar

@@ -161,9 +161,9 @@ spec:
   ipFamilyPolicy: SingleStack
   ports:
   - name: http
-    port: 80
+    port: 8080
     protocol: TCP
-    targetPort: 80
+    targetPort: 8080
   selector:
     name: echo
   sessionAffinity: None