Skip to content

Commit c2b823c

Browse files
committed
renovate: restore updates of docker images
The blamed commit introduced a 5-days cooldown period for all dependency updates. However, it appears that no docker registry, except Docker Hub, reliably supports release timestamps today [1], in turn causing docker dependencies to not be updated by renovate anymore. This is confirmed by renovate log lines along the lines of: > Marking ... release(s) as pending, as they do not have a releaseTimestamp > and we're running with minimumReleaseAgeBehaviour=timestamp-required Specifically, we hit occurrences with images hosted on quay.io, gcr.io, registry.k8s.io and ghcr.io. Let's restore updates of docker images again by enabling timestamp-optional mode for docker dependencies, which effectively disables the cooldown period if the registry does not provide timestamp information. That's suboptimal, but still better than having no updates at all. [1]: https://docs.renovatebot.com/key-concepts/minimum-release-age/#which-registries-support-release-timestamps Fixes: 8f7e55a ("renovate: add dependency cooldown") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
1 parent 736f7d1 commit c2b823c

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

.github/renovate.json5

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,15 @@
125125
"matchUpdateTypes": ["major", "minor", "patch"],
126126
"minimumReleaseAge": "5 days"
127127
},
128+
{
129+
// Docker Hub is the only Docker registry that currently supports release
130+
// timestamps, causing updates to be never proposed by Renovate for all
131+
// other registries. Hence, let's enable the "timestamp-optional" option,
132+
// which unfortunately effectively disables the cooldown period for them.
133+
// https://docs.renovatebot.com/key-concepts/minimum-release-age/#which-registries-support-release-timestamps
134+
"matchDatasources": ["docker"],
135+
"minimumReleaseAgeBehaviour": "timestamp-optional",
136+
},
128137
{
129138
// Do not pin or update digests for self-referenced cilium/cilium GitHub
130139
// Actions and reusable workflows (e.g.,

0 commit comments

Comments
 (0)