dial: Fix flake in TestLBServiceResolver

The test was prepending a reactor after Hive was started causing it
sometimes to be added too late.

Also remove the check that "store should not have started" as that makes
no sense since call to "Resolve()" does not affect whether or not a
reflector in the background has made the list call or not.

$ stress -count 10000 ./dial.test
1m7s: 10000 runs total, 0 failures

Fixes: cilium#43157
Fixes: 0e0242e ("dial: Use Table[Frontend] for looking up address")
Signed-off-by: Jussi Maki <jussi@isovalent.com>

Author: joamaki

pkg/dial/resolver_test.go

@@ -107,20 +107,21 @@ func testResolver(t *testing.T, cells ...cell.Cell) {
 
 		cell.Invoke(func(cl_ *k8sClient.FakeClientset, resolver_ dial.Resolver) {
 			cl = cl_
+
+			// Add a reactor to check that services are being watched.
+			cl.SlimFakeClientset.PrependReactor("list", "services",
+				func(action k8stest.Action) (handled bool, ret runtime.Object, err error) {
+					started.Store(true)
+					return false, nil, nil
+				},
+			)
 			resolver = resolver_
 		}),
 		cell.Group(cells...))
 
 	require.NoError(t, h.Start(tlog, ctx))
 	t.Cleanup(func() { require.NoError(t, h.Stop(tlog, ctx)) })
 
-	cl.SlimFakeClientset.PrependReactor("list", "services",
-		func(action k8stest.Action) (handled bool, ret runtime.Object, err error) {
-			started.Store(true)
-			return false, nil, nil
-		},
-	)
-
 	_, err := cl.Slim().CoreV1().Services("bar").Create(ctx, &slim_corev1.Service{
 		ObjectMeta: slim_metav1.ObjectMeta{Name: "foo", Namespace: "bar"},
 		Spec:       slim_corev1.ServiceSpec{ClusterIP: "192.168.0.1", Ports: []slim_corev1.ServicePort{{Port: 8080}}},
@@ -137,7 +138,6 @@ func testResolver(t *testing.T, cells ...cell.Cell) {
 	host, port := resolver.Resolve(ctx, "foo.bar.com", "8080")
 	require.Equal(t, "foo.bar.com", host)
 	require.Equal(t, "8080", port)
-	require.False(t, started.Load(), "The store should not have started")
 
 	require.EventuallyWithT(t, func(c *assert.CollectT) {
 		host, port := resolver.Resolve(ctx, "foo.bar", "8080")