fix lint: tag alignment, doc comments, unused params

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: cahillsf

cmd/crossplane/core/core.go

@@ -130,8 +130,8 @@ type startCommand struct {
 	TLSClientCertsDir   string `env:"TLS_CLIENT_CERTS_DIR"   help:"The path of the folder which will store TLS client certificate of Crossplane."`
 
 	TLSClientCACertFileName string `env:"TLS_CLIENT_CA_CERT_FILENAME" help:"The filename of the CA certificate in the TLS client certs directory."`
-	TLSClientCertFileName   string `env:"TLS_CLIENT_CERT_FILENAME"   help:"The filename of the client certificate in the TLS client certs directory."`
-	TLSClientKeyFileName    string `env:"TLS_CLIENT_KEY_FILENAME"    help:"The filename of the client private key in the TLS client certs directory."`
+	TLSClientCertFileName   string `env:"TLS_CLIENT_CERT_FILENAME"    help:"The filename of the client certificate in the TLS client certs directory."`
+	TLSClientKeyFileName    string `env:"TLS_CLIENT_KEY_FILENAME"     help:"The filename of the client private key in the TLS client certs directory."`
 
 	TLSServerCertFileName string `env:"TLS_SERVER_CERT_FILENAME" help:"The filename of the server certificate in the TLS server certs directory."`
 	TLSServerKeyFileName  string `env:"TLS_SERVER_KEY_FILENAME"  help:"The filename of the server private key in the TLS server certs directory."`

cmd/crossplane/core/init.go

@@ -55,8 +55,8 @@ type initCommand struct {
 	TLSServerSecretName     string `env:"TLS_SERVER_SECRET_NAME"    help:"The name of the Secret that the initializer will fill with TLS server certificates."`
 	TLSClientSecretName     string `env:"TLS_CLIENT_SECRET_NAME"    help:"The name of the Secret that the initializer will fill with TLS client certificates."`
 
-	WebhookTLSCertDir string `env:"WEBHOOK_TLS_CERT_DIR"  help:"Directory containing TLS certificates for webhooks. When set, certificates are read from files instead of Secrets."`
-	WebhookTLSCACert  string `env:"WEBHOOK_TLS_CA_CERT" help:"Filename of the CA certificate within the TLS cert directory."`
+	WebhookTLSCertDir string `env:"WEBHOOK_TLS_CERT_DIR" help:"Directory containing TLS certificates for webhooks. When set, certificates are read from files instead of Secrets."`
+	WebhookTLSCACert  string `env:"WEBHOOK_TLS_CA_CERT"  help:"Filename of the CA certificate within the TLS cert directory."`
 }
 
 // Run starts the initialization process.

internal/initializer/webhook_configurations.go

@@ -50,6 +50,7 @@ type SecretCAProvider struct {
 	SecretRef types.NamespacedName
 }
 
+// GetCABundle returns the CA bundle from a Kubernetes Secret.
 func (p *SecretCAProvider) GetCABundle(ctx context.Context, kube client.Client) ([]byte, error) {
 	s := &corev1.Secret{}
 	if err := kube.Get(ctx, p.SecretRef, s); err != nil {
@@ -68,7 +69,8 @@ type FileCAProvider struct {
 	Path string
 }
 
-func (p *FileCAProvider) GetCABundle(ctx context.Context, kube client.Client) ([]byte, error) {
+// GetCABundle returns the CA bundle from a file on disk.
+func (p *FileCAProvider) GetCABundle(_ context.Context, _ client.Client) ([]byte, error) {
 	data, err := os.ReadFile(p.Path)
 	if err != nil {
 		return nil, errors.Wrap(err, errReadCABundleFile)