Fix the help text of commands that have dynamic parameters (#47)

Author: ofek

CHANGELOG.md

@@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 ***Fixed:***
 
 - Fix escaping on the non-Windows entry points of prebuilt distributions
+- Fix the help text of commands that have dynamic parameters
 
 ## 0.6.1 - 2025-03-10
 

src/dda/cli/base.py

@@ -64,6 +64,7 @@ def __init__(
 
         self._features = features
         self._dependencies = dependencies
+        self.__help_option: click.Option | None = None
 
     def get_params(self, ctx: click.Context) -> list[click.Parameter]:
         # https://github.com/pallets/click/pull/2784
@@ -85,6 +86,33 @@ def invoke(self, ctx: click.Context) -> Any:
 
         return super().invoke(ctx)
 
+    def get_help_option(self, ctx: click.Context) -> click.Option | None:
+        if self.__help_option is not None:
+            return self.__help_option
+
+        help_option = super().get_help_option(ctx)
+        if help_option is not None:
+            original_callback = help_option.callback
+
+            all_callbacks_executed = False
+
+            def callback(ctx: click.Context, param: click.Parameter, value: Any) -> None:
+                nonlocal all_callbacks_executed
+                if not all_callbacks_executed:
+                    # Callbacks for other parameters may influence the help text
+                    for other_param in ctx.command.get_params(ctx):
+                        if other_param is not param and other_param.callback is not None:
+                            other_param.callback(ctx, other_param, None)
+                    all_callbacks_executed = True
+
+                if original_callback is not None:
+                    original_callback(ctx, param, value)
+
+            help_option.callback = callback
+            self.__help_option = help_option
+
+        return self.__help_option
+
 
 class DynamicGroup(click.RichGroup):
     context_class = DynamicContext

src/dda/cli/env/dev/utils.py

@@ -24,12 +24,6 @@ def get_env_type(ctx: click.Context, param: click.Option, value: str | None) ->
     return env_type
 
 
-def option_env_type_callback(ctx: click.Context, param: click.Option, value: str | None) -> str:
-    from dda.cli.env.dev.utils import get_env_type
-
-    return get_env_type(ctx, param, value)
-
-
 option_env_type = partial(
     click.option,
     "--type",
@@ -38,6 +32,6 @@ def option_env_type_callback(ctx: click.Context, param: click.Option, value: str
     type=click.Choice(AVAILABLE_DEV_ENVS),
     show_default=True,
     is_eager=True,
-    callback=option_env_type_callback,
+    callback=get_env_type,
     help="The type of developer environment",
 )

src/dda/cli/inv/__init__.py

@@ -48,7 +48,7 @@
     "--help",
     "show_help",
     is_flag=True,
-    help="Show this help message and exit",
+    help="Show this help message and exit.",
 )
 @click.pass_context
 def cmd(