Skip to content

Commit 00e11c5

Browse files
committed
Place baseline RC contract at scheduling boundary
- Document the shared RC filter where baseline and standard scheduling diverge, making the attribution flow explicit. Validation: bazel test --nocache_test_results //comp/networkpath/npcollector/impl:impl_test
1 parent 6c21596 commit 00e11c5

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

comp/networkpath/npcollector/impl/npcollector.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -241,9 +241,6 @@ func (s *npCollectorImpl) evaluateNetworkPathForConn(conn npmodel.NetworkPathCon
241241
return pathEvaluation{}
242242
}
243243

244-
// Baseline mode and Dynamic Remote Configuration are compatible and
245-
// independent: baseline controls snapshot ranking, while the effective
246-
// local-plus-RC filter controls admission and attribution for every mode.
247244
s.filterMutex.RLock()
248245
included, testConfigID, tags := s.filter.EvaluateWithTags(conn.Domain, conn.Dest.Addr())
249246
s.filterMutex.RUnlock()
@@ -326,6 +323,8 @@ func (s *npCollectorImpl) scheduleNetworkPathTests(origin payload.PathOrigin, co
326323
}
327324
for conn := range conns {
328325
connCount++
326+
// Baseline mode changes only post-filter ranking. All modes use the same
327+
// local-plus-RC filter, and any winning RC attribution is preserved below.
329328
evaluation := s.evaluateNetworkPathForConn(conn, origin, vpcSubnets)
330329
if !evaluation.shouldSchedule {
331330
s.logger.Tracef("Skipped connection: addr=%s, protocol=%s", conn.Dest, conn.Type)

0 commit comments

Comments
 (0)