host-profiler: remove app_key from symbol uploader config

SymbolUploader no longer needs an app key.

Author: nsavoire

cmd/host-profiler/docker-compose.yml

@@ -41,13 +41,10 @@ services:
       - agent-ipc:/etc/datadog-agent:ro
     secrets:
       - dd-api-key
-      - dd-app-key
 
 volumes:
   agent-ipc:
 
 secrets:
   dd-api-key:
     environment: DD_API_KEY
-  dd-app-key:
-    environment: DD_APP_KEY

comp/host-profiler/collector/impl/converters/converter_table_test.go

@@ -163,11 +163,6 @@ func TestConverterWithoutAgent(t *testing.T) {
 			provided: "no_agent/conv-nonstr-apikey/in.yaml",
 			expected: "no_agent/conv-nonstr-apikey/out.yaml",
 		},
-		{
-			name:     "converts-non-string-app-key",
-			provided: "no_agent/conv-nonstr-appkey/in.yaml",
-			expected: "no_agent/conv-nonstr-appkey/out.yaml",
-		},
 		{
 			name:     "adds-profiling-to-pipeline",
 			provided: "no_agent/add-prof-to-pipe/in.yaml",

comp/host-profiler/collector/impl/converters/converter_without_agent.go

@@ -53,7 +53,7 @@ type internalHealthMetricsPipelineResolution struct {
 //   - remove infraattributes processor from metrics processors pipeline
 //   - At least one otlp_http exporter with dd-api-key declared & used
 //   - Check if used otlp_http exporter has dd-api-key as string, if not string convert it, if not at all notify user
-//   - If profiling::symbol_uploader::enabled == true, convert api_key/app_key to strings in each endpoint
+//   - If profiling::symbol_uploader::enabled == true, convert api_key to string in each endpoint
 //   - If no profiling is used & configured, add minimal one with symbol_uploader: false
 //   - remove hpflare extensions
 type converterWithoutAgent struct{}
@@ -335,7 +335,7 @@ func (c *converterWithoutAgent) fixReceiversPipeline(conf confMap, receiverNames
 
 // checkProfilingReceiverConfig validates and normalizes a profiling receiver configuration.
 // It ensures that if symbol_uploader is enabled, symbol_endpoints is properly configured
-// and all api_key/app_key values are strings.
+// and all api_key values are strings.
 func (c *converterWithoutAgent) checkProfilingReceiverConfig(profiling confMap) error {
 	if isEnabled, ok := confmaputils.Get[bool](profiling, pathSymbolUploaderEnabled); !ok || !isEnabled {
 		return nil
@@ -354,7 +354,6 @@ func (c *converterWithoutAgent) checkProfilingReceiverConfig(profiling confMap)
 	for _, epAny := range endpoints {
 		if ep, ok := epAny.(confMap); ok {
 			ensureKeyStringValue(ep, fieldAPIKey)
-			ensureKeyStringValue(ep, fieldAppKey)
 		}
 	}
 	return nil

comp/host-profiler/collector/impl/converters/converters.go

@@ -74,7 +74,6 @@ const (
 	fieldDDOtelMetricConfig      = "dd-otel-metric-config"
 	fieldDDOtelMetricConfigValue = `{"resource_attributes_as_tags": true}`
 	fieldAPIKey                  = "api_key"
-	fieldAppKey                  = "app_key"
 )
 
 // OTEL config path prefixes

comp/host-profiler/collector/impl/converters/testdata/no_agent/conv-nonstr-apikey/in.yaml

@@ -4,7 +4,6 @@ receivers:
       enabled: true
       symbol_endpoints:
       - api_key: 12345
-        app_key: test-app-key
 service:
   pipelines:
     profiles:

comp/host-profiler/collector/impl/converters/testdata/no_agent/conv-nonstr-apikey/out.yaml

@@ -33,7 +33,6 @@ receivers:
             enabled: true
             symbol_endpoints:
                 - api_key: "12345"
-                  app_key: test-app-key
 service:
     pipelines:
         profiles:

comp/host-profiler/collector/impl/converters/testdata/no_agent/conv-nonstr-appkey/in.yaml

@@ -4,13 +4,11 @@ receivers:
       enabled: true
       symbol_endpoints:
       - api_key: 11111
-        app_key: 22222
   profiling/custom:
     symbol_uploader:
       enabled: true
       symbol_endpoints:
       - api_key: 33333
-        app_key: string-app
 service:
   pipelines:
     profiles:

comp/host-profiler/collector/impl/converters/testdata/no_agent/conv-nonstr-appkey/out.yaml

@@ -33,13 +33,11 @@ receivers:
             enabled: true
             symbol_endpoints:
                 - api_key: "11111"
-                  app_key: "22222"
     profiling/custom:
         symbol_uploader:
             enabled: true
             symbol_endpoints:
                 - api_key: "33333"
-                  app_key: string-app
 service:
     pipelines:
         profiles: