refactor(ndm): only provide the workloadbalancing module where the collector is built

The first pass mirrored haagent's twelve fx sites, but haagent is provided in several of them for
reasons unrelated to the collector, such as the haagent inventory metadata component. Only the
collector component depends on workloadbalancing, so the module belongs in the three graphs that
build it: the agent run subcommand, the cluster agent, and the cloudfoundry cluster agent. The other
nine either use the noop collector or never construct one.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: matthewleese

cmd/agent/subcommands/diagnose/BUILD.bazel

@@ -35,7 +35,6 @@ go_library(
         "//comp/healthplatform",
         "//comp/serializer/logscompression/fx",
         "//comp/serializer/metricscompression/fx",
-        "//comp/workloadbalancing/fx",
         "//pkg/config/helper",
         "//pkg/config/setup",
         "//pkg/process/util/containers",

cmd/agent/subcommands/diagnose/command.go

@@ -50,7 +50,6 @@ import (
 	healthplatform "github.com/DataDog/datadog-agent/comp/healthplatform"
 	logscompressorfx "github.com/DataDog/datadog-agent/comp/serializer/logscompression/fx"
 	metricscompressorfx "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/fx"
-	workloadbalancingfx "github.com/DataDog/datadog-agent/comp/workloadbalancing/fx"
 	pkgconfighelper "github.com/DataDog/datadog-agent/pkg/config/helper"
 	pkgconfigsetup "github.com/DataDog/datadog-agent/pkg/config/setup"
 	proccontainers "github.com/DataDog/datadog-agent/pkg/process/util/containers"
@@ -127,7 +126,6 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
 				}),
 				adfx.Module(),
 				haagentfx.Module(),
-				workloadbalancingfx.Module(),
 				healthplatform.Bundle(),
 				hostnameimpl.Module(),
 				logscompressorfx.Module(),

cmd/agent/subcommands/flare/BUILD.bazel

@@ -49,7 +49,6 @@ go_library(
         "//comp/metadata/resources/fx",
         "//comp/serializer/logscompression/fx",
         "//comp/serializer/metricscompression/fx",
-        "//comp/workloadbalancing/fx",
         "//pkg/config/helper",
         "//pkg/config/settings",
         "//pkg/config/setup",

cmd/agent/subcommands/flare/command.go

@@ -64,7 +64,6 @@ import (
 	resourcesfx "github.com/DataDog/datadog-agent/comp/metadata/resources/fx"
 	logscompressorfx "github.com/DataDog/datadog-agent/comp/serializer/logscompression/fx"
 	metricscompressorfx "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/fx"
-	workloadbalancingfx "github.com/DataDog/datadog-agent/comp/workloadbalancing/fx"
 	pkgconfighelper "github.com/DataDog/datadog-agent/pkg/config/helper"
 	"github.com/DataDog/datadog-agent/pkg/config/settings"
 	pkgconfigsetup "github.com/DataDog/datadog-agent/pkg/config/setup"
@@ -177,7 +176,6 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
 				core.Bundle(core.WithSecrets()),
 				hostnameimpl.Module(),
 				haagentfx.Module(),
-				workloadbalancingfx.Module(),
 				logscompressorfx.Module(),
 				metricscompressorfx.Module(),
 				diagnosefx.Module(),

cmd/agent/subcommands/jmx/BUILD.bazel

@@ -39,7 +39,6 @@ go_library(
         "//comp/healthplatform",
         "//comp/serializer/logscompression/fx",
         "//comp/serializer/metricscompression/fx",
-        "//comp/workloadbalancing/fx",
         "//pkg/cli/standalone",
         "//pkg/config/model",
         "//pkg/process/util/containers",

cmd/agent/subcommands/jmx/command.go

@@ -46,7 +46,6 @@ import (
 	healthplatform "github.com/DataDog/datadog-agent/comp/healthplatform"
 	logscompression "github.com/DataDog/datadog-agent/comp/serializer/logscompression/fx"
 	metricscompression "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/fx"
-	workloadbalancingfx "github.com/DataDog/datadog-agent/comp/workloadbalancing/fx"
 	"github.com/DataDog/datadog-agent/pkg/cli/standalone"
 	"github.com/DataDog/datadog-agent/pkg/config/model"
 	proccontainers "github.com/DataDog/datadog-agent/pkg/process/util/containers"
@@ -137,7 +136,6 @@ func Commands(globalParams *command.GlobalParams) []*cobra.Command {
 				proccontainers.InitSharedContainerProvider(wmeta, tagger, filterStore)
 			}),
 			haagentfx.Module(),
-			workloadbalancingfx.Module(),
 			logscompression.Module(),
 			metricscompression.Module(),
 			ipcfx.ModuleReadOnly(),

cmd/agent/subcommands/snmp/BUILD.bazel

@@ -28,7 +28,6 @@ go_library(
         "//comp/serializer/metricscompression/fx",
         "//comp/snmpscan/def",
         "//comp/snmpscan/fx",
-        "//comp/workloadbalancing/fx",
         "//pkg/networkdevice/metadata",
         "//pkg/snmp/analyzer",
         "//pkg/snmp/snmpparse",

cmd/agent/subcommands/snmp/command.go

@@ -40,7 +40,6 @@ import (
 	metricscompression "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/fx"
 	snmpscan "github.com/DataDog/datadog-agent/comp/snmpscan/def"
 	snmpscanfx "github.com/DataDog/datadog-agent/comp/snmpscan/fx"
-	workloadbalancingfx "github.com/DataDog/datadog-agent/comp/workloadbalancing/fx"
 	"github.com/DataDog/datadog-agent/pkg/networkdevice/metadata"
 	"github.com/DataDog/datadog-agent/pkg/snmp/analyzer"
 	"github.com/DataDog/datadog-agent/pkg/snmp/snmpparse"
@@ -127,7 +126,6 @@ With --analyze, the walk is matched against SNMP device profiles and a summary r
 				nooptagger.Module(),
 				eventplatformreceiverimpl.Module(),
 				haagentfx.Module(),
-				workloadbalancingfx.Module(),
 				metricscompression.Module(),
 				logscompression.Module(),
 				ipcfx.ModuleReadOnly(),
@@ -193,7 +191,6 @@ With --analyze, the walk is matched against SNMP device profiles and a summary r
 				nooptagger.Module(),
 				snmpscanfx.Module(),
 				haagentfx.Module(),
-				workloadbalancingfx.Module(),
 				metricscompression.Module(),
 				logscompression.Module(),
 				ipcfx.ModuleReadOnly(),

cmd/dogstatsd/subcommands/start/BUILD.bazel

@@ -51,7 +51,6 @@ go_library(
         "//comp/metadata/runner/fx",
         "//comp/serializer/logscompression/fx",
         "//comp/serializer/metricscompression/fx",
-        "//comp/workloadbalancing/fx",
         "//pkg/serializer",
         "//pkg/status/health",
         "//pkg/util/coredump",

cmd/dogstatsd/subcommands/start/command.go

@@ -61,7 +61,6 @@ import (
 	metadatarunnerfx "github.com/DataDog/datadog-agent/comp/metadata/runner/fx"
 	logscompressionfx "github.com/DataDog/datadog-agent/comp/serializer/logscompression/fx"
 	metricscompressionfx "github.com/DataDog/datadog-agent/comp/serializer/metricscompression/fx"
-	workloadbalancingfx "github.com/DataDog/datadog-agent/comp/workloadbalancing/fx"
 	"github.com/DataDog/datadog-agent/pkg/serializer"
 	"github.com/DataDog/datadog-agent/pkg/status/health"
 	"github.com/DataDog/datadog-agent/pkg/util/coredump"
@@ -179,7 +178,6 @@ func RunDogstatsdFct(cliParams *CLIParams, defaultConfPath string, defaultLogFil
 		}),
 		healthprobefx.Module(),
 		haagentfx.Module(),
-		workloadbalancingfx.Module(),
 	)
 }