Commit 546d907
authored
dyninst/module: reorder shutdown a tad (#43366)
### What does this PR do?
Shuts down the uploaders after we stop using them.
### Motivation
I didn't like seeing:
```
w 04:16:41.279027655 @/git/datadog-agent/pkg/dyninst/uploader/logs.go:155| closing a tagged uploader (logs:1) that is not in the factory: metadata={tags: "", entityID: "", containerID: ""}
```
Perhaps a better change would be to, well, notice that the factory is shut down and not emit such a warning, but it doesn't quite seem worth it.
### Describe how you validated your changes
Noticed improvements in the test output.
Co-authored-by: andrew.werner <andrew.werner@datadoghq.com>1 parent 70ee310 commit 546d907
1 file changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | 168 | | |
175 | 169 | | |
176 | 170 | | |
| |||
184 | 178 | | |
185 | 179 | | |
186 | 180 | | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
| |||
0 commit comments