You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .agents/skills/create-pr/SKILL.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -22,7 +22,7 @@ Create a pull request for the current branch following the Datadog Agent contrib
22
22
DEFAULT_BRANCH=$(git rev-parse --abbrev-ref origin/HEAD | sed 's|^origin/||')
23
23
codex review --base "$DEFAULT_BRANCH"
24
24
```
25
-
Show the review output to the user. If codex is not installed, skip this step silently.
25
+
`codex review` is an LLM-based review and can take several minutes — do not bound it with a short Bash `timeout`, and do not let it get killed mid-run. Run it with `run_in_background: true` and wait for completion (or pass a generous `timeout`, e.g. the Bash tool max of 600000ms). If it's still running when you check back, keep waiting rather than treating it as done or skipping it, up to that 10-minute ceiling — if it still hasn't finished by then, note that to the user and proceed without it rather than stalling PR creation indefinitely. Show the review output to the user. If codex is not installed, skip this step silently.
26
26
6.**Push the branch** to origin if needed
27
27
7.**Open the PR**: By default, open as **Draft** using `gh pr create --draft`. If `$ARGUMENTS` contains `--real`, open as a regular (non-draft) PR instead (omit the `--draft` flag). Remove `--real` from `$ARGUMENTS` before processing remaining arguments as labels.
28
28
8.**PR title**: Use [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) format, prefixed with the general area of change. Examples:
Copy file name to clipboardExpand all lines: .cursor/rules/go_module_bazel_migration.mdc
+3-3Lines changed: 3 additions & 3 deletions
Original file line number
Diff line number
Diff line change
@@ -18,7 +18,7 @@ alwaysApply: false
18
18
bazel test //path/to/module/...
19
19
```
20
20
21
-
4. **Verify `//...`** still works after migration — intermediate BUILD files that reference external repos for local modules trigger the `bazelify_go_work` / `go_deps` `@rules_go` visibility bug.
21
+
4. **Verify `//...`** still works after migration.
22
22
23
23
## Custom `//go:build` tags and `_GAZELLE_BUILD_TAGS`
24
24
@@ -62,8 +62,8 @@ Proto source-only trees (`pkg/proto/datadog`, `pkg/proto/protodep`) still need `
62
62
63
63
## `gazelle:ignore` vs `gazelle:exclude`
64
64
65
-
- `gazelle:exclude` — stops Gazelle AND affects `bazelify_go_work` filtering of `go.work` entries for `go_deps`.
66
-
- `gazelle:ignore` — only stops Gazelle from generating/updating targets in that directory. Safe for stub BUILD files at intermediate unmigrated packages.
65
+
- `gazelle:exclude <pattern>` — a directory match stops Gazelle from recursing into it, whereas a file match excludes it from managed rules,
66
+
- `gazelle:ignore` — stops Gazelle from modifying its containing BUILD.bazel file.
67
67
68
68
## Known issue: `go_deps` external repo `@rules_go` visibility
0 commit comments