Skip to content

Commit 645110a

Browse files
authored
Keep injected redacted_compat.h file out of the windows python's build inputs (#54783)
### What does this PR do? It removes the `redacted_compat.h` file out of the sources for the Python build on Windows, such that it doesn't get used for cache computation. ### Motivation I didn't get remote cache hits on a local checkout with git core.autocrlf disabled (see also #54776) due to this specific file. Since the file is only intended for the `configure_make` rule that builds Python on Linux / macOS, we can simply remove the file from inputs to mitigate the problem (regardless of whether we go with #54776 or any other similar more general solution). ### Describe how you validated your changes CI. ### Additional Notes Due to the lack of windows sandboxing, the excluded sources for the rule are actually visible to the build action, so there's no guarantee that it doesn't get used by it. However, given that it's a file that we introduce ourselves and not looked at by Python's build system, it's fairly safe to assume that in practice this file doesn't cause any difference to the build outputs. Co-authored-by: alex.lopez <alex.lopez@datadoghq.com>
1 parent e239027 commit 645110a

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

deps/cpython.BUILD.bazel

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,13 @@ run_binary(
5555
srcs = (
5656
glob(
5757
["**"],
58-
exclude = ["**/*.pyc", "BUILD.bazel"],
58+
exclude = [
59+
"**/*.pyc",
60+
"BUILD.bazel",
61+
# Unix-only build helper injected into the CPython repository.
62+
# Keep it out of the Windows action key; the Windows build does not use it.
63+
"redacted_compat.h",
64+
],
5965
) + [
6066
"bzip2_win_dir",
6167
"mpdecimal_win_dir",

0 commit comments

Comments
 (0)