Skip to content

Commit 8525a1e

Browse files
committed
Clarify baseline scheduling mode
1 parent c650133 commit 8525a1e

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

comp/networkpath/npcollector/impl/npcollector.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -290,8 +290,8 @@ func (s *npCollectorImpl) ScheduleNetworkPathTests(conns iter.Seq[npmodel.Networ
290290
return
291291
}
292292

293-
baseline := !s.collectorConfigs.connectionsMonitoringEnabled
294-
s.scheduleNetworkPathTests(payload.PathOriginNetworkTraffic, conns, baseline)
293+
baselineMode := !s.collectorConfigs.connectionsMonitoringEnabled
294+
s.scheduleNetworkPathTests(payload.PathOriginNetworkTraffic, conns, baselineMode)
295295
}
296296

297297
func (s *npCollectorImpl) ScheduleNetflowPathTests(conns iter.Seq[npmodel.NetworkPathConnection]) {
@@ -301,7 +301,7 @@ func (s *npCollectorImpl) ScheduleNetflowPathTests(conns iter.Seq[npmodel.Networ
301301
s.scheduleNetworkPathTests(payload.PathOriginNetflow, conns, false)
302302
}
303303

304-
func (s *npCollectorImpl) scheduleNetworkPathTests(origin payload.PathOrigin, conns iter.Seq[npmodel.NetworkPathConnection], baseline bool) {
304+
func (s *npCollectorImpl) scheduleNetworkPathTests(origin payload.PathOrigin, conns iter.Seq[npmodel.NetworkPathConnection], baselineMode bool) {
305305
var vpcSubnets []netip.Prefix
306306
if origin == payload.PathOriginNetworkTraffic {
307307
var err error
@@ -318,7 +318,7 @@ func (s *npCollectorImpl) scheduleNetworkPathTests(origin payload.PathOrigin, co
318318
// addBaselinePath keeps this list unique, best-first, and capped at
319319
// baselineSelectionsPerSnapshot; it remains nil in standard mode.
320320
var selectedBaselineCandidates []baselineCandidate
321-
if baseline {
321+
if baselineMode {
322322
selectedBaselineCandidates = make([]baselineCandidate, 0, baselineSelectionsPerSnapshot)
323323
}
324324
for conn := range conns {
@@ -329,7 +329,7 @@ func (s *npCollectorImpl) scheduleNetworkPathTests(origin payload.PathOrigin, co
329329
continue
330330
}
331331
pathtest := s.makePathtest(conn, origin)
332-
if baseline {
332+
if baselineMode {
333333
selectedBaselineCandidates = addBaselinePath(selectedBaselineCandidates, pathtest, conn.Baseline)
334334
continue
335335
}
@@ -338,7 +338,7 @@ func (s *npCollectorImpl) scheduleNetworkPathTests(origin payload.PathOrigin, co
338338
s.logger.Errorf("Error scheduling pathtests: %s", err)
339339
}
340340
}
341-
if baseline {
341+
if baselineMode {
342342
s.scheduleBaselinePaths(selectedBaselineCandidates)
343343
}
344344
_ = s.statsdClient.Count(common.NetworkPathCollectorMetricPrefix+"schedule.conns_received", int64(connCount), []string{}, 1)

0 commit comments

Comments
 (0)