For PAR config settings, declare using strings not const (#53767)

### What does this PR do?

Cleanup how privateactionrunner declares settings: use literal strings for each setting name, instead of a constant.

### Motivation

Two primary reasons: 1) Make it easier for the code analyzer to find these settings, and 2) make an easier codegen target.

### Describe how you validated your changes

Built the agent + CI

### Additional Notes

Running the codegen via `dda inv schema.codegen` is dependent on [`a020191` (#53765)](a020191) in order to work correctly.


Co-authored-by: dustin.long <dustin.long@datadoghq.com>

Author: dustmop

pkg/config/schema/yaml/private_action_runner.yaml

@@ -18,6 +18,7 @@ properties:
     visibility: public
     description: Set to true to enable the Private Action Runner.
     example: 'true'
+    comment: Enable/disable private action runner
   self_enroll:
     node_type: setting
     type: boolean
@@ -28,12 +29,14 @@ properties:
       Requires an app_key with Actions API Enable and the following permissions:
         - Connection Write
         - Private Action Write
+    comment: Identity / enrollment configuration
   task_concurrency:
     node_type: setting
     type: integer
     default: 5
     visibility: public
     description: Maximum number of actions that can be executed concurrently.
+    comment: General config
   task_timeout_seconds:
     node_type: setting
     type: integer
@@ -73,6 +76,7 @@ properties:
     visibility: public
     description: Maximum time in seconds for HTTP actions before timing out. Must
       be > 1.
+    comment: HTTP action
   http_allowlist:
     node_type: setting
     type: array
@@ -118,6 +122,7 @@ properties:
     node_type: setting
     type: string
     default: ${log_path}/private-action-runner.log
+    comment: Log file
   opms_extra_headers:
     node_type: setting
     type: object
@@ -146,6 +151,20 @@ properties:
         - /
         items:
           type: string
+        comment: |-
+          Restricted shell allow-lists are opt-in restrictions layered on top of
+          the backend-injected lists. By default, they act as a no-op, allowing
+          everything: the backend is the only filter.
+
+          To allow none, use an explicit empty list.
+          Env vars support both CSV and JSON-array forms; the JSON form gives
+          env/YAML parity, including the explicit kill-switch via "[]".
+
+          - allowed_paths defaults to ["/"].
+          - allowed_commands defaults to ["rshell:*"]. The wildcard token is
+          handled as a special case in the operator-side intersection: when
+          it appears in the operator list, every backend command in the
+          "rshell:" namespace is admitted.
   skip_connection_creation:
     node_type: setting
     type: boolean

pkg/config/setup/privateactionrunner_settings.go

@@ -13,27 +13,27 @@ import (
 // setupPrivateActionRunner registers all configuration keys for the private action runner
 func setupPrivateActionRunner(config pkgconfigmodel.Setup) {
 	// Enable/disable private action runner
-	config.BindEnvAndSetDefault(PAREnabled, false)
+	config.BindEnvAndSetDefault("private_action_runner.enabled", false)
 
 	// Log file
-	config.BindEnvAndSetDefault(PARLogFile, "${log_path}/private-action-runner.log")
+	config.BindEnvAndSetDefault("private_action_runner.log_file", "${log_path}/private-action-runner.log")
 
 	// Identity / enrollment configuration
-	config.BindEnvAndSetDefault(PARSelfEnroll, true)
-	config.BindEnvAndSetDefault(PARApiKeyOnlyEnrollment, false)
-	config.BindEnvAndSetDefault(PARIdentityFilePath, "")
-	config.BindEnvAndSetDefault(PARIdentityUseK8sSecret, true)
-	config.BindEnvAndSetDefault(PARIdentitySecretName, "private-action-runner-identity")
-	config.BindEnvAndSetDefault(PARPrivateKey, "")
-	config.BindEnvAndSetDefault(PARUrn, "")
-	config.BindEnvAndSetDefault(PARSkipConnectionCreation, false)
+	config.BindEnvAndSetDefault("private_action_runner.self_enroll", true)
+	config.BindEnvAndSetDefault("private_action_runner.api_key_only_enrollment", false)
+	config.BindEnvAndSetDefault("private_action_runner.identity_file_path", "")
+	config.BindEnvAndSetDefault("private_action_runner.identity_use_k8s_secret", true)
+	config.BindEnvAndSetDefault("private_action_runner.identity_secret_name", "private-action-runner-identity")
+	config.BindEnvAndSetDefault("private_action_runner.private_key", "")
+	config.BindEnvAndSetDefault("private_action_runner.urn", "")
+	config.BindEnvAndSetDefault("private_action_runner.skip_connection_creation", false)
 
 	// General config
-	config.BindEnvAndSetDefault(PARTaskConcurrency, 5)
-	config.BindEnvAndSetDefault(PARTaskTimeoutSeconds, 60)
-	config.BindEnvAndSetDefault(PARActionsAllowlist, []string{})
-	config.BindEnvAndSetDefault(PARDefaultActionsEnabled, true)
-	config.ParseEnvSplitComma(PARActionsAllowlist)
+	config.BindEnvAndSetDefault("private_action_runner.task_concurrency", 5)
+	config.BindEnvAndSetDefault("private_action_runner.task_timeout_seconds", 60)
+	config.BindEnvAndSetDefault("private_action_runner.actions_allowlist", []string{})
+	config.BindEnvAndSetDefault("private_action_runner.default_actions_enabled", true)
+	config.ParseEnvSplitComma("private_action_runner.actions_allowlist")
 
 	// Executor mode (split deployment)
 	config.BindEnvAndSetDefault(PARExecutorSocketPath, GetPlatformDefault(map[string]interface{}{
@@ -42,10 +42,10 @@ func setupPrivateActionRunner(config pkgconfigmodel.Setup) {
 	}))
 
 	// HTTP action
-	config.BindEnvAndSetDefault(PARHttpTimeoutSeconds, 30)
-	config.BindEnvAndSetDefault(PARHttpAllowlist, []string{})
-	config.ParseEnvSplitComma(PARHttpAllowlist)
-	config.BindEnvAndSetDefault(PARHttpAllowImdsEndpoint, false)
+	config.BindEnvAndSetDefault("private_action_runner.http_timeout_seconds", 30)
+	config.BindEnvAndSetDefault("private_action_runner.http_allowlist", []string{})
+	config.ParseEnvSplitComma("private_action_runner.http_allowlist")
+	config.BindEnvAndSetDefault("private_action_runner.http_allow_imds_endpoint", false)
 
 	// Restricted shell allow-lists are opt-in restrictions layered on top of
 	// the backend-injected lists. By default, they act as a no-op, allowing
@@ -60,11 +60,11 @@ func setupPrivateActionRunner(config pkgconfigmodel.Setup) {
 	//     handled as a special case in the operator-side intersection: when
 	//     it appears in the operator list, every backend command in the
 	//     "rshell:" namespace is admitted.
-	config.BindEnvAndSetDefault(PARRestrictedShellAllowedPaths, []string{RShellPathAllowAll})
-	pkgconfighelper.ParseEnvJSONOrComma(PARRestrictedShellAllowedPaths, config)
+	config.BindEnvAndSetDefault("private_action_runner.restricted_shell.allowed_paths", []string{RShellPathAllowAll})
+	pkgconfighelper.ParseEnvJSONOrComma("private_action_runner.restricted_shell.allowed_paths", config)
 
-	config.BindEnvAndSetDefault(PARRestrictedShellAllowedCommands, []string{RShellCommandAllowAllWildcard})
-	pkgconfighelper.ParseEnvJSONOrComma(PARRestrictedShellAllowedCommands, config)
+	config.BindEnvAndSetDefault("private_action_runner.restricted_shell.allowed_commands", []string{RShellCommandAllowAllWildcard})
+	pkgconfighelper.ParseEnvJSONOrComma("private_action_runner.restricted_shell.allowed_commands", config)
 
-	config.BindEnvAndSetDefault(PAROpmsExtraHeaders, map[string]string{})
+	config.BindEnvAndSetDefault("private_action_runner.opms_extra_headers", map[string]string{})
 }