[ACTP] drop redundant log redaction test

The recordingLogger fake implemented the whole log.Component surface for a
single test whose only exercised log line is a constant string, so it could
not detect a private-key leak. Key redaction is still covered by the invalid
configured private key case, which asserts the error does not echo the key.

Author: embeaken

cmd/privateactionrunner/subcommands/ensureenrollment/command_test.go

@@ -11,10 +11,8 @@ import (
 	"context"
 	"encoding/base64"
 	"encoding/json"
-	"fmt"
 	"os"
 	"path/filepath"
-	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -141,22 +139,6 @@ func TestEnsureEnrollmentConfiguredIdentity(t *testing.T) {
 	})
 }
 
-func TestEnsureEnrollmentOutputDoesNotContainPrivateKey(t *testing.T) {
-	privateKey := validPrivateKey(t)
-	cfg := testConfig(t, filepath.Join(t.TempDir(), "missing.json"), map[string]interface{}{
-		"private_action_runner.self_enroll": false,
-		"private_action_runner.urn":         validURN(),
-		"private_action_runner.private_key": privateKey,
-	})
-	hostnameComp, _ := hostnamemock.NewMock("test-host")
-	logger := &recordingLogger{}
-
-	err := ensureEnrollment(context.Background(), logger, cfg, hostnameComp, failIfEnrolled(t))
-
-	require.NoError(t, err)
-	assert.NotContains(t, logger.String(), privateKey)
-}
-
 func TestEnsureEnrollmentFailures(t *testing.T) {
 	t.Run("self enrollment disabled", func(t *testing.T) {
 		cfg := testConfig(t, filepath.Join(t.TempDir(), "missing.json"), map[string]interface{}{
@@ -249,39 +231,3 @@ func failIfEnrolled(t *testing.T) enrollAndPersistFunc {
 		return nil, nil
 	}
 }
-
-type recordingLogger struct {
-	messages []string
-}
-
-func (l *recordingLogger) add(v ...interface{})                 { l.messages = append(l.messages, fmt.Sprint(v...)) }
-func (l *recordingLogger) addf(format string, v ...interface{}) { l.add(fmt.Sprintf(format, v...)) }
-func (l *recordingLogger) Trace(v ...interface{})               { l.add(v...) }
-func (l *recordingLogger) Tracef(format string, v ...interface{}) {
-	l.addf(format, v...)
-}
-func (l *recordingLogger) Debug(v ...interface{}) { l.add(v...) }
-func (l *recordingLogger) Debugf(format string, v ...interface{}) {
-	l.addf(format, v...)
-}
-func (l *recordingLogger) Info(v ...interface{}) { l.add(v...) }
-func (l *recordingLogger) Infof(format string, v ...interface{}) {
-	l.addf(format, v...)
-}
-func (l *recordingLogger) Warn(v ...interface{}) error { l.add(v...); return nil }
-func (l *recordingLogger) Warnf(format string, v ...interface{}) error {
-	l.addf(format, v...)
-	return nil
-}
-func (l *recordingLogger) Error(v ...interface{}) error { l.add(v...); return nil }
-func (l *recordingLogger) Errorf(format string, v ...interface{}) error {
-	l.addf(format, v...)
-	return nil
-}
-func (l *recordingLogger) Critical(v ...interface{}) error { l.add(v...); return nil }
-func (l *recordingLogger) Criticalf(format string, v ...interface{}) error {
-	l.addf(format, v...)
-	return nil
-}
-func (l *recordingLogger) Flush()         {}
-func (l *recordingLogger) String() string { return strings.Join(l.messages, "\n") }