Commit c87f5dc
authored
host-profiler: default UID/GID build args to workspace ids (#54353)
### What does this PR do?
Provides default values for the `UID`/`GID` build args in the host-profiler dev `docker-compose.yml`, and documents them as optional in the README.
### Motivation
`UID` and `GID` are shell variables that are not exported by default, so `${UID}`/`${GID}` expanded to empty strings unless the user explicitly exported them, breaking `docker compose build`.
They now default to `2000:501`, the default user/group ids in Datadog workspaces. These also work on setups with uid-squashed mounts (colima/virtiofs), where the container uid is irrelevant.
### Describe how you validated your changes
Manually built the host-profiler image with `docker compose build` without exporting `UID`/`GID`.
### Additional Notes
Dev-tooling only change, no impact on shipped artifacts.
Co-authored-by: nicolas.savoire <nicolas.savoire@datadoghq.com>1 parent f398881 commit c87f5dc
2 files changed
Lines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
66 | | - | |
| 65 | + | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
0 commit comments