Skip to content

Commit e6c36e0

Browse files
jszwedkoclaude
andcommitted
Use agent-build/agent-devx teams in EXCEPTION_APPROVERS
Keeps the runtime exception-approver check consistent with the CODEOWNERS entry for the limits file, which already uses agent-build and agent-devx since agent-supply-chain has no Slack channel mapping. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 868c05b commit e6c36e0

3 files changed

Lines changed: 10 additions & 8 deletions

File tree

.github/chainguard/self.gitlab.static-quality-gates.sts.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@ claim_pattern:
88
ref: ".+"
99

1010
# Used by the static_quality_gates job to comment on PRs and to check whether
11-
# an approving reviewer is a member of @DataDog/agent-supply-chain, which
12-
# grants an exception to the per-PR size threshold.
11+
# an approving reviewer is a member of one of the teams in EXCEPTION_APPROVERS
12+
# (tasks/static_quality_gates/decisions.py), which grants an exception to the
13+
# per-PR size threshold.
1314
permissions:
1415
contents: read
1516
pull_requests: write

tasks/static_quality_gates/decisions.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,12 @@
2424
}
2525
# Individuals or teams allowed to grant per-PR size threshold exceptions.
2626
# Entries are either plain GitHub usernames (e.g. "cmourot") or team references
27-
# in the form "Org/team-slug" (e.g. "DataDog/agent-supply-chain"), which are
28-
# expanded to their current membership at check time.
27+
# in the form "Org/team-slug" (e.g. "DataDog/agent-build"), which are expanded
28+
# to their current membership at check time.
2929
EXCEPTION_APPROVERS = {
3030
"cmourot",
31-
"DataDog/agent-supply-chain",
31+
"DataDog/agent-build",
32+
"DataDog/agent-devx",
3233
}
3334

3435

tasks/unit_tests/static_quality_gates/decisions_tests.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -302,17 +302,17 @@ def test_expands_team_reference_with_correct_slug(self):
302302
mock_pr.get_reviews.return_value = [mock_review]
303303

304304
fetcher = MagicMock(return_value={"someone"})
305-
with patch("tasks.static_quality_gates.decisions.EXCEPTION_APPROVERS", {"DataDog/agent-supply-chain"}):
305+
with patch("tasks.static_quality_gates.decisions.EXCEPTION_APPROVERS", {"DataDog/agent-build"}):
306306
checker = ExceptionApprovalChecker(mock_pr, team_members_fetcher=fetcher)
307307
self.assertEqual(checker.get(), "someone")
308-
fetcher.assert_called_once_with("agent-supply-chain")
308+
fetcher.assert_called_once_with("agent-build")
309309

310310
def test_mixed_list_combines_plain_usernames_and_team_members(self):
311311
"""A list mixing plain usernames and a team reference authorizes members of both."""
312312
fetcher = MagicMock(return_value={"alopezz"})
313313
with patch(
314314
"tasks.static_quality_gates.decisions.EXCEPTION_APPROVERS",
315-
{"cmourot", "DataDog/agent-supply-chain"},
315+
{"cmourot", "DataDog/agent-build"},
316316
):
317317
for approver in ("cmourot", "alopezz"):
318318
with self.subTest(approver=approver):

0 commit comments

Comments
 (0)