refactor(procmgr): colocate startup order helper with ProcessManager

Move recompute_startup_order into process_manager.rs since only
ProcessManager uses it; mod.rs keeps cross-module spawn/reload helpers.

Author: jose-manuel-almaza

pkg/procmgr/rust/src/manager/mod.rs

@@ -12,10 +12,9 @@ mod supervisor;
 use supervisor::RuntimeHandles;
 
 use crate::config::ProcessDefinition;
-use crate::ordering;
 use crate::process::ManagedProcess;
 use anyhow::Result;
-use log::{debug, warn};
+use log::warn;
 use std::sync::Arc;
 use tokio::sync::mpsc;
 use tonic::Status;
@@ -123,34 +122,6 @@ fn spawn_watcher(proc: &mut ManagedProcess, tx: mpsc::Sender<ExitEvent>) {
     }
 }
 
-struct StartupOrderResult {
-    order: Vec<usize>,
-    warnings: Vec<String>,
-}
-
-fn recompute_startup_order(procs: &[ManagedProcess]) -> StartupOrderResult {
-    let defs: Vec<ProcessDefinition> = procs
-        .iter()
-        .map(|p| ProcessDefinition {
-            name: p.name().to_string(),
-            config: p.config().clone(),
-        })
-        .collect();
-    let result = ordering::resolve_order(&defs);
-    if !result.skipped.is_empty() {
-        warn!(
-            "dependency cycle detected, skipping processes: {}",
-            result.skipped.join(", ")
-        );
-    }
-    let names: Vec<&str> = result.order.iter().map(|&i| procs[i].name()).collect();
-    debug!("startup order: {}", names.join(" -> "));
-    StartupOrderResult {
-        order: result.order,
-        warnings: result.warnings,
-    }
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;

pkg/procmgr/rust/src/manager/process_manager.rs

@@ -1,9 +1,10 @@
 use super::{
     ExitEvent, PendingRestart, RuntimeHandles, Supervisor, find_index_by_name, queue_restart,
-    recompute_startup_order, resolve_index, try_spawn_and_watch,
+    resolve_index, try_spawn_and_watch,
 };
 use crate::command::{CreateResult, StartResult, StopResult};
-use crate::config::{self, ConfigLoader};
+use crate::config::{self, ConfigLoader, ProcessDefinition};
+use crate::ordering;
 use crate::process::ManagedProcess;
 use crate::shutdown;
 use crate::uuid_gen::UuidGenerator;
@@ -242,3 +243,31 @@ impl ProcessManager {
         shutdown::shutdown_ordered(&mut procs, &order).await;
     }
 }
+
+struct StartupOrderResult {
+    order: Vec<usize>,
+    warnings: Vec<String>,
+}
+
+fn recompute_startup_order(procs: &[ManagedProcess]) -> StartupOrderResult {
+    let defs: Vec<ProcessDefinition> = procs
+        .iter()
+        .map(|p| ProcessDefinition {
+            name: p.name().to_string(),
+            config: p.config().clone(),
+        })
+        .collect();
+    let result = ordering::resolve_order(&defs);
+    if !result.skipped.is_empty() {
+        warn!(
+            "dependency cycle detected, skipping processes: {}",
+            result.skipped.join(", ")
+        );
+    }
+    let names: Vec<&str> = result.order.iter().map(|&i| procs[i].name()).collect();
+    debug!("startup order: {}", names.join(" -> "));
+    StartupOrderResult {
+        order: result.order,
+        warnings: result.warnings,
+    }
+}