Refactor /comp/core/telem to follow components v2 patterns - #42069
Closed
scottopell wants to merge 17 commits into
Closed
Refactor /comp/core/telem to follow components v2 patterns#42069scottopell wants to merge 17 commits into
scottopell wants to merge 17 commits into
Conversation
…nsumers This refactoring moves telemetry to a def/impl/impl-noop/fx structure to enable clean separation between interface definitions (no prometheus) and implementations, allowing third-party consumers of pkg/trace to avoid the prometheus dependency tree. Cascading updates to all comp/core modules to use new telemetry/def.
Added missing import for telemetry/def to fix undefined references.
Changed createAtel parameter from telemetry.Component to telemetryimpl.Component to match the actual dependencies.
Changed from telemetry.MetricFamily to dto.MetricFamily.
github-actions
Bot
added
component/system-probe
team/agent-runtimes
long review
scottopell
added
changelog/no-changelog
Contributor
Go Package Import DifferencesBaseline: 6d8fc84
|
agagniere
requested changes
Oct 17, 2025
agagniere
left a comment
agagniere
left a comment
Contributor
There was a problem hiding this comment.
It seems several imports were renamed but the code using them wasn't
| package infraattributesprocessor | ||
|
|
||
| import ( | ||
| "github.com/DataDog/datadog-agent/comp/core/telemetry/noopsimpl" |
Contributor
There was a problem hiding this comment.
could be named telemetry-noop-impl or telemetry-impl-noop because the current file is outside temlemetry.
More importantly, you forgot to rename it when using it (line 16)
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/DataDog/datadog-agent/comp/core/telemetry" |
Contributor
There was a problem hiding this comment.
could be called telemetry-def, and don't forget to rename it on uses e.g. line 87
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/DataDog/datadog-agent/comp/core/telemetry" |
Contributor
There was a problem hiding this comment.
Same comment, telemetry-def and rename it when using it (e.g. line 57)
Contributor
|
This pull request has been automatically marked as stale because it has not had activity in the past 15 days. It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window. Thank you for your contributions! |
gh-worker-devtools-f43747
Bot
deleted the
sopell-refactor/telemetry-multimodule
branch
April 22, 2026 03:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor comp/core/telemetry to multi-module architecture + update consumers
Motivation
Instrumenting trace-agent with prometheus needed a way to use the
telemetrycomponent without causing any importers of
pkg/traceto pull in the prometheusgolang client library.
Describe how you validated your changes
Pending, did basic evals locally, will expand this section.
Additional Notes
Trace-agent instrumentation will be done in subsequent PR