Skip to content

[WP] Add metric for dropped packets - #52965

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
theop-dd/add-metric-dropped-acket
Jul 24, 2026
Merged

[WP] Add metric for dropped packets#52965
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
mainfrom
theop-dd/add-metric-dropped-acket

Conversation

@theop-dd

@theop-dd theop-dd commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a per-rule metric to track how many packets are dropped by WP network isolation rules (network_filter with drop action).

When a packet matches a drop filter in the eBPF TC program, the filter increments a kernel-side BPF map directly. A new user-space monitor reads that map periodically and emits deltas to StatsD, tagged by rule_id.

Changes
Kernel (eBPF):

  • Added a new BPF PER_CPU_ARRAY_MAP dropped_packets to store drop counters keyed by filter index.
  • Extended raw packet drop filter compilation (FilterToInsts) so that matching drop filters increment the map in-kernel.
  • Added WithDropStatsMapFd to ProgOpts to wire the map into generated programs.

User-space:
Added a rawpacketdrop monitor that:

  • Iterates the dropped_packets map on each stats tick.
  • Maps filter indices back to rule_id via a maintained index-to-rule mapping.
  • Emits count deltas to StatsD.
  • Clears the map when drop action filters are reapplied (e.g. on ruleset reload).
  • Integrated the monitor into the existing probe stats pipeline.

New metric: datadog.runtime_security.network.raw_packet.dropped
Tag: rule_id:<rule_id>

Motivation

When a client applies network isolation via WP rules, there is currently no visibility into how many packets are being blocked. This metric provides feedback on the impact of each isolation rule, making it easier to validate that rules are working as expected and to detect unexpected traffic being filtered.

Describe how you validated your changes

  • Added eBPF unit test (TestRawPacketDropAction) verifying that drop stats are incremented in the dropped_packets map when WithDropStatsMapFd is enabled.

  • Extended TestRawPacketAction integration test to assert the new metric is emitted with the correct rule_id tag.

  • Manually validated with a local setup: confirmed the metric appears in StatsD when packets are dropped by a network isolation rule.

@theop-dd theop-dd added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests and removed component/system-probe labels Jun 30, 2026
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Jun 30, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Jun 30, 2026
chatgpt-codex-connector[bot]

This comment was marked as outdated.

@dd-octo-sts

dd-octo-sts Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Go Package Import Differences

Baseline: 9a7613a
Comparison: 258ee91

binaryosarchchange
system-probelinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/security/probe/monitors/rawpacketdrop
system-probelinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/security/probe/monitors/rawpacketdrop

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 0.00%
Overall Coverage: 52.07% (+0.12%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 258ee91 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 9a7613aa:

Results for datadog-agent_7.83.0~devel.git.342.258ee91.pipeline.126560303-1_amd64.deb:

No change detected

@theop-dd
theop-dd force-pushed the theop-dd/add-metric-dropped-acket branch from d4a59f5 to dcd9e29 Compare June 30, 2026 09:15
@dd-octo-sts

dd-octo-sts Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 9a7613a
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +20.3 KiB (0.00% increase, -0.27% of buffer) 750.817 → 750.837 → 758.200
agent_deb_amd64_fips +20.3 KiB (0.00% increase, -0.40% of buffer) 705.605 → 705.625 → 710.520
agent_rpm_amd64 +20.3 KiB (0.00% increase, -0.27% of buffer) 750.801 → 750.821 → 758.170
agent_rpm_amd64_fips +20.3 KiB (0.00% increase, -0.40% of buffer) 705.589 → 705.609 → 710.520
agent_rpm_arm64 +16.29 KiB (0.00% increase, -0.73% of buffer) 727.480 → 727.496 → 729.660
agent_rpm_arm64_fips +16.29 KiB (0.00% increase, -0.45% of buffer) 685.399 → 685.415 → 688.910
agent_suse_amd64 +20.3 KiB (0.00% increase, -0.27% of buffer) 750.801 → 750.821 → 758.170
agent_suse_amd64_fips +20.3 KiB (0.00% increase, -0.40% of buffer) 705.589 → 705.609 → 710.520
agent_suse_arm64 +16.29 KiB (0.00% increase, -0.73% of buffer) 727.480 → 727.496 → 729.660
agent_suse_arm64_fips +16.29 KiB (0.00% increase, -0.45% of buffer) 685.399 → 685.415 → 688.910
docker_agent_amd64 +20.29 KiB (0.00% increase, -0.46% of buffer) 809.494 → 809.513 → 813.790
docker_agent_arm64 +16.28 KiB (0.00% increase, -0.42% of buffer) 811.208 → 811.224 → 815.030
docker_agent_jmx_amd64 +20.29 KiB (0.00% increase, -0.48% of buffer) 1000.391 → 1000.411 → 1004.550
docker_agent_jmx_arm64 +16.3 KiB (0.00% increase, -0.40% of buffer) 990.758 → 990.774 → 994.710
19 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_heroku_amd64 307.506 MiB
agent_msi 639.378 MiB
docker_cluster_agent_amd64 209.851 MiB
docker_cluster_agent_arm64 222.890 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.228 MiB
docker_dogstatsd_arm64 37.368 MiB
docker_host_profiler_amd64 303.856 MiB
docker_host_profiler_arm64 315.307 MiB
dogstatsd_deb_amd64 29.969 MiB
dogstatsd_deb_arm64 28.012 MiB
dogstatsd_rpm_amd64 29.969 MiB
dogstatsd_suse_amd64 29.969 MiB
iot_agent_deb_amd64 46.142 MiB
iot_agent_deb_arm64 42.833 MiB
iot_agent_deb_armhf 43.602 MiB
iot_agent_rpm_amd64 46.143 MiB
iot_agent_suse_amd64 46.141 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jun 30, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d23ed225-515a-40ab-906d-a95aba429710

Baseline: 117e85b
Comparison: 0dd17eb
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +1.49 [+1.24, +1.74] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization +1.04 [+0.03, +2.05] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.33 [+0.27, +0.38] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.24 [+0.19, +0.29] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.12 [+0.02, +0.21] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.07 [+0.02, +0.11] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization -0.05 [-0.09, -0.01] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization -0.19 [-0.32, -0.07] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 150.35MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 729.20KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 500.28MiB ≤ 512MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 187.81MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.14MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 373.99 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 410.83MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.93GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 71.00MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 28.46 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 304.41MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 62.18 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 284.19MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 26.42 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 285.20MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs baseline 10 Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_idle comparison 10 Oom killed Debug Dashboard
quality_gate_security_no_fs_load baseline 10 Oom killed Debug Dashboard
quality_gate_security_no_fs_load comparison 10 Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@theop-dd
theop-dd force-pushed the theop-dd/add-metric-dropped-acket branch from dcd9e29 to f92e16f Compare July 1, 2026 12:01
@github-actions github-actions Bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jul 1, 2026
@theop-dd
theop-dd force-pushed the theop-dd/add-metric-dropped-acket branch from f92e16f to 6169518 Compare July 1, 2026 15:34
@theop-dd
theop-dd marked this pull request as ready for review July 1, 2026 15:38
@theop-dd
theop-dd requested review from a team as code owners July 1, 2026 15:38
@theop-dd
theop-dd force-pushed the theop-dd/add-metric-dropped-acket branch 5 times, most recently from c656338 to 1411f15 Compare July 6, 2026 14:39
@theop-dd
theop-dd force-pushed the theop-dd/add-metric-dropped-acket branch 4 times, most recently from a814c2a to 8bd79e9 Compare July 16, 2026 08:10
@theop-dd
theop-dd force-pushed the theop-dd/add-metric-dropped-acket branch 4 times, most recently from 9ae707a to 377de99 Compare July 21, 2026 09:00
@theop-dd
theop-dd force-pushed the theop-dd/add-metric-dropped-acket branch from 25b08c0 to 258ee91 Compare July 23, 2026 15:23
@pr-shepherd-6ad11f

Copy link
Copy Markdown

PR Shepherd is now watching this PR: fixing basic CI failures, rebasing when it falls behind, and re-queueing after transient merge-queue failures. To disable it, add the pr-shepherd:ignore label.

If you have any questions, reach the team in #ai-devx-flow.

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 0dd17eb into main Jul 24, 2026
462 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the theop-dd/add-metric-dropped-acket branch July 24, 2026 10:08
@github-actions github-actions Bot added this to the 7.83.0 milestone Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed component/system-probe internal Identify a non-fork PR long review PR is complex, plan time to review it pr-shepherd:in_progress qa/done QA done before merge and regressions are covered by tests team/agent-build team/agent-security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants