bazel: restore cmd/serverless-init/cloudservice to the build

[litianningdatadog]

Why

PR #53031 added Run(modeConf mode.Conf, logConfig *serverlessInitLog.Config) error
to the CloudService interface, which made cmd/serverless-init/cloudservice
import cmd/serverless-init/mode and cmd/serverless-init/log for the first
time. Both packages were still gazelle:excluded (never migrated to Bazel),
so bazel build //... broke:

ERROR: no such package 'cmd/serverless-init/log'/'cmd/serverless-init/mode':
BUILD file not found ... referenced from '//cmd/serverless-init/cloudservice:cloudservice'

As a stopgap to unblock CI, that PR re-excluded cloudservice itself
alongside mode/log, reverting it to its pre-Bazel-migration state. That
unblocked CI but is a step backward for the repo-wide Bazel migration
(cloudservice had already been migrated once, in #52842) and leaves it
without Bazel test coverage.

This PR does the migration properly instead of leaving the exclusion in place.

Why removing just those 3 lines wasn't enough

# gazelle:exclude cmd/serverless-init/cloudservice
# gazelle:exclude cmd/serverless-init/log
# gazelle:exclude cmd/serverless-init/mode

Bazel requires every transitive Go import to resolve to a buildable target —
unlike go build, which only needs the packages actually reached by the
active build tags. Un-excluding only these three doesn't stop at mode/log:
following the real (verified via direct import inspection, not assumption)
dependency chain,

cloudservice -> mode -> log -> pkg/serverless/logs -> comp/logs/agent/impl
             -> pkg/logs/launchers/{file, integration, journald, container/tailerfactory}

every one of those packages was also still gazelle-excluded. Removing only
the first three would have just moved the "no such package" error one hop
further down the chain (confirmed this is exactly what happened when this was
first investigated: un-excluding log/mode alone reproduced the identical
failure at pkg/serverless/logs, then at comp/logs/agent/impl). So all 8
gazelle:exclude lines had to come out together in one PR, innermost
dependency first, with Gazelle re-run and each generated BUILD.bazel
reviewed by hand.

Every other internal dependency of this chain was already migrated — no
further cascading exclusions were needed beyond these 8.

Summary of changes

• Removed 8 gazelle:exclude directives (plus their explanatory comment)
  from the root BUILD.bazel, for: cmd/serverless-init/{cloudservice,log,mode},
  comp/logs/agent/impl, pkg/serverless/logs, and
  pkg/logs/launchers/{container/tailerfactory,file/*.go,integration,journald}.
• Added the Gazelle-generated BUILD.bazel for each of those packages.
• pkg/logs/launchers/container/BUILD.bazel was previously a # gazelle:ignore
  stub (it couldn't be built without tailerfactory); replaced with a real
  target now that tailerfactory is migrated.
• No .go source files changed — this is a pure Bazel build-graph change.

Test plan

• bazel build //... — no errors on any of the restored packages (the
  run did hit unrelated disk-space-exhaustion failures in ~340 other,
  pre-existing packages; none touch this change).
• Scoped bazel build/bazel test of the full restored chain — builds
  clean; 5/5 runnable tests pass. The remaining test variants
  (cloudservice/log/mode/impl/journald) report SKIPPED on
  macOS specifically because pkg/logs/launchers/journald links a
  Linux-only cgo/systemd dependency — verified this exact
  unconditional dependency is what Gazelle has always generated for this
  package (byte-identical to the last time it was live in //..., per
  git show 7559a83ec93:pkg/logs/launchers/journald/BUILD.bazel), and
  confirmed CI's bazel test --keep_going //... on macOS treats these
  skips as non-fatal (exit 0), so this isn't a regression.
• bazel run //bazel/buildifier — clean, no formatting changes needed.

[chatgpt-codex-connector]

💡 Codex Review

datadog-agent/cmd/serverless-init/main_test.go

Line 282 in 4cc1aba

time.Sleep(50 * time.Millisecond)

Synchronize sidecar signal registration deterministically

On slow or heavily scheduled CI workers this fixed sleep can expire before the goroutine inside svc.Run has registered its own signal.Notify; in that case the SIGTERM on the next line is delivered only to guard, RunSidecar remains blocked, and the test fails after the 2s timeout. The repo review guideline explicitly asks us to flag sleeps used to wait for background work, so prefer a handshake/injected notify path here instead of timing the registration.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[datadog-datadog-us1-prod]

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 52.15% (-0.00%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 810ffe1 | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 1f54e07e:

Results for datadog-agent_7.83.0~devel.git.332.810ffe1.pipeline.126317511-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 1f54e07
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	750.599 MiB
✅	agent_deb_amd64_fips	705.387 MiB
✅	agent_heroku_amd64	307.504 MiB
✅	agent_msi	639.379 MiB
✅	agent_rpm_amd64	750.583 MiB
✅	agent_rpm_amd64_fips	705.370 MiB
✅	agent_rpm_arm64	727.261 MiB
✅	agent_rpm_arm64_fips	685.184 MiB
✅	agent_suse_amd64	750.583 MiB
✅	agent_suse_amd64_fips	705.370 MiB
✅	agent_suse_arm64	727.261 MiB
✅	agent_suse_arm64_fips	685.184 MiB
✅	docker_agent_amd64	809.275 MiB
✅	docker_agent_arm64	810.989 MiB
✅	docker_agent_jmx_amd64	1000.173 MiB
✅	docker_agent_jmx_arm64	990.539 MiB
✅	docker_cluster_agent_amd64	209.843 MiB
✅	docker_cluster_agent_arm64	222.890 MiB
✅	docker_cws_instrumentation_amd64	7.439 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.228 MiB
✅	docker_dogstatsd_arm64	37.368 MiB
✅	docker_host_profiler_amd64	303.231 MiB
✅	docker_host_profiler_arm64	314.740 MiB
✅	dogstatsd_deb_amd64	29.968 MiB
✅	dogstatsd_deb_arm64	28.012 MiB
✅	dogstatsd_rpm_amd64	29.968 MiB
✅	dogstatsd_suse_amd64	29.968 MiB
✅	iot_agent_deb_amd64	46.141 MiB
✅	iot_agent_deb_arm64	42.833 MiB
✅	iot_agent_deb_armhf	43.601 MiB
✅	iot_agent_rpm_amd64	46.142 MiB
✅	iot_agent_suse_amd64	46.141 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a7d096ac-0e89-46cb-a94d-889697787b0c

Baseline: 6537db0
Comparison: 072a8c0
Diff

❌ Experiments with retried target crashes

This is a critical error. One or more replicates failed with a non-zero exit code. These replicates may have been retried. See Replicate Execution Details for more information.

• quality_gate_idle_all_features

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.13	[+0.15, +2.11]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	+0.70	[+0.66, +0.74]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	+0.11	[-0.15, +0.36]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.07	[+0.02, +0.12]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	-0.17	[-0.22, -0.12]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	-0.18	[-0.24, -0.12]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	-0.30	[-0.39, -0.20]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	146.28MiB ≤ 154MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	734.55KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	490.38MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.12MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	184.38MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	263.75MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	365.40 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	407.93MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.93GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	29.84 ≤ 40	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	297.32MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	62.38 ≤ 80	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	278.50MiB ≤ 310MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	21.00 ≤ 40	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	284.34MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Normal Replicate Execution Failures (non-profiling)

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle_all_features	baseline	2	Oom killed	Debug Dashboard

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle	comparison	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_idle	baseline	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_idle	comparison	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_mean_fs_load	baseline	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_no_fs_load	baseline	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_no_fs_load	comparison	10	Crashed (exit code: 134)	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.

[litianningdatadog]

💡 Codex Review

datadog-agent/cmd/serverless-init/main_test.go

Line 282 in 4cc1aba

time.Sleep(50 * time.Millisecond)

Synchronize sidecar signal registration deterministically
On slow or heavily scheduled CI workers this fixed sleep can expire before the goroutine inside svc.Run has registered its own signal.Notify; in that case the SIGTERM on the next line is delivered only to guard, RunSidecar remains blocked, and the test fails after the 2s timeout. The repo review guideline explicitly asks us to flag sleeps used to wait for background work, so prefer a handshake/injected notify path here instead of timing the registration.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector This spotted issue was not related to MicroVM related work. A separate PR would be required to address this if we see the flaky tests failure

[chatgpt-codex-connector]

Summary

• Replaced the fixed sleep in TestRun_LocalService_SidecarMode with a deterministic registration handshake before sending SIGTERM. cmd/serverless-init/main_test.goL275-L289
• Added an injectable signal notification function for RunSidecar, allowing the test to observe when signal registration has completed. cmd/serverless-init/mode/sidecarcontainer_mode.goL22-L39
• Added signal.Stop cleanup for the sidecar signal channel after registration is no longer needed. cmd/serverless-init/mode/sidecarcontainer_mode.goL41-L47

Testing

• ✅ git diff --check
• ⚠️ dda inv test --targets=./cmd/serverless-init/... — could not complete because Go module downloads from proxy.golang.org returned Forbidden in this environment.

Committed changes on the current branch: 4d7878db. Created PR: serverless-init: synchronize sidecar signal test.

View task →

[Copilot]

Pull request overview

This PR restores Bazel build support for cmd/serverless-init/cloudservice by reintroducing Bazel targets for the packages it directly depends on and removing the root-level Gazelle exclusion that previously kept cloudservice (and mode) out of the Bazel build graph.

Changes:

• Add Bazel go_library + dd_agent_go_test targets for cmd/serverless-init/mode.
• Add Bazel go_library + dd_agent_go_test targets for cmd/serverless-init/cloudservice.
• Remove the gazelle:exclude directives (and associated comment) for cmd/serverless-init/cloudservice and cmd/serverless-init/mode from the repo root BUILD.bazel.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
cmd/serverless-init/mode/BUILD.bazel	Introduces Bazel targets for the mode package and its tests so it can be built/tested under Bazel.
cmd/serverless-init/cloudservice/BUILD.bazel	Re-adds Bazel targets for the cloudservice package and its unit tests, restoring it to the Bazel build graph.
BUILD.bazel	Drops Gazelle exclusions that prevented cloudservice/mode from being considered by Bazel builds.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[litianningdatadog]

Closing as superseded — the Bazel cloudservice BUILD.bazel changes were already folded into the #53104 rebase, so this branch now has zero diff against its base. Repointing #53515 directly onto tianning.li/microvm-07-08-ready-validate-hook-contract-fix.