fix(flare): collect dynamic instrumentation tombstone from run_path

[grantseltzer]

What does this PR do?

Points the flare at the current location of the dynamic instrumentation tombstone file, run_path/system-probe/dynamic-instrumentation/debugger-probes-tombstone.json, instead of the old world-writable /tmp path.

Motivation

PR #53286 moved the dynamic instrumentation tombstone out of /tmp and into the agent's root-owned run directory, but the flare was still copying it from the old /tmp path. As a result the tombstone was silently missing from generated flares, removing a signal that is valuable for debugging probe-load crashes even when system-probe is not running. This updates the flare to read from the location the module now writes.

Describe how you validated your changes

Built pkg/flare. Confirmed the path matches dynamicInstrumentationStateDir() introduced in #53286 (run_path/system-probe/dynamic-instrumentation).

Additional Notes

Follow-up to #53286, which relocated the writable state but did not update the flare's hardcoded path.

[datadog-prod-us1-5]

View session in Datadog

Bits Code status: ✅ Done

Comment @DataDog to request changes

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 735ef55
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	748.702 MiB
✅	agent_deb_amd64_fips	703.715 MiB
✅	agent_heroku_amd64	307.071 MiB
✅	agent_msi	644.683 MiB
✅	agent_rpm_amd64	748.686 MiB
✅	agent_rpm_amd64_fips	703.699 MiB
✅	agent_rpm_arm64	723.961 MiB
✅	agent_rpm_arm64_fips	682.683 MiB
✅	agent_suse_amd64	748.686 MiB
✅	agent_suse_amd64_fips	703.699 MiB
✅	agent_suse_arm64	723.961 MiB
✅	agent_suse_arm64_fips	682.683 MiB
✅	docker_agent_amd64	807.460 MiB
✅	docker_agent_arm64	807.752 MiB
✅	docker_agent_jmx_amd64	998.358 MiB
✅	docker_agent_jmx_arm64	987.302 MiB
✅	docker_cluster_agent_amd64	209.377 MiB
✅	docker_cluster_agent_arm64	222.451 MiB
✅	docker_cws_instrumentation_amd64	7.447 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.149 MiB
✅	docker_dogstatsd_arm64	37.305 MiB
✅	docker_host_profiler_amd64	302.500 MiB
✅	docker_host_profiler_arm64	314.027 MiB
✅	dogstatsd_deb_amd64	29.884 MiB
✅	dogstatsd_deb_arm64	27.924 MiB
✅	dogstatsd_rpm_amd64	29.884 MiB
✅	dogstatsd_suse_amd64	29.884 MiB
✅	iot_agent_deb_amd64	45.856 MiB
✅	iot_agent_deb_arm64	42.552 MiB
✅	iot_agent_deb_armhf	43.336 MiB
✅	iot_agent_rpm_amd64	45.857 MiB
✅	iot_agent_suse_amd64	45.856 MiB

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e905a572a0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[Copilot]

Pull request overview

Moves Dynamic Instrumentation’s on-disk state (SymDB upload cache, probe tombstone file, and decompressed debug-info directory) from a world-writable /tmp location to a path under the Agent’s run directory (root-owned), addressing a symlink/pre-creation risk (VULN-87875).

Changes:

• Update dyninst module defaults to place SymDB upload cache + probe tombstone under DefaultDynamicInstrumentationRunDir.
• Introduce DefaultDynamicInstrumentationRunDir and update the default debug-info decompression directory to live under it.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
pkg/dyninst/module/config.go	Updates default SymDB cache and tombstone paths to live under the dynamic-instrumentation run directory.
pkg/config/setup/system_probe.go	Defines DefaultDynamicInstrumentationRunDir under the default run path and updates the debug-info disk-cache default directory accordingly.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[datadog-prod-us1-5]

Bits couldn’t fix the CI

🟢 Investigated · 🔴 Fix failed · ⚪ Validate · ⚪ Ready

pkg/flare Bazel strict dependency checks failed because archive_linux.go imports pkg/util/defaultpaths without declaring it in pkg/flare/BUILD.bazel. Added //pkg/util/defaultpaths to the Linux platform deps for the flare Go library.

---

View in Datadog | Reviewed commit 952941f

[datadog-prod-us1-5]

🎯 Code Coverage (details)
• Patch Coverage: 0.00%
• Overall Coverage: 51.39% (-0.12%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 496fcbf | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 735ef556:

Results for datadog-agent_7.82.0~devel.git.740.496fcbf.pipeline.123863009-1_amd64.deb:

No change detected

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 478bf5e8-d813-484a-adc8-ce3e38b84c16

Baseline: 3c80928
Comparison: db84cf7
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_metrics_logs	memory utilization	+0.29	[+0.03, +0.54]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	+0.27	[-0.71, +1.24]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.17	[+0.10, +0.24]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	+0.15	[+0.08, +0.21]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	+0.03	[-0.01, +0.07]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	-0.09	[-0.18, -0.00]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	-0.27	[-0.32, -0.22]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	147.49MiB ≤ 154MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	728.83KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	493.23MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.12MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	183.19MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	264.15MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	360.09 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	397.26MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	30.57 ≤ 40	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	299.97MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	64.81 ≤ 80	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	275.79MiB ≤ 310MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	23.48 ≤ 40	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	281.90MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_idle	baseline	10	Oom killed	Debug Dashboard
quality_gate_security_idle	comparison	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_no_fs_load	baseline	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_no_fs_load	comparison	10	Crashed (exit code: 134)	Debug Dashboard

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[grantseltzer]

/merge

[gh-worker-devflow-routing-ef8351]

View all feedbacks in Devflow UI.

2026-07-13 19:46:29 UTC ℹ️ Start processing command /merge

---

2026-07-13 19:46:34 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 5h (p90).

---

2026-07-13 21:52:28 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.

---

2026-07-13 22:44:34 UTC ℹ️ MergeQueue: This merge request was merged