Update Rust crate uuid to v1.23.5 - #53552
Conversation
renovate
Bot
added
changelog/no-changelog
renovate
Bot
added
the
qa/no-code-change
renovate
Bot
added
changelog/no-changelog
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: approved - manual merge required (this rule does not auto-merge) |
github-actions
Bot
added
the
short review
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
Files inventory check summaryFile checks results against ancestor 596b9de6: Results for datadog-agent_7.83.0~devel.git.105.44c4d5f.pipeline.124619635-1_amd64.deb:No change detected |
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
27 successful checks with minimal change (< 2 KiB)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 596b9de ❌ Experiments with retried target crashesThis is a critical error. One or more replicates failed with a non-zero exit code. These replicates may have been retried. See Replicate Execution Details for more information.
Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_idle_all_features | memory utilization | +0.05 | [-0.02, +0.12] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | -0.12 | [-0.17, -0.07] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_security_no_fs_load | memory utilization | -0.16 | [-0.25, -0.07] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_security_idle | memory utilization | -0.38 | [-0.43, -0.32] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_security_mean_fs_load | memory utilization | -0.45 | [-0.49, -0.41] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_logs | % cpu utilization | -1.31 | [-2.27, -0.35] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | -1.57 | [-1.83, -1.31] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 147.64MiB ≤ 154MiB | bounds checks dashboard |
| ✅ | quality_gate_idle | total_bytes_received | 10/10 | 731.20KiB ≤ 819.20KiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 493.09MiB ≤ 495MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | total_bytes_received | 10/10 | 1.13MiB ≤ 1.25MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 181.64MiB ≤ 195MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_logs | total_bytes_received | 10/10 | 264.15MiB ≤ 292MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 441.56 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 410.05MiB ≤ 430MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | total_bytes_received | 10/10 | 0.94GiB ≤ 1.04GiB | bounds checks dashboard |
| ✅ | quality_gate_security_idle | cpu_usage | 10/10 | 28.50 ≤ 40 | bounds checks dashboard |
| ✅ | quality_gate_security_idle | memory_usage | 10/10 | 296.75MiB ≤ 330MiB | bounds checks dashboard |
| ✅ | quality_gate_security_mean_fs_load | cpu_usage | 10/10 | 60.77 ≤ 80 | bounds checks dashboard |
| ✅ | quality_gate_security_mean_fs_load | memory_usage | 10/10 | 277.36MiB ≤ 310MiB | bounds checks dashboard |
| ✅ | quality_gate_security_no_fs_load | cpu_usage | 10/10 | 22.54 ≤ 40 | bounds checks dashboard |
| ✅ | quality_gate_security_no_fs_load | memory_usage | 10/10 | 286.02MiB ≤ 320MiB | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Replicate Execution Details
We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.
Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.
| Experiment | Variant | Replicates | Failure | Logs | Debug Dashboard |
|---|---|---|---|---|---|
| experiment_with_failures | baseline | 0 (x8) 1 (x6) | Oom killed | Debug Dashboard |
The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.
❌ Retried Normal Replicate Execution Failures (non-profiling)
| Experiment | Variant | Replicates | Failure | Debug Dashboard |
|---|---|---|---|---|
| quality_gate_idle | comparison | 2 | Oom killed | Debug Dashboard |
| quality_gate_idle_all_features | comparison | 9 | Oom killed | Debug Dashboard |
❌ Retried Profiling Replicate Execution Failures (ddprof)
Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.
| Experiment | Variant | Replicates | Failure | Debug Dashboard |
|---|---|---|---|---|
| quality_gate_idle | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_idle | comparison | 10 | Oom killed | Debug Dashboard |
| quality_gate_idle_all_features | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_idle_all_features | comparison | 10 | Oom killed | Debug Dashboard |
| quality_gate_metrics_logs | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_metrics_logs | comparison | 10 | Oom killed | Debug Dashboard |
| quality_gate_security_idle | baseline | 10 | Crashed (exit code: 134) | Debug Dashboard |
| quality_gate_security_mean_fs_load | baseline | 10 | Crashed (exit code: 134) | Debug Dashboard |
| quality_gate_security_mean_fs_load | comparison | 10 | Crashed (exit code: 134) | Debug Dashboard |
| quality_gate_security_no_fs_load | baseline | 10 | Oom killed | Debug Dashboard |
| quality_gate_security_no_fs_load | comparison | 10 | Oom killed | Debug Dashboard |
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
1150858 to
401f80e
Compare
![dd-prapprover-prod-77c48c[bot]](https://avatars.githubusercontent.com/u/244837012?s=60&v=4){kind=small}
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status waiting |
bd335fd to
17f2a03
Compare
41702eb to
a26392c
Compare
### What does this PR do? Remove the `procmgr_rust_tests` GitLab job and its entry from `JOBOWNERS`, and add the `rust_test` target this uncovered was missing for `dd-procmgr`. ### Motivation Investigating why `rawzip` bump (#53563) broke CI found `procmgr_rust_tests` failing because Cargo's internal registry proxy had not yet mirrored the new version, not because of anything wrong with the bump. The same registry-lag failure independently hit `uuid` bump (#53552), a dependency this crate uses directly. Bazel benefits from ADMS' centralized downloader mirror config (`.adms/bazel/adms.mirror.cfg`), while plain `cargo` instead relies on `.rust_internal_registry`'s bespoke GitLab CI redirect (`.adms/rust/gitlab.yaml`), which is what lagged, so `bazel:test:*` passed both times regardless. This is safe to rely on because `pkg/procmgr/rust/BUILD.bazel` has a `rust_test` target (since #46880) and `bazel:test:linux-amd64`, `:linux-arm64`, etc. already run every target in that file, with the same implied `rustfmt`/`clippy` `-Dwarnings` Cargo passes explicitly, on every pipeline. The one gap, caught by review on #53629, was that `cargo test --all-targets` also exercised `dd-procmgr.rs`'s own 15 `#[test]` functions via `--bins`, which no existing `rust_test` covered; this closes it with a `dd-procmgr_test` target wrapping that binary crate directly. The Cargo job also runs far more than its own path filter suggests: `.on_main_or_release_branch` matches on branch name alone, ahead of the path filter, so it fires on every push to `main`, ~900 times in the last 30 days for an average of ~140s per run. As #53615 already dropped the `extend` from the package-build jobs, removing it here finishes collapsing `pkg/procmgr/rust` onto Bazel as its only toolchain, one source of truth instead of two that are doomed to drift apart. ### Describe how you validated your changes Confirmed parity before removing anything: no test is gated by the `test-helpers` feature beyond `cfg(test)`, and `rules_rust`'s `clippy`/`rustfmt` aspects don't propagate through dependencies, so they only check whatever `//...` names directly, which is every library, binary, and test as its own target. Ran `bazel test //pkg/procmgr/rust:dd-procmgr_test --test_output=all`, confirming all 15 tests run and pass. ### Additional Notes Bazel's coverage is now a strict superset: it lints the plain and `test-helpers`-enabled lib variants as separate targets and tests the `dd-procmgr` CLI binary directly, whereas Cargo's single invocation only ever builds one feature resolution at a time.
### What does this PR do? Remove the `procmgr_rust_tests` GitLab job and its entry from `JOBOWNERS`, and add the missing `rust_test` target for `dd-procmgr` that this uncovered. ### Motivation Investigating why `rawzip` bump (#53563) broke CI found `procmgr_rust_tests` failing because Cargo's specific registry proxy had not yet mirrored the new version, not because of anything wrong with the bump. The same registry-lag failure independently hit `uuid` bump (#53552), a dependency this crate uses directly. Bazel benefits from ADMS' centralized downloader mirror config ([.adms/bazel/adms.mirror.cfg](https://github.com/DataDog/datadog-agent/blob/main/.adms/bazel/adms.mirror.cfg)), while plain `cargo` instead relies on `.rust_internal_registry`'s bespoke GitLab CI redirect ([.adms/rust/gitlab.yaml](https://github.com/DataDog/datadog-agent/blob/main/.adms/rust/gitlab.yaml)), which is what lagged, so `bazel:test:*` passed both times regardless. This is safe to rely on because `pkg/procmgr/rust/BUILD.bazel` has a `rust_test` target (since #46880) and `bazel:test:linux-amd64`, `:linux-arm64`, etc. already run every target in that file, with the same implied `rustfmt`/`clippy` `-Dwarnings` Cargo passes explicitly, on every pipeline. The one gap was that `cargo test --all-targets` also exercised `dd-procmgr.rs`'s own 15 `#[test]` functions via `--bins`, which no existing `rust_test` covered. This therefore closes it with a `dd-procmgr_test` target wrapping that binary crate directly, while making sure it runs on all supported platforms. The Cargo job also runs far more than its own path filter suggests: `.on_main_or_release_branch` matches on branch name alone, ahead of the path filter, so it fires on every push to `main`, ~900 times in the last 30 days for an average of ~2min per run. As #53615 already dropped the `extend` from the package-build jobs, removing it here finishes collapsing `pkg/procmgr/rust` onto Bazel as its only toolchain, one source of truth instead of two that are doomed to drift apart. ### Describe how you validated your changes Confirmed parity before removing anything: no test is gated by the `test-helpers` feature beyond `cfg(test)`, and `rules_rust`'s `clippy`/`rustfmt` aspects don't propagate through dependencies, so they only check whatever `//...` names directly, which is every library, binary, and test as its own target. Ran `bazel test //pkg/procmgr/rust:dd-procmgr_test --test_output=all`: all 15 tests run and pass. ### Additional Notes Bazel's coverage is now a strict superset: it lints the plain and `test-helpers`-enabled lib variants as separate targets and tests the `dd-procmgr` CLI binary directly, whereas Cargo's single invocation only ever builds one feature resolution at a time. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
|
/merge |
e996eaa to
bf85b1b
Compare
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
…censes This commit was created from the local commit with hash 35f21c525c8526c0987d479ffe8d4466715449ff.
2 participants
This PR contains the following updates:
1.23.4→1.23.5Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
uuid-rs/uuid (uuid)
v1.23.5Compare Source
What's Changed
New Contributors
Full Changelog: uuid-rs/uuid@v1.23.4...v1.23.5
Configuration
📅 Schedule: (in timezone Europe/Paris)
* 0-4,22-23 * * 1-5)* * * * 0,6)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.