scope TestIntakeRefreshAPIKey to the metrics endpoint instead of the global last-key - #53653
Open
s-alad wants to merge 1 commit into
Open
scope TestIntakeRefreshAPIKey to the metrics endpoint instead of the global last-key#53653s-alad wants to merge 1 commit into
TestIntakeRefreshAPIKey to the metrics endpoint instead of the global last-key#53653s-alad wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
short review
s-alad
marked this pull request as ready for review
July 14, 2026 22:40
Contributor
|
🎯 Code Coverage (details) 🔗 Commit SHA: b3bcb61 | Docs | Datadog PR Page | Give us feedback! |
Contributor
Files inventory check summaryFile checks results against ancestor 623b04cb: Results for datadog-agent_7.84.0~devel.git.58.b3bcb61.pipeline.130085113-1_amd64.deb:No change detected Results for datadog-iot-agent_7.84.0~devel.git.58.b3bcb61.pipeline.130085113-1_amd64.deb:No change detected |
rahulkaukuntla
approved these changes
Jul 14, 2026
ofek
added
changelog/no-changelog
s-alad
force-pushed
the
saad/fix-get-last-api-key-test
branch
from
July 20, 2026 14:58
9a1b78a to
2af540c
Compare
Contributor
|
This pull request has been automatically marked as stale because it has not had activity in the past 15 days. It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window. Thank you for your contributions! |
…cs endpoint instead of the global (route-unscoped) last-key
s-alad
force-pushed
the
saad/fix-get-last-api-key-test
branch
from
August 10, 2026 21:53
2af540c to
b3bcb61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Claude suggested fix to help alleviate rare transient E2E test failure: https://datadoghq.atlassian.net/jira/software/c/projects/AGENTCFG/boards/8668?selectedIssue=AGENTCFG-819
TestIntakeRefreshAPIKeyasserts on fakeintake'sGetLastAPIKey(), which is a single global field overwritten by every payload on every route. There can be a race which periodically flakes the test. Adds a route-scopedGetLastMetricPayloadAPIKey()client method and points the test at it.Motivation
Recurring CI flake (job 1813051483)
Describe how you validated your changes
Running tests
Additional Notes