Skip to content

Remove experimental from dogstatsd stream socket option. - #53828

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
stephen/streams_public
Jul 21, 2026
Merged

Remove experimental from dogstatsd stream socket option.#53828
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
stephen/streams_public

Conversation

@StephenWakely

Copy link
Copy Markdown
Contributor

What does this PR do?

Removes the warning and exposes the dogstatsd_stream_socket configuration option.

Motivation

The dogstatsd_stream_socket option has been available in the agent since 7.50. PR. It has been hidden and a warning dogstatsd_stream_socket is not yet supported, run it at your own risk was shown when it was used.

We have dogfooded the option extensively and successfully, so there is no reason to not support this option.

Describe how you validated your changes

Additional Notes

@StephenWakely
StephenWakely requested review from a team as code owners July 20, 2026 09:28
@StephenWakely
StephenWakely requested a review from hush-hush July 20, 2026 09:28
@StephenWakely StephenWakely added the qa/done QA done before merge and regressions are covered by tests label Jul 20, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Jul 20, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0cb2860e9b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pkg/config/schema/yaml/core_schema.yaml Outdated
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 52.02% (+0.14%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6784dff | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor a91a30bf:

Results for datadog-agent_7.83.0~devel.git.211.6784dff.pipeline.125684155-1_amd64.deb:

No change detected

@vickenty vickenty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of optional suggestions, but otherwise LGTM

Comment thread releasenotes/notes/dogstatsd-stream-socket-stable-e9b7ac10f0e9861b.yaml Outdated
Comment thread pkg/config/config_template.yaml Outdated

## @param dogstatsd_stream_socket - string - optional - default: ""
## @env DD_DOGSTATSD_STREAM_SOCKET - string - optional - default: ""
## Listen for Dogstatsd metrics on a Unix Socket using stream mode (SOCK_STREAM, *nix only).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Listen for Dogstatsd metrics on a Unix Socket using stream mode (SOCK_STREAM, *nix only).
## Listen for Dogstatsd metrics on a Unix domain socket using stream mode (SOCK_STREAM, Linux and MacOS only).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should work on AIX as well.

@dd-octo-sts

dd-octo-sts Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor a91a30b
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 750.013 MiB
agent_deb_amd64_fips 704.946 MiB
agent_heroku_amd64 307.925 MiB
agent_msi 643.885 MiB
agent_rpm_amd64 749.997 MiB
agent_rpm_amd64_fips 704.929 MiB
agent_rpm_arm64 726.621 MiB
agent_rpm_arm64_fips 685.230 MiB
agent_suse_amd64 749.997 MiB
agent_suse_amd64_fips 704.929 MiB
agent_suse_arm64 726.621 MiB
agent_suse_arm64_fips 685.230 MiB
docker_agent_amd64 808.717 MiB
docker_agent_arm64 810.349 MiB
docker_agent_jmx_amd64 999.614 MiB
docker_agent_jmx_arm64 989.899 MiB
docker_cluster_agent_amd64 209.795 MiB
docker_cluster_agent_arm64 222.889 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.224 MiB
docker_dogstatsd_arm64 37.367 MiB
docker_host_profiler_amd64 303.072 MiB
docker_host_profiler_arm64 314.596 MiB
dogstatsd_deb_amd64 29.968 MiB
dogstatsd_deb_arm64 28.007 MiB
dogstatsd_rpm_amd64 29.968 MiB
dogstatsd_suse_amd64 29.968 MiB
iot_agent_deb_amd64 46.118 MiB
iot_agent_deb_arm64 42.809 MiB
iot_agent_deb_armhf 43.578 MiB
iot_agent_rpm_amd64 46.118 MiB
iot_agent_suse_amd64 46.117 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jul 20, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 57197872-1dc8-4ff9-92a0-b201d08914f2

Baseline: 8a100fc
Comparison: 71c43dd
Diff

❌ Experiments with retried target crashes

This is a critical error. One or more replicates failed with a non-zero exit code. These replicates may have been retried. See Replicate Execution Details for more information.

  • quality_gate_idle_all_features

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +0.45 [-0.52, +1.41] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.32 [+0.28, +0.36] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.15 [+0.10, +0.20] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.13 [+0.03, +0.23] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.08 [-0.16, +0.32] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization -0.22 [-0.27, -0.17] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.31 [-0.40, -0.21] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 148.43MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 728.45KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 492.92MiB ≤ 495MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 182.64MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.15MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 356.89 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 392.09MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 29.46 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 298.03MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 63.83 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 284.28MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 22.03 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 286.79MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Normal Replicate Execution Failures (non-profiling)

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 1 (x3) Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 9, 2 (x2), 7 (x2), 8 Oom killed Debug Dashboard

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 (x2) Oom killed Debug Dashboard
quality_gate_logs comparison 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_mean_fs_load baseline 10 Crashed (exit code: 134) Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

Comment thread pkg/config/schema/yaml/core_schema.yaml Outdated
Please note that this is not available in Windows.
tags:
- template_section:Dogstatsd
comment: 'Experimental || Notice: empty means feature disabled'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this comment then ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes. Good spot.

@StephenWakely
StephenWakely requested a review from hush-hush July 20, 2026 14:43
@StephenWakely

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 21, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-21 08:23:23 UTC ℹ️ Start processing command /merge


2026-07-21 08:23:28 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 2h (p90).


2026-07-21 09:09:41 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 71c43dd into main Jul 21, 2026
379 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the stephen/streams_public branch July 21, 2026 09:09
@github-actions github-actions Bot added this to the 7.83.0 milestone Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-configuration team/agent-metric-pipelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants