Skip to content

Update devcontainer config, to remove /etc/os-release mount - #54897

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
kfairise/remove-etc-host-mount
Aug 17, 2026
Merged

Update devcontainer config, to remove /etc/os-release mount#54897
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
kfairise/remove-etc-host-mount

Conversation

@KevinFairise2

Copy link
Copy Markdown
Member

What does this PR do?

Remove /etc/os-release mount that breaks some dpkg interactions, like in sudo unminimize.
Also move HOST_* env variables so that they are propagated correctly to the ssh connection

Motivation

Describe how you validated your changes

Additional Notes

@KevinFairise2
KevinFairise2 requested a review from a team as a code owner August 14, 2026 13:20
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-devx labels Aug 14, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Aug 14, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 2f78841f:

Results for datadog-agent_7.84.0~devel.git.197.42d3b1c.pipeline.130984921-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.197.42d3b1c.pipeline.130984921-1_amd64.deb:

No change detected

@KevinFairise2 KevinFairise2 added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Aug 14, 2026
@temporal-github-worker-1

temporal-github-worker-1 Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

❌ Devcontainer prebuild failed.

Branch: kfairise/remove-etc-host-mount
Config: .devcontainer/datadog/default/prebuild-devcontainer.json

Links:

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 0557b36 into main Aug 17, 2026
270 of 281 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the kfairise/remove-etc-host-mount branch August 17, 2026 09:52
@github-actions github-actions Bot added this to the 7.84.0 milestone Aug 17, 2026
github-actions Bot pushed a commit that referenced this pull request Aug 17, 2026
<!--Please give us some feedback on your experience writing this PR ! https://app.datadoghq.com/forms/43db4c02-6837-400c-8083-692e141b1b88 !-->

### What does this PR do?

Remove /etc/os-release mount that breaks some dpkg interactions, like in `sudo unminimize`.
Also move `HOST_*` env variables so that they are propagated correctly to the ssh connection

### Motivation

### Describe how you validated your changes

### Additional Notes

Co-authored-by: nicolas.schweitzer <nicolas.schweitzer@datadoghq.com> 0557b36
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 96a90402-b8ca-44ee-82b5-6815d0c2251e

Baseline: bcbf486
Comparison: 0557b36
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.05 [+0.17, +1.93] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.31 [+0.19, +0.43] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.16 [+0.09, +0.23] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.07 [-0.08, +0.22] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.04 [+0.00, +0.08] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization -0.09 [-0.19, +0.02] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.32 [-0.57, -0.07] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization -0.34 [-0.46, -0.21] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 174.29MiB ≤ 178MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 740.08KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 513.11MiB ≤ 538MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.13MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 15 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 211.53MiB ≤ 229MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.79MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 348.13 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 19 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 392.03MiB ≤ 439MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 71.73MiB ≤ 76MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 25.87 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 327.88MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 59.51 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 300.08MiB ≤ 314MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 20.13 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 308.60MiB ≤ 343MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants