ci - poc to use ddci on-demand for end-to-end test in feature branch - #54946
ci - poc to use ddci on-demand for end-to-end test in feature branch#54946NielkSalocin wants to merge 1 commit into
Conversation
|
@codex review |
github-actions
Bot
added
the
short review
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40acef6b29
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -0,0 +1,8 @@ | |||
| trigger: | |||
| stage: .pre | |||
| include: .gitlab-ci.yml | |||
There was a problem hiding this comment.
GitLab treats the top-level trigger as the job name, so include is currently parsed as an unsupported job keyword and every on-demand invocation fails CI configuration validation before any E2E test starts. Nest include under a second trigger: key, following the working child-pipeline shape in .gitlab/deploy/trigger_distribution.yml:8-12.
Useful? React with 👍 / 👎.
| @@ -0,0 +1,8 @@ | |||
| trigger: | |||
| stage: .pre | |||
| include: .gitlab-ci.yml | |||
There was a problem hiding this comment.
After nesting this as a valid downstream trigger, omitting strategy: depend or strategy: mirror makes the on-demand job succeed as soon as the child pipeline is created, so DDCI can report a green result while the requested E2E suite later fails. Add a waiting strategy to the nested trigger; the repository documents this exact default behavior in .gitlab/test/functional_test/regression_detector.yml:216-220 and uses strategy: depend where the parent must reflect the child result.
Useful? React with 👍 / 👎.
Files inventory check summaryFile checks results against ancestor fec92d8c: Results for datadog-agent_7.84.0~devel.git.219.40acef6.pipeline.131263260-1_amd64.deb:No change detected Results for datadog-iot-agent_7.84.0~devel.git.219.40acef6.pipeline.131263260-1_amd64.deb:No change detected |
|
/gitlab trigger-ci -v DYNAMIC_BUILD_RENDER_RULES=end-to-end |
|
View all feedbacks in Devflow UI.
Started pipeline #131276560 |
1 participant
What does this PR do?
Motivation
Describe how you validated your changes
Additional Notes