Changes the message that appears in eg flamegraph when the SQL cannot be obfuscated - #9289
Changes the message that appears in eg flamegraph when the SQL cannot be obfuscated#9289andrewl wants to merge 2 commits into
Conversation
obfuscator fails.
|
|
andrewl
changed the title
|
|
||
| const sqlQueryTag = "sql.query" | ||
| const nonParsableResource = "Non-parsable SQL query" | ||
| const nonParsableResource = "Cannot obfuscate: Non-parsable SQL query" |
There was a problem hiding this comment.
I agree with you that this is more explicit but unfortunately making this change would break backwards compatibility for anyone tracking this value, which is very likely. I'm afraid we can't make this change. At most we could edit the log output and make that better, but I'm not sure if that'll actually help.
|
This pull request has been automatically marked as stale because it has not had activity in the past 15 days. It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window. Thank you for your contributions! |
|
Hi, We are closing this PR as there was no recent activity on it. Feel free to reopen it if you still need the feature. |
4 participants
What does this PR do?
Changes the message that appears in eg flamegraph when the SQL obfuscator fails from "Non-parsable SQL query" to "Cannot obfuscate: Non-parsable SQL query".
This makes is clearer as to the origin of the error - otherwise to the uninitiated it looks as if it is the database throwing an error during SQL execution, when it is the logging tool, datadog, throwing an error during logging (specifically obfuscation).
Motivation
My team spent a few days diving down a rabbit-hole trying to debug what they thought was a complex SQL error, when in fact, everything was working fine and they should have ignored this error.
Additional Notes
If I save the sanity of another team, it will all have been worth it.
Describe how to test your changes
Throw a suitably complex, but correct, SQL statement at your database and watch the obfuscator weep. Ours was about 2000 lines long, but that's our problem.