Skip to content

[ AGNTLOG-700 ] Honor bind_host on UDP log listeners - #54487

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
ddrthall/fix-udp-listener-bind-host
Aug 7, 2026
Merged

[ AGNTLOG-700 ] Honor bind_host on UDP log listeners#54487
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
ddrthall/fix-udp-listener-bind-host

Conversation

@ddrthall

@ddrthall ddrthall commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

UDP log listeners now bind to the address configured in bind_host instead of always listening on the wildcard address. TCP log listeners already honored the setting; the UDP listener built its listen address from the port alone and silently discarded bind_host. Sources that leave bind_host unset are unaffected and continue to listen on all interfaces.

Motivation

bind_host is documented as applying to both TCP and UDP log sources, so an operator restricting a UDP syslog listener to a specific management interface would reasonably expect the port to be reachable only there. In practice the socket was bound to the IPv6 wildcard address and accepted datagrams on every interface, which makes this a silent exposure rather than merely an ignored option.

The release note is updated as if this was a new feature for TCP AND UDP, because the specific bind host functionality can be separated from the preview feature the option was previously soft-gated behind.

Describe how you validated your changes

TestUDPBindHost was added, mirroring the existing TestTCPBindHost, and confirmed to fail against the previous behavior — the listener reported [::]:<port> rather than the configured address. The full package suite passes via dda inv test --targets=./pkg/logs/launchers/listener (31 tests), alongside dda inv linter.go --only-modified-packages.

Additional Notes

No configuration migration is required: an empty bind_host still resolves to :<port>, preserving the all-interfaces default.

UDP log listeners built their listen address as ":<port>", discarding any
configured bind_host and always binding the wildcard address. A source
configured to listen on a specific management interface was therefore
reachable on every interface.

Build the address with net.JoinHostPort as the TCP listener already does.
An unset bind_host still yields ":<port>", so existing configurations keep
listening on all interfaces.
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Aug 5, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Aug 5, 2026
@ddrthall ddrthall changed the title Honor bind_host on UDP log listeners [ AGNTLOG-700 ] Honor bind_host on UDP log listeners Aug 5, 2026
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 52.16% (+0.04%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 71d61f9 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 285f88c2:

Results for datadog-agent_7.83.0~devel.git.597.71d61f9.pipeline.129630801-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 285f88c
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_heroku_amd64 +4.0 KiB (0.00% increase, -0.06% of buffer) 311.979 → 311.983 → 318.880
agent_rpm_arm64_fips +4.24 KiB (0.00% increase, -0.28% of buffer) 690.763 → 690.768 → 692.250
agent_suse_arm64_fips +4.24 KiB (0.00% increase, -0.28% of buffer) 690.763 → 690.768 → 692.250
29 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 757.800 MiB
agent_deb_amd64_fips 711.407 MiB
agent_rpm_amd64 757.784 MiB
agent_rpm_amd64_fips 711.390 MiB
agent_rpm_arm64 733.879 MiB
agent_suse_amd64 757.784 MiB
agent_suse_amd64_fips 711.390 MiB
agent_suse_arm64 733.879 MiB
docker_agent_amd64 816.455 MiB
docker_agent_arm64 817.613 MiB
docker_agent_jmx_amd64 1007.352 MiB
docker_agent_jmx_arm64 997.162 MiB
docker_cluster_agent_amd64 210.134 MiB
docker_cluster_agent_arm64 223.204 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.312 MiB
docker_dogstatsd_arm64 37.433 MiB
docker_host_profiler_amd64 305.316 MiB
docker_host_profiler_arm64 316.627 MiB
dogstatsd_deb_amd64 30.053 MiB
dogstatsd_deb_arm64 28.093 MiB
dogstatsd_rpm_amd64 30.053 MiB
dogstatsd_suse_amd64 30.053 MiB
iot_agent_deb_amd64 46.314 MiB
iot_agent_deb_arm64 42.990 MiB
iot_agent_deb_armhf 43.758 MiB
iot_agent_rpm_amd64 46.314 MiB
iot_agent_suse_amd64 46.313 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 5, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c9359b3b-847f-40e3-9a51-5e47327fa454

Baseline: 4b3b71f
Comparison: cac1aa0
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_private_action_runner memory utilization +0.79 [+0.66, +0.92] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.16 [+0.10, +0.22] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.08 [+0.02, +0.13] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.03 [-0.07, +0.01] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.11 [-0.21, -0.02] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization -0.36 [-0.40, -0.33] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -1.46 [-1.70, -1.21] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -2.98 [-3.84, -2.11] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 147.98MiB ≤ 154MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 728.91KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 492.82MiB ≤ 512MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 185.16MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 264.13MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 441.27 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 389.31MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 72.07MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 26.69 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 301.68MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 79.20 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 278.50MiB ≤ 310MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 20.50 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 287.58MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle baseline 10 Oom killed Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs baseline 10 Oom killed Debug Dashboard
quality_gate_metrics_logs comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle baseline 10 Crashed (exit code: 134) Debug Dashboard
quality_gate_security_no_fs_load comparison 10 Crashed (exit code: 134) Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.

@ddrthall ddrthall added the qa/done QA done before merge and regressions are covered by tests label Aug 7, 2026
@ddrthall
ddrthall marked this pull request as ready for review August 7, 2026 13:34
@ddrthall
ddrthall requested a review from a team as a code owner August 7, 2026 13:34
@github-actions github-actions Bot deleted a comment from chatgpt-codex-connector Bot Aug 7, 2026
@github-actions github-actions Bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Aug 7, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit cac1aa0 into main Aug 7, 2026
293 of 296 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the ddrthall/fix-udp-listener-bind-host branch August 7, 2026 17:36
@github-actions github-actions Bot added this to the 7.84.0 milestone Aug 7, 2026
niharikag09 pushed a commit to niharikag09/datadog-agent that referenced this pull request Aug 10, 2026
### What does this PR do?

UDP log listeners now bind to the address configured in `bind_host` instead of always listening on the wildcard address. TCP log listeners already honored the setting; the UDP listener built its listen address from the port alone and silently discarded `bind_host`. Sources that leave `bind_host` unset are unaffected and continue to listen on all interfaces.

### Motivation

`bind_host` is documented as applying to both TCP and UDP log sources, so an operator restricting a UDP syslog listener to a specific management interface would reasonably expect the port to be reachable only there. In practice the socket was bound to the IPv6 wildcard address and accepted datagrams on every interface, which makes this a silent exposure rather than merely an ignored option.

The release note is updated as if this was a new feature for TCP AND UDP, because the specific bind host functionality can be separated from the preview feature the option was previously soft-gated behind. 

### Describe how you validated your changes

`TestUDPBindHost` was added, mirroring the existing `TestTCPBindHost`, and confirmed to fail against the previous behavior — the listener reported `[::]:<port>` rather than the configured address. The full package suite passes via `dda inv test --targets=./pkg/logs/launchers/listener` (31 tests), alongside `dda inv linter.go --only-modified-packages`.

### Additional Notes
No configuration migration is required: an empty `bind_host` still resolves to `:<port>`, preserving the all-interfaces default.

Co-authored-by: ryan.hall <ryan.hall@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-log-pipelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants