Skip to content

[ABLD-366] Fix build file for cmd/loader so it can also build for macos. - #54739

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
aiuto/tracesel
Aug 12, 2026
Merged

[ABLD-366] Fix build file for cmd/loader so it can also build for macos.#54739
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
aiuto/tracesel

Conversation

@aiuto

@aiuto aiuto commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fix build file for cmd/loader so it can also build for macos.

  • Remove unneeded target_compatible_with
  • Adjust packaging to include it for macos.
  • Fix dd_agent_go_binary so we can select() exact_gotags

We are blocked on ABLD-294 for using the loader in the real package, so we just have it named "loader" for now. We can build and verify that it works.

Describe how you validated your changes

Make sure the loader builds and runs on mac. Running it is subtle.

$ bazel build //cmd/trace-agent:trace-agent
Target //cmd/trace-agent:trace-agent up-to-date:
  bazel-bin/cmd/trace-agent/trace-agent_/trace-agent
INFO: Build completed successfully, 1 total action
$ cp bazel-bin/cmd/trace-agent/trace-agent_/trace-agent /tmp
$ bazel build //cmd/loader:loader
Target //cmd/loader:loader up-to-date:
  bazel-bin/cmd/loader/loader_/loader
$ bazel-bin/cmd/loader/loader_/loader /opt/datadog-agent/etc/datadog.yaml /tmp/trace-agent
...
2026-08-11 14:45:52 EDT | TRACE-LOADER | INFO | (pkg/util/log/log.go:734 in func1) | Starting to load the configuration
2026-08-11 14:45:52 EDT | TRACE-LOADER | ERROR | (pkg/util/log/log.go:815 in func1) | warning reading config
...
### Additional Notes

@aiuto
Fix build file for cmd/loader so it can also build for macos.
40d95e5 
Fix build file for cmd/loader so it can also build for macos.
- Remove unneeded target_compatible_with
- Adjust packaging to include it for macos.

Note that we are blocked on ABLD-294 for using the loader in the package,
so we just have it named "next_loader" now.

Testing. Make sure the loader builds and runs on mac.  Running it is subtle.
```
$ bazel build //cmd/trace-agent:trace-agent
Target //cmd/trace-agent:trace-agent up-to-date:
  bazel-bin/cmd/trace-agent/trace-agent_/trace-agent
INFO: Build completed successfully, 1 total action
$ cp bazel-bin/cmd/trace-agent/trace-agent_/trace-agent /tmp
$ bazel build //cmd/loader:next_loader
Target //cmd/loader:next_loader up-to-date:
  bazel-bin/cmd/loader/next_loader_/next_loader
$ bazel-bin/cmd/loader/loader_/loader /opt/datadog-agent/etc/datadog.yaml /tmp/trace-agent
...
2026-08-11 13:23:17 EDT | TRACE-LOADER | INFO | (pkg/util/log/log.go:734 in func1) | Starting to load the configuration
...
```
@aiuto aiuto added the changelog/no-changelog No changelog entry needed label Aug 11, 2026
@aiuto
aiuto requested a review from a team as a code owner August 11, 2026 17:28
@aiuto aiuto added the qa/no-code-change No code change in Agent code requiring validation label Aug 11, 2026
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Aug 11, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Aug 11, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor d92193ff:

Results for datadog-agent_7.84.0~devel.git.68.6467f43.pipeline.130289110-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.84.0~devel.git.68.6467f43.pipeline.130289110-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d92193f
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
✅ docker_agent_amd64 +4.05 KiB (0.00% increase, -0.22% of buffer) 818.152 → 818.156 → 819.970
✅ docker_agent_arm64 +4.06 KiB (0.00% increase, -0.26% of buffer) 819.156 → 819.160 → 820.690
✅ docker_agent_jmx_amd64 +4.06 KiB (0.00% increase, -0.24% of buffer) 1009.049 → 1009.053 → 1010.730
✅ docker_agent_jmx_arm64 +4.05 KiB (0.00% increase, -0.24% of buffer) 998.706 → 998.710 → 1000.370
✅ docker_host_profiler_amd64 +7.21 KiB (0.00% increase, -0.06% of buffer) 305.804 → 305.811 → 317.690
✅ docker_host_profiler_arm64 +7.23 KiB (0.00% increase, -0.06% of buffer) 317.117 → 317.125 → 328.970
27 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_deb_amd64 759.540 MiB
✅ agent_deb_amd64_fips 712.874 MiB
✅ agent_heroku_amd64 312.288 MiB
✅ agent_msi 643.267 MiB
✅ agent_rpm_amd64 759.524 MiB
✅ agent_rpm_amd64_fips 712.858 MiB
✅ agent_rpm_arm64 735.484 MiB
✅ agent_rpm_arm64_fips 692.097 MiB
✅ agent_suse_amd64 759.524 MiB
✅ agent_suse_amd64_fips 712.858 MiB
✅ agent_suse_arm64 735.484 MiB
✅ agent_suse_arm64_fips 692.097 MiB
✅ docker_cluster_agent_amd64 210.350 MiB
✅ docker_cluster_agent_arm64 223.393 MiB
✅ docker_cws_instrumentation_amd64 7.439 MiB
✅ docker_cws_instrumentation_arm64 6.877 MiB
✅ docker_dogstatsd_amd64 39.479 MiB
✅ docker_dogstatsd_arm64 37.623 MiB
✅ dogstatsd_deb_amd64 30.224 MiB
✅ dogstatsd_deb_arm64 28.247 MiB
✅ dogstatsd_rpm_amd64 30.224 MiB
✅ dogstatsd_suse_amd64 30.224 MiB
✅ iot_agent_deb_amd64 46.428 MiB
✅ iot_agent_deb_arm64 43.099 MiB
✅ iot_agent_deb_armhf 43.879 MiB
✅ iot_agent_rpm_amd64 46.428 MiB
✅ iot_agent_suse_amd64 46.427 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 911b7adc-8a0f-46ba-8f93-c1f96983f2b4

Baseline: 4b6f43f
Comparison: 27fda3f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_idle memory utilization +0.43 [+0.31, +0.55] 1 Logs bounds checks dashboard
➖ quality_gate_private_action_runner memory utilization +0.25 [+0.14, +0.37] 1 Logs bounds checks dashboard
➖ quality_gate_metrics_logs memory utilization +0.16 [-0.09, +0.41] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization -0.03 [-0.08, +0.01] 1 Logs bounds checks dashboard
➖ quality_gate_security_idle memory utilization -0.24 [-0.35, -0.13] 1 Logs bounds checks dashboard
➖ quality_gate_security_mean_fs_load memory utilization -0.34 [-0.41, -0.26] 1 Logs bounds checks dashboard
➖ quality_gate_security_no_fs_load memory utilization -0.36 [-0.50, -0.22] 1 Logs bounds checks dashboard
➖ quality_gate_logs % cpu utilization -1.70 [-2.55, -0.85] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed observed_value links
✅ quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
❌ quality_gate_idle memory_usage 0/10 174.07MiB > 154MiB bounds checks dashboard
✅ quality_gate_idle total_bytes_received 10/10 728.01KiB ≤ 819.20KiB bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
❌ quality_gate_idle_all_features memory_usage 9/10 512.68MiB > 512MiB bounds checks dashboard
✅ quality_gate_idle_all_features total_bytes_received 10/10 1.13MiB ≤ 1.25MiB bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 16 ≤ 40 bounds checks dashboard
❌ quality_gate_logs memory_usage 0/10 203.63MiB > 195MiB bounds checks dashboard
✅ quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_logs total_bytes_received 10/10 264.37MiB ≤ 292MiB bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 367.71 ≤ 2000 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 18 ≤ 40 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 393.53MiB ≤ 430MiB bounds checks dashboard
✅ quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
✅ quality_gate_private_action_runner memory_usage 10/10 72.92MiB ≤ 75MiB bounds checks dashboard
✅ quality_gate_security_idle cpu_usage 10/10 26.40 ≤ 100 bounds checks dashboard
✅ quality_gate_security_idle memory_usage 10/10 324.97MiB ≤ 330MiB bounds checks dashboard
✅ quality_gate_security_mean_fs_load cpu_usage 10/10 59.20 ≤ 200 bounds checks dashboard
✅ quality_gate_security_mean_fs_load memory_usage 10/10 306.06MiB ≤ 310MiB bounds checks dashboard
✅ quality_gate_security_no_fs_load cpu_usage 10/10 20.05 ≤ 100 bounds checks dashboard
✅ quality_gate_security_no_fs_load memory_usage 10/10 308.12MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features comparison 10 Oom killed Debug Dashboard
quality_gate_security_idle baseline 10 Oom killed Debug Dashboard
quality_gate_security_idle comparison 10 Oom killed Debug Dashboard

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.
  • quality_gate_idle_all_features, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 27fda3f into main Aug 12, 2026
292 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the aiuto/tracesel branch August 12, 2026 16:16
@github-actions github-actions Bot added this to the 7.84.0 milestone Aug 12, 2026
github-actions Bot pushed a commit that referenced this pull request Aug 12, 2026
@gh-worker-dd-mergequeue-cf854d
[ABLD-366] Fix build file for cmd/loader so it can also build for mac…
63fade2 
…os. (#54739)

### What does this PR do?

Fix build file for cmd/loader so it can also build for macos.
- Remove unneeded target_compatible_with
- Adjust packaging to include it for macos.
- Fix dd_agent_go_binary so we can select() `exact_gotags`

We are blocked on ABLD-294 for using the loader in the real package, so we just have it named "loader" for now. We can build and verify that it works.

### Describe how you validated your changes
Make sure the loader builds and runs on mac.  Running it is subtle.
```
$ bazel build //cmd/trace-agent:trace-agent
Target //cmd/trace-agent:trace-agent up-to-date:
  bazel-bin/cmd/trace-agent/trace-agent_/trace-agent
INFO: Build completed successfully, 1 total action
$ cp bazel-bin/cmd/trace-agent/trace-agent_/trace-agent /tmp
$ bazel build //cmd/loader:loader
Target //cmd/loader:loader up-to-date:
  bazel-bin/cmd/loader/loader_/loader
$ bazel-bin/cmd/loader/loader_/loader /opt/datadog-agent/etc/datadog.yaml /tmp/trace-agent
...
2026-08-11 14:45:52 EDT | TRACE-LOADER | INFO | (pkg/util/log/log.go:734 in func1) | Starting to load the configuration
2026-08-11 14:45:52 EDT | TRACE-LOADER | ERROR | (pkg/util/log/log.go:815 in func1) | warning reading config
...
### Additional Notes

Co-authored-by: tony.aiuto <tony.aiuto@datadoghq.com> 27fda3f
aiuto added a commit that referenced this pull request Aug 12, 2026
@aiuto
account for PR #54739
15c830d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JSGette JSGette JSGette approved these changes

Assignees

No one assigned

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build

Projects

None yet

Milestone

7.84.0

Development

Successfully merging this pull request may close these issues.

2 participants

@aiuto @JSGette